Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1617957240-53633-1-git-send-email-tiantao6@hisilicon.com>
 <CAGngYiVfattJKO7npMHTagxNfzU-B=rP3FoZ89_yzy-c=Zw2RQ@mail.gmail.com> <44f55f42-cb52-f705-c40a-6d5c1844f56b@huawei.com>
In-Reply-To: <44f55f42-cb52-f705-c40a-6d5c1844f56b@huawei.com>
From:   Sven Van Asbroeck <thesven73@gmail.com>
Date:   Mon, 12 Apr 2021 08:40:36 -0400
Message-ID: <CAGngYiV2dH4nLkFocyL4YkYkL3qu_kyB5ELZbWLeFMjjsFRpwQ@mail.gmail.com>
Subject: Re: [PATCH] staging: fieldbus: simplify devm_anybuss_host_common_probe
To:     "tiantao (H)" <tiantao6@huawei.com>
Cc:     Tian Tao <tiantao6@hisilicon.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Apr 11, 2021 at 9:14 PM tiantao (H) <tiantao6@huawei.com> wrote:
>
> What about doing it like this?
>
> -static void host_release(struct device *dev, void *res)
> +static void host_release(void *res)
>   {
> -       struct anybuss_host **dr = res;
> -
> -       anybuss_host_common_remove(*dr);
> +       anybuss_host_common_remove(res);
>   }

That looks like it could work. Can you resend as a "proper" patch,
please? To tell the versions apart, simply specify [PATCH v1] [PATCH
v2] etc in the patch title/subject line. Then below the patch's "---
line", add the version history.