Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 12 Apr 2021 16:40:30 +0300
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel][PATCH 1/4 v2] staging: media: omap4iss:
 Replace macro function by static inline function in file iss.c
Message-ID: <YHRNzq3h3LEp3Dgc@pendragon.ideasonboard.com>
References: <cover.1618231618.git.alinesantanacordeiro@gmail.com>
 <e302566a3d9e5180ab27eb2c2824fd1b678a6d99.1618231618.git.alinesantanacordeiro@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <e302566a3d9e5180ab27eb2c2824fd1b678a6d99.1618231618.git.alinesantanacordeiro@gmail.com>
Precedence: bulk

Hi Aline,

While testing on a device isn't a requirement as you can't be expected
to have the necessary hardware, changes are expected to be at least
compile-tested before being submitted.

On Mon, Apr 12, 2021 at 09:57:09AM -0300, Aline Santana Cordeiro wrote:
> Replace macro function by static inline function.
> Issue suggested by Julia.
> 
> Signed-off-by: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>
> ---
> 
> Changes since v1:
>  - Insert file path in commit message
> 
>  drivers/staging/media/omap4iss/iss.c | 24 +++++++++++++-----------
>  1 file changed, 13 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
> index c89f268a..3bbc39e 100644
> --- a/drivers/staging/media/omap4iss/iss.c
> +++ b/drivers/staging/media/omap4iss/iss.c
> @@ -27,22 +27,24 @@
>  #include "iss.h"
>  #include "iss_regs.h"
>  
> -#define ISS_PRINT_REGISTER(iss, name)\
> -	dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n", \
> -		iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_##name))
> +static inline iss_print_register(iss, name)
> +{
> +	dev_dbg(iss->dev, "###ISS " #name "=0x%08x\n",
> +		iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_##name));
> +}
>  
>  static void iss_print_status(struct iss_device *iss)
>  {
>  	dev_dbg(iss->dev, "-------------ISS HL Register dump-------------\n");
>  
> -	ISS_PRINT_REGISTER(iss, HL_REVISION);
> -	ISS_PRINT_REGISTER(iss, HL_SYSCONFIG);
> -	ISS_PRINT_REGISTER(iss, HL_IRQSTATUS(5));
> -	ISS_PRINT_REGISTER(iss, HL_IRQENABLE_SET(5));
> -	ISS_PRINT_REGISTER(iss, HL_IRQENABLE_CLR(5));
> -	ISS_PRINT_REGISTER(iss, CTRL);
> -	ISS_PRINT_REGISTER(iss, CLKCTRL);
> -	ISS_PRINT_REGISTER(iss, CLKSTAT);
> +	iss_print_register(iss, HL_REVISION);
> +	iss_print_register(iss, HL_SYSCONFIG);
> +	iss_print_register(iss, HL_IRQSTATUS(5));
> +	iss_print_register(iss, HL_IRQENABLE_SET(5));
> +	iss_print_register(iss, HL_IRQENABLE_CLR(5));
> +	iss_print_register(iss, CTRL);
> +	iss_print_register(iss, CLKCTRL);
> +	iss_print_register(iss, CLKSTAT);
>  
>  	dev_dbg(iss->dev, "-----------------------------------------------\n");
>  }

-- 
Regards,

Laurent Pinchart