Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1788464pxb; Mon, 12 Apr 2021 06:49:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/k5Xz1+yOXGJK1ugev+7OaGbTI2AxEipfHHxWnfVigTJ6UrW+KaIT7uo4g+6+E9HvQSK3 X-Received: by 2002:a17:906:f1d7:: with SMTP id gx23mr27370148ejb.109.1618235397171; Mon, 12 Apr 2021 06:49:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618235397; cv=none; d=google.com; s=arc-20160816; b=w6bmi49DeonBXXEOGLniTvRTLZmunpLH/D7FrW49Q8s8uH0qetv94uCJ8i+m8yJ8+j w90wEX1iZPTiBHqkJASdn4Fx7Cfpqm9AQRsLCBDyi40EGeBw1CZzJ6WOMUI1wgsbiwKR aIfzbglAxaHevig2HQ5uUKidVRXUhIwTceerp9cPXokNvWwGIHetJ6fqPZ1n5suTwXtZ 2eqB9tX6Fg4iFC4xzhfeTBjFBD/jlnpm4udDneJBgu0YHU4gx+/sAG5Yc50EF4vmIRmx ZxrK4hi7Hyl8UzWjjZqEk9Cm5d+6VnCk/I23fOXp+Ep969vx8B9rf5VLDs3beecy46zT D2Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=gytAL/yvWV0C/C+QEAvYYaxpKrXZ+OUo1TE3J+Md6ys=; b=o7aCbrBMIbNjXOz8c150lqDRN8bNGjUxPEujaB1+ZMs2o1/3LX6HpBtfQwvgJkWIUY TTxBBD69bdSOGlmP87DEWn04juRWVSgTNEyRFn4yJQQMdF+WBUCwlWdmjQkUgue6m1z3 DQoNku5p3++0byDBjjXzYAevRjB+/r7ZG3olfWfPuN2OhQSH/2sZc8ti9aff6n/o7IQE i6Y8/gKx09U1KFlFVVKzCayP1YRRq5fXtYnYGojha/9LLIZsXmAOMsdjR6G5w0stRhXc 5Dy6A8IJIsJ7kmY1+fehdHxUvymEO59vuYMB909qCl3o55c0UdCVyDvj/N96ENGtkmE5 5/PA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=D480wbwN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r20si8035515edw.406.2021.04.12.06.49.33; Mon, 12 Apr 2021 06:49:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=D480wbwN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241917AbhDLNs5 (ORCPT + 99 others); Mon, 12 Apr 2021 09:48:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237043AbhDLNs5 (ORCPT ); Mon, 12 Apr 2021 09:48:57 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 148C8C061574 for ; Mon, 12 Apr 2021 06:48:39 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id u20so2322269wmj.0 for ; Mon, 12 Apr 2021 06:48:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gytAL/yvWV0C/C+QEAvYYaxpKrXZ+OUo1TE3J+Md6ys=; b=D480wbwNLKlAyfVkcA1JsZYy/BJ1qJcaF1+jY+CkOsjJHpVeQgIGm5L3HiubXoP8np qJGDbnjgWUSL2ISmwd0pUK9fe45YRl9xlkHsUWjhnmX4Hd0Pbfj+QruFYy4rTiIOaILP +chfTiiw9AQFz07iI9oPx6sLocK1jrGfb96B3XJluj4PLSSI3v1xBXE4S+YHGhuLwqLm DQCyLZXlIu8fz+SfZAXs9WGaSRZAeJ+twZQ5HdfGYyI8uAzkllHhlM1nQgAzwbTsr2RX XhgR/B7hLRaJC60Dva83D3+9WoS9fwuWdXcINw6EAnGGVMBQVszVzbgaV8Yyegtm+QGW T8+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gytAL/yvWV0C/C+QEAvYYaxpKrXZ+OUo1TE3J+Md6ys=; b=Kvej6RFfG2VqNyR8Vo9IW8gxRPCfCJ7WoGoJT82PopOs/XNrdGHwPPuKtaeUiSTlM3 pAdqtPG4JIb9WHQsBlOJJ+RgOgRwfMW7gI71Zz+KMkeo6SqvYEILykGYD3F3aRFdM6bX TJ9Z7fqzXGPvoLOFqHCGG9VVFkYmf9ISHeFqILhMAv52xNuqFF5bfuAQQRHXWsbB4Jxd BBc6xDZJJf79XqOLv9QLrIBRgePrmdsmAhep/tYeGxnae4tnARj2xYLrZmGTY404FMFa /04FoZUcSpuHnT1cxUIVYwG4nwQsUjk8v2ZPbO44cK3g/EP8BAxHwBUzRJKW3Gee2ObZ hSHQ== X-Gm-Message-State: AOAM531jBKpJtwjYEgX0/AvvmjCoyXtwcyMbg2xbzzrsCZp7z/cF71fm DNlVLTxLjNbli3jluz0E9U6cmg== X-Received: by 2002:a7b:c7d3:: with SMTP id z19mr27332470wmk.139.1618235317683; Mon, 12 Apr 2021 06:48:37 -0700 (PDT) Received: from localhost.localdomain ([2a01:e0a:90c:e290:4c21:b00e:ff79:bf20]) by smtp.gmail.com with ESMTPSA id m3sm17084423wme.40.2021.04.12.06.48.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Apr 2021 06:48:37 -0700 (PDT) From: Neil Armstrong To: hverkuil-cisco@xs4all.nl Cc: linux-media@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Neil Armstrong Subject: [PATCH] media: meson-ge2d: fix rotation parameters Date: Mon, 12 Apr 2021 15:48:33 +0200 Message-Id: <20210412134833.3467694-1-narmstrong@baylibre.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Patch-Hashes: v=1; h=sha256; i=MnWqbtgLNHEO28iGPrU+2fi2Vi4/zgsTM+Wk44sFw6M=; m=LSyi1GIrRi5+cTBT/6Pa7vdOC7D2by2eVWnO1StDcX8=; p=ddQBmT3ON6PerWL2JNhQ08pBoO1RzWVwzA9FpwbnVjk=; g=a5d89b1dd77083c5c89c5f661408958dbf25cbb4 X-Patch-Sig: m=pgp; i=narmstrong@baylibre.com; s=0xA4CFF8AE; b=iQIzBAABCgAdFiEEPVPGJshWBf4d9CyLd9zb2sjISdEFAmB0T5MACgkQd9zb2sjISdH0yg/+KQL O6DzQoiEzq7fvnh5Cfi3Ivw46p6oSQO4az4sxBwfpC2O0aTprtUvFzwvrDLdhncJisN3lwXEEIjIx CyPheCQT9fR4OWvEtzAYkMf7V6fS0j0RHzYVpwSkk30gpmLby5DRlfAjm9MWX9LkV++Fehgd6bBBF JSmUc5Y9er2kdQOjqsnTJFxafDRJKqwidz0hb5RKd01SANxhGnnN14S6xV5VR3n0hyZaDG5h5rn8D U2Xa+VvSf5pIrRdCRF7WADadib4MIjVJrw5lf8na3bfN+42w4Chn50NoFMftmToxRRsR/eFaKbH2/ 6xXqTyhvng4j2JZrwn6LZuEX30MJaFJRz4iGQEH80gxM8c9t9S+6G/4m10j9ZDxIYsYKxg6eCnHIa Yeidwea1rkpBloTzmN9R8fu/Wd9i8SxA9BdaPIDYjIieCdwy6JDl8SBHqG6rVHgk8ElqI6zlvObaa aNEt7f1l+1c3baq9JlV2EuTXFrcXtoFOwEMIOSM6GXLNke2yIGDgYLM3q2f8V3mg2SSUblG8KgBRt jkBsDFTdzksBPjq4rCC3eg9R+hi4k5Yzb/mql6gLvmOaA+Ixg7C5vW0ocPCRedgFECSAASz8cgSXh u62cWPv2Luv7oHEpYhwfH9M8ZtDtSmfyt9N+DHmvDQn809dT5HSxLSLuvdHSoNhQ= Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org With these settings, 90deg and 270deg rotation leads to inverted vertical, fix them to have correct rotation. Fixes: 59a635327ca7 ("media: meson: Add M2M driver for the Amlogic GE2D Accelerator Unit") Signed-off-by: Neil Armstrong --- drivers/media/platform/meson/ge2d/ge2d.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/meson/ge2d/ge2d.c b/drivers/media/platform/meson/ge2d/ge2d.c index 153612ca96fc..a1393fefa8ae 100644 --- a/drivers/media/platform/meson/ge2d/ge2d.c +++ b/drivers/media/platform/meson/ge2d/ge2d.c @@ -757,7 +757,7 @@ static int ge2d_s_ctrl(struct v4l2_ctrl *ctrl) if (ctrl->val == 90) { ctx->hflip = 0; - ctx->vflip = 0; + ctx->vflip = 1; ctx->xy_swap = 1; } else if (ctrl->val == 180) { ctx->hflip = 1; @@ -765,7 +765,7 @@ static int ge2d_s_ctrl(struct v4l2_ctrl *ctrl) ctx->xy_swap = 0; } else if (ctrl->val == 270) { ctx->hflip = 1; - ctx->vflip = 1; + ctx->vflip = 0; ctx->xy_swap = 1; } else { ctx->hflip = 0; -- 2.25.1