Subject: Re: [PATCH] serial: handle pci_enable_device() failure upon resume
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>, Jeff Garzik <jeff@garzik.org>,
       linux-serial@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
In-Reply-To: <20061013131516.227e99ee.akpm@osdl.org>
References: <20061012014720.GA12935@havoc.gtf.org>
	 <20061013075953.GC28654@flint.arm.linux.org.uk>
	 <20061013131516.227e99ee.akpm@osdl.org>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Date: Sat, 14 Oct 2006 00:15:43 +0100
Message-Id: <1160781343.25218.89.camel@localhost.localdomain>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 948
Lines: 20

Ar Gwe, 2006-10-13 am 13:15 -0700, ysgrifennodd Andrew Morton:
> Right now, we get silent failure *and* a compile-time warning.  It's hard
> to see how that situation could be made worse.

I support Russells NAK but for another reason. You can't use printk in
the paths of a serial driver that may be the console. There is already a
whole ordering issue here and I'm not convinced it is handled correctly
reviewing the diff. Printks will make it worse in any driver (and waste
memory on handling impossible untestable situations that don't appen)

The printk case and serial first ordering want fixing correctly because
serial console is about the only sane way to debug resume in the first
place.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/