Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp1933317pxb; Mon, 12 Apr 2021 09:59:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyK9G3Rc5mtRCUFYztN9P7KQlZYtx+ygCH2yw2/0mKHa/J/fCF8KdH6kn1JBycnwFBbOTfC X-Received: by 2002:a17:902:6a87:b029:e6:6a3d:29e8 with SMTP id n7-20020a1709026a87b02900e66a3d29e8mr26600021plk.10.1618246747695; Mon, 12 Apr 2021 09:59:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618246747; cv=none; d=google.com; s=arc-20160816; b=IL01qmCYRuBf1+MSK741XdA3B7g1hBQ93FVPZJ0YvjqaqOwS1fSzc792zVpgxCUKIq xB8bSDs35+tItaJmSaMl0zc5U7Dj3w7YBaVcVW2Tx5U1K+k7y+utBujEreeGHrn/PnZ6 CcU9jNir29RZZb+3ELGBG9Ji/OwajX3/+tVlMG1cg8oRFC+1vtD+onnek4k9maxVCNxW cElSNJ/9IWDLpJCIwbGZUvlMq8H5ehjH2qX7XbqZEF/kfd/kUlh0WXTJW4dBsLQY8cxB KuNXJt0Xd3uQZlJWuRA9svNrUbGIPkIiQvb+02KUOVv+dB3yn5lOrAaOO+GFBAn0+nHu D9rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=ih+0GqG0uL4euGP05tSlPSYf9GJQgiYwym/q7d7zBIk=; b=PYo/J8ZDnp1Nn7aJumuHDl+kPuiYqtYyN6qKxsJ8VtEmBFTBoUPghsVZVgwj3HRAZC y68Enj0Z0pa3inzrb+t+JJx2WUNHNcYXkiJEQmIqIsb2hbE3QzZqQXooon9pCQlOg9KO D0O4+QN9YYSMqj11Nml33VAPe8nhmHGYejlCCbFibLPP1MgLjtRbMECzY/VqMWlCZgGM sAqt19teQTDCNjMxsjRDoxB4JD3X7sGGzNigmUgytb6N3ByyH4Maf84yRmTiMC+7CZ0k rZN2l7NABlpSPZy/3DP03R4krKZa1nERewQKL7kl+jeTOT6IT0XwRlo3czt2sO+Xbv7l zk1Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h12si16712598plr.246.2021.04.12.09.58.54; Mon, 12 Apr 2021 09:59:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244026AbhDLQ5W (ORCPT + 99 others); Mon, 12 Apr 2021 12:57:22 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:46198 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245729AbhDLQw3 (ORCPT ); Mon, 12 Apr 2021 12:52:29 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lVzn7-00GIiy-TB; Mon, 12 Apr 2021 18:52:01 +0200 Date: Mon, 12 Apr 2021 18:52:01 +0200 From: Andrew Lunn To: "Radu Nicolae Pirea (NXP OSS)" Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: nxp-c45: add driver for tja1103 Message-ID: References: <20210409184106.264463-1-radu-nicolae.pirea@oss.nxp.com> <64e44d26f45a4fcfc792073fe195e731e6f7e6d9.camel@oss.nxp.com> <111528aed55593de83a17dc8bd6d762c1c5a3171.camel@oss.nxp.com> <82741edede173f50a5cae54e68cf51f6b8eb3fe3.camel@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <82741edede173f50a5cae54e68cf51f6b8eb3fe3.camel@oss.nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 12, 2021 at 05:49:04PM +0300, Radu Nicolae Pirea (NXP OSS) wrote: > On Mon, 2021-04-12 at 16:23 +0200, Andrew Lunn wrote: > > > It is purely a C45 device. > > > > > Even if the PHY will be based on the same IP or not, if it is a C45 > > > PHY, it will be supported by this driver. We are not talking about > > > 2 or > > > 3 PHYs. This driver will support all future C45 PHYs. That's why we > > > named it "NXP C45". > > > > So if in future you produce C45 multi-gige PHYs, which have nothing > > in > > common with the T1 automative PHY, it will still be in this driver? > Yes. C45 is robust and, if the PHY interface is standard, you can > support Base-T, Base-T1, and so on in the same register interface. So what you are say is, you don't care if the IP is completely different, it all goes in one driver. So lets put this driver into nxp-tja11xx.c. And then we avoid all the naming issues. Andrew