Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 12 Apr 2021 17:10:45 +0000
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
From:   Bryan Brattlof <hello@bryanbrattlof.com>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Reply-To: Bryan Brattlof <hello@bryanbrattlof.com>
Subject: Re: [PATCH v2] staging: rtl8723bs: remove unnecessary adapter
Message-ID: <20210412170939.beicrv26yiaapt7i@bryanbrattlof.com>
In-Reply-To: <YHR5L2aSZ4hNNmT0@kroah.com>
References: <20210412163650.42467-1-hello@bryanbrattlof.com> <YHR5L2aSZ4hNNmT0@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Apr 12, 2021 at 06:45:35PM +0200, Greg Kroah-Hartman wrote:
>
>On Mon, Apr 12, 2021 at 04:43:56PM +0000, Bryan Brattlof wrote:
>> The if2 adapter is defined in rtw_dvr_init() and in the dvobj_priv
>> structure but never used anywhere in the driver. This will remove all
>> definitions of if2
>>
>> Signed-off-by: Bryan Brattlof <hello@bryanbrattlof.com>
>> ---
>>  drivers/staging/rtl8723bs/include/drv_types.h |  1 -
>>  drivers/staging/rtl8723bs/os_dep/sdio_intf.c  | 10 ++++------
>>  2 files changed, 4 insertions(+), 7 deletions(-)
>
>What changed from v1?  That goes below the --- line.
>
>v3?

Oops.

it's the simple things that always seem to be the hardest :)

During the rebase to next-20210412, I lost the bracket on the=20
conditional statement:

   394: +free_if1:
   395:          if (status !=3D _SUCCESS && if1) {
=09=09=09=09=09=09^

I'll be sending v3 shortly with a proper change long :)
--
~Bryan