Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2051710pxb; Mon, 12 Apr 2021 13:03:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfh9618dUwrsrv/gMWmKA2e6Tjh/lAADoPCq+ruVI5OZvEl2Do8RWrvR4th32I1biVFEiv X-Received: by 2002:a62:e70e:0:b029:245:3a00:5720 with SMTP id s14-20020a62e70e0000b02902453a005720mr21064740pfh.0.1618257790140; Mon, 12 Apr 2021 13:03:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618257790; cv=none; d=google.com; s=arc-20160816; b=Rvqg/tHzEvvsARCPsN9KrwqNYcjUliNC9HrduI2lWvVO57k+rrd57Efk8QpXZITKGr Ap/rqLotvAEx813mJZVPwIYbxXTXkqOGuC5c3KbJOPAARcYvvbAIluN1l5YxM89HlT1C X9GDHYPiMRvJIrDnvRcSgYaxP4AWLLLnguyy85/owArXZiKIeqCXmqwKg/WlOGrY7zvk PuUPvJhbUSe4YvkUR9xwMSRy6n1Og2tg22FI5oWKFnVfBejm4yVJpIGerUBbtuSjrBg5 MRFL0cY29IWJbDXRyi47Z3Y7872uBNhp7oab6PWtndKJqf5MQ3SHxhfJlMY/8oQdnBUn RUmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WA5b0k6zYKKv4ola9Sf2WP4Cs7ryX5maewGQLIjZSBs=; b=CtQWXQdwie7geUmZn/i7AN2Tpl7PamYNt0i60GY7G5CcAQzE0QyH0byWSM/4aEdjgN 47tbHgml9ESXEBn4E6+ERWv95Rj6Ihgus+WufEZ/WVJ7V5cIubYzQSvXjvAgupAv2CCg RjCPt9JipGbtC62W+xlIuG/0W3zgSedHozXqVIEOdB2SbRi+4OAGCS6efQJUCaicjDjx MRkpODCOmJHALu6lVqMG0Vx4SGXCNF6AjsG/SapiQsKpm3KP+427KFOZA+kF91Sh7wmS 3GRkIt61luqtmJaieGDbulcjBIM++iN3Q209imRaxfNazrvcgUX4vQ5gYT9KSRZWOfaz pY5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ev7ui100; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l13si462867pjm.38.2021.04.12.13.02.57; Mon, 12 Apr 2021 13:03:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ev7ui100; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237608AbhDLIo3 (ORCPT + 99 others); Mon, 12 Apr 2021 04:44:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:35930 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236981AbhDLIoB (ORCPT ); Mon, 12 Apr 2021 04:44:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 926FA6109E; Mon, 12 Apr 2021 08:43:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618217024; bh=9qxFI8kjXQH84R9qlKbUR6XSWDAfymstV46usNN4liY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ev7ui100O6XSp6gfPA2JBKQYCF43fLVLAwNdivBjRv9ten7GrRmYp/kRP6X5eJ2Cs O8adjbeRbehq6utSCIRNMA5VSKXy7hjwyj8SKkIRY85f+SVaFpzFtcxSlbNA2Ze/71 U92VwBKJ3vicBAs25+MrcnMizJwKGKJBR9Pb0OP0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, Bastian Germann , Mark Brown , Sasha Levin Subject: [PATCH 4.19 42/66] ASoC: sunxi: sun4i-codec: fill ASoC card owner Date: Mon, 12 Apr 2021 10:40:48 +0200 Message-Id: <20210412083959.481524124@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210412083958.129944265@linuxfoundation.org> References: <20210412083958.129944265@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bastian Germann [ Upstream commit 7c0d6e482062eb5c06ecccfab340abc523bdca00 ] card->owner is a required property and since commit 81033c6b584b ("ALSA: core: Warn on empty module") a warning is issued if it is empty. Add it. This fixes following warning observed on Lamobo R1: WARNING: CPU: 1 PID: 190 at sound/core/init.c:207 snd_card_new+0x430/0x480 [snd] Modules linked in: sun4i_codec(E+) sun4i_backend(E+) snd_soc_core(E) ... CPU: 1 PID: 190 Comm: systemd-udevd Tainted: G C E 5.10.0-1-armmp #1 Debian 5.10.4-1 Hardware name: Allwinner sun7i (A20) Family Call trace: (snd_card_new [snd]) (snd_soc_bind_card [snd_soc_core]) (snd_soc_register_card [snd_soc_core]) (sun4i_codec_probe [sun4i_codec]) Fixes: 45fb6b6f2aa3 ("ASoC: sunxi: add support for the on-chip codec on early Allwinner SoCs") Related: commit 3c27ea23ffb4 ("ASoC: qcom: Set card->owner to avoid warnings") Related: commit ec653df2a0cb ("drm/vc4/vc4_hdmi: fill ASoC card owner") Cc: linux-arm-kernel@lists.infradead.org Cc: alsa-devel@alsa-project.org Signed-off-by: Bastian Germann Link: https://lore.kernel.org/r/20210331151843.30583-1-bage@linutronix.de Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/sunxi/sun4i-codec.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c index 9a3cb7704810..16e8f74288a5 100644 --- a/sound/soc/sunxi/sun4i-codec.c +++ b/sound/soc/sunxi/sun4i-codec.c @@ -1235,6 +1235,7 @@ static struct snd_soc_card *sun4i_codec_create_card(struct device *dev) return ERR_PTR(-ENOMEM); card->dev = dev; + card->owner = THIS_MODULE; card->name = "sun4i-codec"; card->dapm_widgets = sun4i_codec_card_dapm_widgets; card->num_dapm_widgets = ARRAY_SIZE(sun4i_codec_card_dapm_widgets); @@ -1267,6 +1268,7 @@ static struct snd_soc_card *sun6i_codec_create_card(struct device *dev) return ERR_PTR(-ENOMEM); card->dev = dev; + card->owner = THIS_MODULE; card->name = "A31 Audio Codec"; card->dapm_widgets = sun6i_codec_card_dapm_widgets; card->num_dapm_widgets = ARRAY_SIZE(sun6i_codec_card_dapm_widgets); @@ -1320,6 +1322,7 @@ static struct snd_soc_card *sun8i_a23_codec_create_card(struct device *dev) return ERR_PTR(-ENOMEM); card->dev = dev; + card->owner = THIS_MODULE; card->name = "A23 Audio Codec"; card->dapm_widgets = sun6i_codec_card_dapm_widgets; card->num_dapm_widgets = ARRAY_SIZE(sun6i_codec_card_dapm_widgets); @@ -1358,6 +1361,7 @@ static struct snd_soc_card *sun8i_h3_codec_create_card(struct device *dev) return ERR_PTR(-ENOMEM); card->dev = dev; + card->owner = THIS_MODULE; card->name = "H3 Audio Codec"; card->dapm_widgets = sun6i_codec_card_dapm_widgets; card->num_dapm_widgets = ARRAY_SIZE(sun6i_codec_card_dapm_widgets); @@ -1396,6 +1400,7 @@ static struct snd_soc_card *sun8i_v3s_codec_create_card(struct device *dev) return ERR_PTR(-ENOMEM); card->dev = dev; + card->owner = THIS_MODULE; card->name = "V3s Audio Codec"; card->dapm_widgets = sun6i_codec_card_dapm_widgets; card->num_dapm_widgets = ARRAY_SIZE(sun6i_codec_card_dapm_widgets); -- 2.30.2