Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932120AbWJNGzz (ORCPT ); Sat, 14 Oct 2006 02:55:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932117AbWJNGzz (ORCPT ); Sat, 14 Oct 2006 02:55:55 -0400 Received: from smtp.osdl.org ([65.172.181.4]:33747 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932121AbWJNGzy (ORCPT ); Sat, 14 Oct 2006 02:55:54 -0400 Date: Fri, 13 Oct 2006 23:55:36 -0700 From: Andrew Morton To: "Michal Piotrowski" Cc: neilb@suse.de, rusty@rustcorp.com.au, LKML , "Thomas Gleixner" Subject: Re: + convert-cpu-hotplug-notifiers-to-use-raw_notifier-instead-of-blocking_notifier.patch added to -mm tree Message-Id: <20061013235536.69d3e098.akpm@osdl.org> In-Reply-To: <6bffcb0e0610131313h2f872cc9uf4dbc3f2b41de3f6@mail.gmail.com> References: <200610130506.k9D56YJY031111@shell0.pdx.osdl.net> <452FAE74.1020500@googlemail.com> <20061013114132.9e5afab9.akpm@osdl.org> <6bffcb0e0610131313h2f872cc9uf4dbc3f2b41de3f6@mail.gmail.com> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1421 Lines: 33 On Fri, 13 Oct 2006 22:13:43 +0200 "Michal Piotrowski" wrote: > On 13/10/06, Andrew Morton wrote: > > On Fri, 13 Oct 2006 17:19:16 +0200 > > Michal Piotrowski wrote: > > > > > There is something really wrong with this patch (or my hardware). > > > > > > echo shutdown > /sys/power/disk; echo disk > /sys/power/state > > > works fine for me on 2.6.19-rc1-g8770c018. > > > > > > On 2.6.19-rc1-mm1 + > > > convert-cpu-hotplug-notifiers-to-use-raw_notifier-instead-of-blocking_notifier.patch > > > + Neil's avoid_lockdep_warning_in_md.patch > > > (http://www.ussg.iu.edu/hypermail/linux/kernel/0610.1/0642.html) > > > I get a lot of "end_request: I/O error, dev sda, sector 31834343" messages. > > > > That's not exactly an expected result. What makes you think it's due to > > this patch? Does 2.6.19-rc1-mm1 run OK? > > Yes. (the only one issue is > http://www.stardust.webpages.pl/files/tbf/euridica/2.6.19-rc1-mm1/mm-dmesg) > > I get many "random" bugs that avoid hibernation with this patch. As predicted, it works for me. In fact it makes a string of nasty SMP-only warnings go away. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/