Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2140624pxb; Mon, 12 Apr 2021 15:49:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwwQttbl+k2hZJQFLxK7fu8+ZSOzLr7plXWGynLlkGoqDtoFe8Sj7rRCNccm9IUxP6+X0Ep X-Received: by 2002:a17:907:d10:: with SMTP id gn16mr28730152ejc.304.1618267782403; Mon, 12 Apr 2021 15:49:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618267782; cv=none; d=google.com; s=arc-20160816; b=w7ICzLlBRie6sROnRsLVDlimafANlPJ/mf8ORO1lSWRT7dD0Jnzh7tm7lXBxabOyRE ev8Wielm8Z/IZkc2dNfSVBB/znqoD27TvCc6U36PqQ5vXRzTRU4vsnXvTCtR0zTl/vdy u1PRpq1eqRbQXF/vC/C886YZ3zHULR/Lo2ndXWqlVpeedp0015glo6Rz1n83M9lnz+qz cIfrELTLdSKBkh+1DNtAEjHEnzfkUze/KLVuDW3L7vDS11T7Rl6eXTKmbYD6vCJowW7+ PdiCTVxUsTGIUwttHIGScc7BMD8sfV2Jp1xP4h7jIFlmo0iTaMJh/JLwadIZ67GQJOtH 2iRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=lMUmHBDLNT/X1VyhNSE4gDXQ91plU4v6q/3SMtvz8qE=; b=LTLDFHiM4yIRnY0D/ynk9C0MUUAr2daVFfcDG22X/npOpp8kxuzF3FqpMNM8IZiX3p /kzr3Rn6jqQxvZ5NrUULDF2fs/+ewjiAPH4sDofAbh5kf2zPy0Qfm9+zjk04vVqB2Q2U 2Q7ZdSglFXJxXJIOOkMFEGWcjklOqO155K2CDDAd4NFwyZaJ8eIY/jW8MeLsHVRx3d/n VqLVeYesoCGasIMqXuA7RlAykrAdj6G/GodfwHw4Tzms/xdGsOnsma43ryEOe4mfkdLl qi+UxrGgVK+IvXYfcWuwUXD/UV1yRSQZOIPPqylXxEfE/zOTxPQNYBLFde37OcbNVEpe 9hLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PUWECMed; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hc43si9483405ejc.387.2021.04.12.15.49.18; Mon, 12 Apr 2021 15:49:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PUWECMed; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243068AbhDLJlQ (ORCPT + 99 others); Mon, 12 Apr 2021 05:41:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:36312 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241003AbhDLJLX (ORCPT ); Mon, 12 Apr 2021 05:11:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7B83E613BD; Mon, 12 Apr 2021 09:07:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618218477; bh=jo2m3C+EsQ9yT7wKAQ5EHGpVTZ9l/erAvTppy1ssWfU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PUWECMedaBiI9f+qDDgzetlwtAmJm4qyIjLjyHeHF37ZMFy3TwQ7V0bzN7/gIbMbh eI6WcjH7EGMUhZbdFix4B65pomWabO38mkAFfSupkXX/NY5s1cFlVmUpwXEBQvjlHq q6EHsK1MZUYiSbzFe6R60PYfcccsX3/LPaghqUFY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+368672e0da240db53b5f@syzkaller.appspotmail.com, Alexander Aring , Stefan Schmidt Subject: [PATCH 5.11 206/210] net: ieee802154: fix nl802154 del llsec devkey Date: Mon, 12 Apr 2021 10:41:51 +0200 Message-Id: <20210412084022.856070210@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210412084016.009884719@linuxfoundation.org> References: <20210412084016.009884719@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexander Aring commit 27c746869e1a135dffc2f2a80715bb7aa00445b4 upstream. This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_DEVKEY is not set by the user. If this is the case nl802154 will return -EINVAL. Reported-by: syzbot+368672e0da240db53b5f@syzkaller.appspotmail.com Signed-off-by: Alexander Aring Link: https://lore.kernel.org/r/20210221174321.14210-4-aahringo@redhat.com Signed-off-by: Stefan Schmidt Signed-off-by: Greg Kroah-Hartman --- net/ieee802154/nl802154.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/net/ieee802154/nl802154.c +++ b/net/ieee802154/nl802154.c @@ -1916,7 +1916,8 @@ static int nl802154_del_llsec_devkey(str struct ieee802154_llsec_device_key key; __le64 extended_addr; - if (nla_parse_nested_deprecated(attrs, NL802154_DEVKEY_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_DEVKEY], nl802154_devkey_policy, info->extack)) + if (!info->attrs[NL802154_ATTR_SEC_DEVKEY] || + nla_parse_nested_deprecated(attrs, NL802154_DEVKEY_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_DEVKEY], nl802154_devkey_policy, info->extack)) return -EINVAL; if (!attrs[NL802154_DEVKEY_ATTR_EXTENDED_ADDR])