Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2161907pxb; Mon, 12 Apr 2021 16:30:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxPugZepoHowIAUdCsKWPQViR7tO61MiBpSjfMkw1hgdfWee4QdXRGh10HJ1BaBBltS2Er/ X-Received: by 2002:a62:19cb:0:b029:245:405b:7f0e with SMTP id 194-20020a6219cb0000b0290245405b7f0emr20249856pfz.24.1618270229995; Mon, 12 Apr 2021 16:30:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618270229; cv=none; d=google.com; s=arc-20160816; b=z/cI8g5zg0zorNziBC0cGWJwJjT2iUx/pM85GDhzPDG63A/QKYotgbcVRMNwtjUb5M me4hWzRLMF+E00++21Ja2DPS7eB+Z3c7A8S9Xz4REMcWAdkUfpDaJe7ovLCY9/1jFv4B bp/cKsNta9gtu62lviX+8a9R/MQiYIhSu1f2S7plomMyEZO8nNMZ0T5fO3YdWzdcouUD qACBCqCDXNWkKc6+SG0av99QIoMYW/7amnXeKvuQvQ/RXkVr+Fzvt8Ytn04ayMFQeqoc zb23Lyp/LxVlNHLxM/Jm7HUfMLk+5aAhz1AVyVLcHa3Pco8bkL7gHdc/f9DWlok69+Ue 97og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=IeSCzkLT2TMeD064rdqHLGZki7q9FiMEKUBGP2lah28=; b=CQuB1GptZ2UvHktDEkmw7MTMeJNVlpTPIfdmQNi2Ck0qXBxr9IfWqqh7ykC7qNAkJS xpUl3ARIexzRDDwJINQro0kGdAy2l+f4jFAK5bsXDqRZhHjh3LxFolA5BZSNxdhWcv6+ cVYO2evt+pqnzZBQ55UHiGVaGORBfBtBHxKHZ7fva1YxIZN+iDRUqOtQeRA0bv0dCY9h 8zBv/SWhNTIpHFlGwc/N84rar5Gj84KF4CMCE7AvjBeAozf7mj87hvfPOsXg45fkXzzT U9Doj7uFCiZhoe3Hlkewu9OKSfw8jmnufdDNxqDpxCGUW3dro09f5PrcU5ztGheieX7j ijHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=aOwrlZyw; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=mFv0Bx9k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i7si16105814pgc.573.2021.04.12.16.30.17; Mon, 12 Apr 2021 16:30:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=aOwrlZyw; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=mFv0Bx9k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239366AbhDLKd6 (ORCPT + 99 others); Mon, 12 Apr 2021 06:33:58 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:38234 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237440AbhDLKd5 (ORCPT ); Mon, 12 Apr 2021 06:33:57 -0400 From: Kurt Kanzenbach DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1618223618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IeSCzkLT2TMeD064rdqHLGZki7q9FiMEKUBGP2lah28=; b=aOwrlZywc/YrJLZK9f5pAK6bVVkEAJbG8rauLdQSUcj94gqe+Ues1bT7vJRElQlm46GKsR e1CLophyGGZOa0Mey7nFRuHGdUTMMzw0WCaRlZQ3IAkbFEjtR0nAnPVhMtTVc6ZqrRpkPH ciAOWatoqHSKfJus4ox0SssJKJ+eTxQHOtS1QdUQkHcewDvdumoYjKYfX/h80g98f6QCtW Tf1+tgL6BixgjIKD+I63qAYKpXF6jPVhCYJ8wN9qTZ2pnEuJ95+FY41uZAaFc3mC/FJkPn o/QDPdzIPWgL7uBsEdjYBL76cMtZZA/V5CRa4DaEeXnsOncCelP6Z0pFTMXIfQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1618223618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IeSCzkLT2TMeD064rdqHLGZki7q9FiMEKUBGP2lah28=; b=mFv0Bx9kAqb1f/heYquuq0cHNEKj9RxAiMiSk+K6nqcFWebS/8czH/Rp4qoCb6tCF46Lf/ 43lpqtFX4DniNNCw== To: DENG Qingfang , "David S. Miller" , Andrew Lunn , Florian Fainelli , Heiner Kallweit , Jakub Kicinski , Landen Chao , Matthias Brugger , Russell King , Sean Wang , Vivien Didelot , Vladimir Oltean , Rob Herring , Linus Walleij , Greg Kroah-Hartman , Sergio Paracuellos , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-staging@lists.linux.dev, devicetree@vger.kernel.org, netdev@vger.kernel.org Cc: Weijie Gao , Chuanhong Guo , =?utf-8?Q?Ren=C3=A9?= van Dorst , Frank Wunderlich , Thomas Gleixner , Marc Zyngier Subject: Re: [RFC v4 net-next 3/4] dt-bindings: net: dsa: add MT7530 interrupt controller binding In-Reply-To: <20210412034237.2473017-4-dqfext@gmail.com> References: <20210412034237.2473017-1-dqfext@gmail.com> <20210412034237.2473017-4-dqfext@gmail.com> Date: Mon, 12 Apr 2021 12:33:36 +0200 Message-ID: <8735vv6bcv.fsf@kurt> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Mon Apr 12 2021, DENG Qingfang wrote: > Add device tree binding to support MT7530 interrupt controller. > > Signed-off-by: DENG Qingfang > Reviewed-by: Andrew Lunn > --- > RFC v3 -> RFC v4: > - Add #interrupt-cells property. > > Documentation/devicetree/bindings/net/dsa/mt7530.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/mt7530.txt b/Docum= entation/devicetree/bindings/net/dsa/mt7530.txt > index de04626a8e9d..892b1570c496 100644 > --- a/Documentation/devicetree/bindings/net/dsa/mt7530.txt > +++ b/Documentation/devicetree/bindings/net/dsa/mt7530.txt > @@ -81,6 +81,12 @@ Optional properties: > - gpio-controller: Boolean; if defined, MT7530's LED controller will run= on > GPIO mode. > - #gpio-cells: Must be 2 if gpio-controller is defined. > +- interrupt-controller: Boolean; Enables the internal interrupt controll= er. > + > +If interrupt-controller is defined, the following property is required. > + > +- #interrupt-cells: Must be 1. > +- interrupts: Parent interrupt for the interrupt controller. >=20=20 > See Documentation/devicetree/bindings/net/dsa/dsa.txt for a list of addi= tional That dsa.txt still exists, but it refers to the dsa.yaml binding. Any chance to convert this mt7530.txt to yaml as well? Then, device trees can be automatically validated for correct entries. There are a few examples of dsa yaml bindings already: ksz, b53, sf2, hellcreek, ... Thanks, Kurt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEooWgvezyxHPhdEojeSpbgcuY8KYFAmB0IgAACgkQeSpbgcuY 8Kb6eg/9FdeRCvEbOTCVRDtl5lsVRik6QqjbYTaQLNrkEUmOA9SrkbQ63yxhPF2i j7heR52USECwZDmiUG+P7CIlk9EIZhsgy4xQngJe8BvAa+Xai4Rybrn/0QIGv8Mp vlljoycO8z16JNQ4BV7ySXGb901RZFHEDH4MovM30fXwjWLgkV0nwzl87Wj9uisr jXob9CTbvf7h/+kdAfP3zm1vAscwLqS+JopIbp0qkUd+1B93LZ0E6hyzMTD0/IWp S3XQNRMOWeHOksTxmZAUvtVB+g2HeQZ4s0sXzPJjlJ2e4XSKQephjd1kjFxQcyJc Bw14tdWW3OdP6B2lai48RsswjximG50FQHLyUMtAJiiu0S96gC+OEbQY/tPB58K3 KgmW3RCCGvefVtx+OcOiLVYUerGrdHNhteFtrNHxBL63OH1T0/UEfCnyeEq5GcXV LtfRbSJk2LoipSbyyqqbMptBXd5I5W8Ae5iNQ9eOmkZoG3Jmujh76mJAqV2CeIJd Rn3PKti1JwpI036y5s048CZoUd7ptSn3T2DoHTuuVuTGbvVVU8HaY/NJMMaU8CYI 1+hluj/sJM9chjGwE270w8pgh8tQV5xnpzLDD54PcaWRiynfS7V2WMCnwdwMSNdT mz2F2GXEDDrlTaao5T4SpzvmDad9IdL0vLcR+nnH2ji3zoPzMKo= =+a88 -----END PGP SIGNATURE----- --=-=-=--