Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2206507pxb; Mon, 12 Apr 2021 17:58:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwLw3ACs1KHh4OJMEdEi8CDGu2Ru6bsiUJxWYkZfiRl1oAhUA6WySP0VLNmdSA23gPV0gBF X-Received: by 2002:a50:9fa1:: with SMTP id c30mr23314591edf.66.1618275493350; Mon, 12 Apr 2021 17:58:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618275493; cv=none; d=google.com; s=arc-20160816; b=dPd4k+KJ2fec/1xQ9d2UL5wENZFRDynyR6z+UlI8NapV4Kk/pwbkHZMmwbz6u/3RB5 YmbCWjKcb+92DvyiD3ZXzCirHOlUaEcfd6qdyRvzSVPaN/A64GqGROw30tgQdj6/ZAfy Lf4ryR/zX0bpTE4dA7LbMAdD3QKdAfOVHVi2UdMio1i9JCZiUlzD3phtwYAwB6dJn1WC fafqmBIJASyxQ6qrZj8/oiQ10gSHcyacykYhil/sEiPuumceu8BiDZLs1khPxLPwINUG JJlypl+PjCioYhI2QaSCDGXOAcnzY9V6msfrpdK/Toj4BzPbdyECKuja0S+3pAOR4DZL ADAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=aYRFAxqCx4//Sjal2romPPEveZaYztcLetCEKx85RQE=; b=VnGDtJNHbe+MWkXrTR4HtDNG2nuok0gzTo5XlzmCtNFJcmxmmXI3u6r5+Rtc0Xclsi YPZFfCtMj2I1yEJXiVSdF7Lm89MvPD72NxWWK3RUjjgs4oI9YN9gq6s1NgR9fBp/OPnf qPAJoEqjluLby6ITnyPswvW34dHMkQ9db2v5vwsC8QTP195ttqkHHWSwKeyS2k2aa4mA d50G9bbPGoCEAFNbDzLO5PN2Mybs2OAOH1RRqepeCEQ0ojvp/ne1ny1uGjxg8FtOQ3fQ iiMlquXGBBpaMjimOsQ5u5sIltulLo7nKB5iX0C+F4aTEh0jOBE9lLXLVfCrHlssSEC6 BT5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m26si8990963edp.104.2021.04.12.17.57.50; Mon, 12 Apr 2021 17:58:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240016AbhDLL2s (ORCPT + 99 others); Mon, 12 Apr 2021 07:28:48 -0400 Received: from gecko.sbs.de ([194.138.37.40]:59782 "EHLO gecko.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237626AbhDLL2s (ORCPT ); Mon, 12 Apr 2021 07:28:48 -0400 Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 13CBS1CZ003961 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Apr 2021 13:28:01 +0200 Received: from md1za8fc.ad001.siemens.net ([139.22.41.180]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 13CBRxfo010289; Mon, 12 Apr 2021 13:27:59 +0200 Date: Mon, 12 Apr 2021 13:27:58 +0200 From: Henning Schild To: Hans de Goede Cc: linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-watchdog@vger.kernel.org, Srikanth Krishnakar , Jan Kiszka , Gerd Haeussler , Guenter Roeck , Wim Van Sebroeck , Mark Gross , Pavel Machek , Andy Shevchenko , Enrico Weigelt Subject: Re: [PATCH v3 0/4] add device drivers for Siemens Industrial PCs Message-ID: <20210412132758.58cf851c@md1za8fc.ad001.siemens.net> In-Reply-To: <857d6cd4-839d-c42a-0aa7-8d45243981ee@redhat.com> References: <20210329174928.18816-1-henning.schild@siemens.com> <857d6cd4-839d-c42a-0aa7-8d45243981ee@redhat.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Wed, 7 Apr 2021 13:36:40 +0200 schrieb Hans de Goede : > Hi, > > On 3/29/21 7:49 PM, Henning Schild wrote: > > changes since v2: > > > > - remove "simatic-ipc" prefix from LED names > > - fix style issues found in v2, mainly LED driver > > - fix OEM specific dmi code, and remove magic numbers > > - more "simatic_ipc" name prefixing > > - improved pmc quirk code using callbacks > > > > changes since v1: > > > > - fixed lots of style issues found in v1 > > - (debug) printing > > - header ordering > > - fixed license issues GPLv2 and SPDX in all files > > - module_platform_driver instead of __init __exit > > - wdt simplifications cleanup > > - lots of fixes in wdt driver, all that was found in v1 > > - fixed dmi length in dmi helper > > - changed LED names to allowed ones > > - move led driver to simple/ > > - switched pmc_atom to dmi callback with global variable > > > > -- > > > > This series adds support for watchdogs and leds of several x86 > > devices from Siemens. > > > > It is structured with a platform driver that mainly does > > identification of the machines. It might trigger loading of the > > actual device drivers by attaching devices to the platform bus. > > > > The identification is vendor specific, parsing a special binary DMI > > entry. The implementation of that platform identification is > > applied on pmc_atom clock quirks in the final patch. > > > > It is all structured in a way that we can easily add more devices > > and more platform drivers later. Internally we have some more code > > for hardware monitoring, more leds, watchdogs etc. This will follow > > some day. > > IT seems there still is significant discussion surrounding the LED > and watchdog drivers which use patch 1/4 as parent-driver. > > I'm going to hold of on merging 1/4 and 4/4 until there is more > consensus surrounding this series. Yes. Whithout 2 and 3, 1 would be way too big. Henning > Regards, > > Hans > > > > > > Henning Schild (4): > > platform/x86: simatic-ipc: add main driver for Siemens devices > > leds: simatic-ipc-leds: add new driver for Siemens Industial PCs > > watchdog: simatic-ipc-wdt: add new driver for Siemens Industrial > > PCs platform/x86: pmc_atom: improve critclk_systems matching for > > Siemens PCs > > > > drivers/leds/Kconfig | 3 + > > drivers/leds/Makefile | 3 + > > drivers/leds/simple/Kconfig | 11 + > > drivers/leds/simple/Makefile | 2 + > > drivers/leds/simple/simatic-ipc-leds.c | 202 > > ++++++++++++++++ drivers/platform/x86/Kconfig | > > 12 + drivers/platform/x86/Makefile | 3 + > > drivers/platform/x86/pmc_atom.c | 57 +++-- > > drivers/platform/x86/simatic-ipc.c | 169 ++++++++++++++ > > drivers/watchdog/Kconfig | 11 + > > drivers/watchdog/Makefile | 1 + > > drivers/watchdog/simatic-ipc-wdt.c | 215 > > ++++++++++++++++++ .../platform_data/x86/simatic-ipc-base.h | > > 29 +++ include/linux/platform_data/x86/simatic-ipc.h | 72 ++++++ > > 14 files changed, 769 insertions(+), 21 deletions(-) > > create mode 100644 drivers/leds/simple/Kconfig > > create mode 100644 drivers/leds/simple/Makefile > > create mode 100644 drivers/leds/simple/simatic-ipc-leds.c > > create mode 100644 drivers/platform/x86/simatic-ipc.c > > create mode 100644 drivers/watchdog/simatic-ipc-wdt.c > > create mode 100644 > > include/linux/platform_data/x86/simatic-ipc-base.h create mode > > 100644 include/linux/platform_data/x86/simatic-ipc.h >