Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2269465pxb; Mon, 12 Apr 2021 20:14:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzn7zyfc7AEld8m7eBYJfDA3AzETtM3FmjMYyrjp9C7fFdkg/2SeeRiGewvlZn0eW/yhgRT X-Received: by 2002:a17:906:7016:: with SMTP id n22mr20446561ejj.23.1618283640060; Mon, 12 Apr 2021 20:14:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618283640; cv=none; d=google.com; s=arc-20160816; b=pcOznOM6eJ/mU+/n54UDojlOaypL8yN9ejEaQ71QDif3dWqDuYovaxz1jZW1usvX2s ud3ZxqHSBVdVVXmzZbF9Cl2eJHru9UtD0iLB8FQiEd2Z5KuwwCkHS/PjrevkbO/3nuaQ Qw6TmogP3I4u1P4kyCEA5nt6/kO5mzVqXDBhRBa0amIfO1o5cboRRqIxhyY6uuEi9MFA 46BlwIUuKmyjrizZwB+3W2MGMuQQBw7J+Cu8ReGXD3h1yxhAcpVqcYVQ9RY3GYdANSwQ D8LIq0rMiaab3fKnAzyrnZ73WdKa44L+9xwQakqvpf56II2TMhqNuXvy5aKl4/TdGCwE qLWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=HFLBwpH7bnJqRpBXV3LZM+eIf2wqGdsU526G+Z9OgrU=; b=qTTYQmBUJl9Gns4I7yIu4+/QCf2KNeed2Sj1A+I4pv3fd2RMGzpZUSFNz7vKLqnLLJ aoWc5efJ1ULqw7pirjvUpT8Am+OGrZZq8mT/XWuQ4ZyNN7Tm8VuoqnfLTX7b2n6vOwp6 NUf5m/XIAP49UiqBWLGYCrbpsve7MjCygjo7wJAnbwaNZoo3Tpjt2PHXH+GXuGSrLlwk ngye6+9kzkXoiy4msPfFW6RIWeBMqPOr21RshX1rJpMOZkmML6TntLA4yx3CD1AydVmf iyPLrEvFtoibspEOHQp4IjKqvQFHEmEwuHXHQ7A8ywQxCTiFQW1sW6EI0CT7adVmFAtE neqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=XYLX8Shi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id af16si9181318ejc.294.2021.04.12.20.13.33; Mon, 12 Apr 2021 20:14:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=XYLX8Shi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241739AbhDLNg6 (ORCPT + 99 others); Mon, 12 Apr 2021 09:36:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239992AbhDLNg6 (ORCPT ); Mon, 12 Apr 2021 09:36:58 -0400 Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C906CC061574; Mon, 12 Apr 2021 06:36:38 -0700 (PDT) Received: by mail-qv1-xf2b.google.com with SMTP id i3so685728qvj.7; Mon, 12 Apr 2021 06:36:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=HFLBwpH7bnJqRpBXV3LZM+eIf2wqGdsU526G+Z9OgrU=; b=XYLX8Shi4RLk9DI1jD3w47/7MIzpiCqHhzNKrsRsHFhrOJUs5vRtrHUcsOdB62p685 71OM0XXU3JHwK6+0c6TP0I7twL1HiKLVTPK0mx+vJgq4K1P2urXIy7l+26wPMzIbZJgQ lNiCD7jlSiPq5AFhqgiXAzIzNaN7zYyNXsYI1dg7o8EP0hLNFwxTyUVrK1M34G9IiiXU wiS14CpnmH88v0InxYj9Vg6Fy3wEOqXj2qeb5vPpE1m+XIO4o4NBMlxaJq4uUccjWOfW Xe89ZEZ4gqLuGtU/7R3cvyTq1GTinSjYfX37pje+XWF3KRDp2HZGFN5bZvizL2Yxu/YL F/JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=HFLBwpH7bnJqRpBXV3LZM+eIf2wqGdsU526G+Z9OgrU=; b=eSgxEPjI7jh6By3y5EAfrTEDjZORlhU5nioKoB2J4cugNeK0OG196Bw4B4wd8UwZDw C5uCuOADEqjck85i1L/O/XwVs1uQJ6qokdBsJqswBlZ9sF1m+EgVPo2qQDys8sueigB9 9Q56R34jaiDyUUORMBxZQrRWsjeqv9+mFjDpo/H/ZAMGx4PqWB4h3iUPsQBcboIMhyvu zITXcl+LjALGQm3WZjopuBI72Bt0aTvW3RuYSSj+DRlI/LPTOScNQNys4GCK0ylzod6X G0Lv5ii4Nm4isys1N+KhugGsLx+haz9abg2rvMg+Q0iSVGQvDo7WSShGkUq+w2NHMykF QXyQ== X-Gm-Message-State: AOAM5329Y/0EvfQvVGe8mgHQuukD3BOTHsb6Wq7GUGW+zNKSlOiqpjgd vqt0qr1vlKuW3KW9cxESMq8= X-Received: by 2002:a0c:fc46:: with SMTP id w6mr9852472qvp.0.1618234597739; Mon, 12 Apr 2021 06:36:37 -0700 (PDT) Received: from focaruja ([2001:1284:f016:a037:476a:dfcd:f18f:9ad5]) by smtp.gmail.com with ESMTPSA id b15sm3419566qtg.82.2021.04.12.06.36.36 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Mon, 12 Apr 2021 06:36:37 -0700 (PDT) Date: Mon, 12 Apr 2021 10:36:34 -0300 From: Aline Santana Cordeiro To: Laurent Pinchart , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: [PATCH] staging: media: omap4iss: Replace macro function by static inline function in file iss_csi2.c Message-ID: <20210412133634.GA1791@focaruja> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replace macro function by static inline function. Issue suggested by Julia. Signed-off-by: Aline Santana Cordeiro --- drivers/staging/media/omap4iss/iss_csi2.c | 49 ++++++++++++++++--------------- 1 file changed, 26 insertions(+), 23 deletions(-) diff --git a/drivers/staging/media/omap4iss/iss_csi2.c b/drivers/staging/media/omap4iss/iss_csi2.c index a6dc2d2..cbeba44 100644 --- a/drivers/staging/media/omap4iss/iss_csi2.c +++ b/drivers/staging/media/omap4iss/iss_csi2.c @@ -597,9 +597,12 @@ static int csi2_configure(struct iss_csi2_device *csi2) /* * csi2_print_status - Prints CSI2 debug information. */ -#define CSI2_PRINT_REGISTER(iss, regs, name)\ - dev_dbg(iss->dev, "###CSI2 " #name "=0x%08x\n", \ - iss_reg_read(iss, regs, CSI2_##name)) +static inline csi2_print_register(iss, regs, name) +{ + dev_dbg(iss->dev, "###CSI2 " #name "=0x%08x\n", + iss_reg_read(iss, regs, CSI2_##name)); +} + static void csi2_print_status(struct iss_csi2_device *csi2) { @@ -610,26 +613,26 @@ static void csi2_print_status(struct iss_csi2_device *csi2) dev_dbg(iss->dev, "-------------CSI2 Register dump-------------\n"); - CSI2_PRINT_REGISTER(iss, csi2->regs1, SYSCONFIG); - CSI2_PRINT_REGISTER(iss, csi2->regs1, SYSSTATUS); - CSI2_PRINT_REGISTER(iss, csi2->regs1, IRQENABLE); - CSI2_PRINT_REGISTER(iss, csi2->regs1, IRQSTATUS); - CSI2_PRINT_REGISTER(iss, csi2->regs1, CTRL); - CSI2_PRINT_REGISTER(iss, csi2->regs1, DBG_H); - CSI2_PRINT_REGISTER(iss, csi2->regs1, COMPLEXIO_CFG); - CSI2_PRINT_REGISTER(iss, csi2->regs1, COMPLEXIO_IRQSTATUS); - CSI2_PRINT_REGISTER(iss, csi2->regs1, SHORT_PACKET); - CSI2_PRINT_REGISTER(iss, csi2->regs1, COMPLEXIO_IRQENABLE); - CSI2_PRINT_REGISTER(iss, csi2->regs1, DBG_P); - CSI2_PRINT_REGISTER(iss, csi2->regs1, TIMING); - CSI2_PRINT_REGISTER(iss, csi2->regs1, CTX_CTRL1(0)); - CSI2_PRINT_REGISTER(iss, csi2->regs1, CTX_CTRL2(0)); - CSI2_PRINT_REGISTER(iss, csi2->regs1, CTX_DAT_OFST(0)); - CSI2_PRINT_REGISTER(iss, csi2->regs1, CTX_PING_ADDR(0)); - CSI2_PRINT_REGISTER(iss, csi2->regs1, CTX_PONG_ADDR(0)); - CSI2_PRINT_REGISTER(iss, csi2->regs1, CTX_IRQENABLE(0)); - CSI2_PRINT_REGISTER(iss, csi2->regs1, CTX_IRQSTATUS(0)); - CSI2_PRINT_REGISTER(iss, csi2->regs1, CTX_CTRL3(0)); + csi2_print_register(iss, csi2->regs1, SYSCONFIG); + csi2_print_register(iss, csi2->regs1, SYSSTATUS); + csi2_print_register(iss, csi2->regs1, IRQENABLE); + csi2_print_register(iss, csi2->regs1, IRQSTATUS); + csi2_print_register(iss, csi2->regs1, CTRL); + csi2_print_register(iss, csi2->regs1, DBG_H); + csi2_print_register(iss, csi2->regs1, COMPLEXIO_CFG); + csi2_print_register(iss, csi2->regs1, COMPLEXIO_IRQSTATUS); + csi2_print_register(iss, csi2->regs1, SHORT_PACKET); + csi2_print_register(iss, csi2->regs1, COMPLEXIO_IRQENABLE); + csi2_print_register(iss, csi2->regs1, DBG_P); + csi2_print_register(iss, csi2->regs1, TIMING); + csi2_print_register(iss, csi2->regs1, CTX_CTRL1(0)); + csi2_print_register(iss, csi2->regs1, CTX_CTRL2(0)); + csi2_print_register(iss, csi2->regs1, CTX_DAT_OFST(0)); + csi2_print_register(iss, csi2->regs1, CTX_PING_ADDR(0)); + csi2_print_register(iss, csi2->regs1, CTX_PONG_ADDR(0)); + csi2_print_register(iss, csi2->regs1, CTX_IRQENABLE(0)); + csi2_print_register(iss, csi2->regs1, CTX_IRQSTATUS(0)); + csi2_print_register(iss, csi2->regs1, CTX_CTRL3(0)); dev_dbg(iss->dev, "--------------------------------------------\n"); } -- 2.7.4