Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2279999pxb; Mon, 12 Apr 2021 20:36:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/wn7054q7VrmJxUh4f6NUtYHTsTzuTz2bw3mBQkDzbEzimBaQ94A7NVa6HHEqbk7mtxQc X-Received: by 2002:a17:906:5fce:: with SMTP id k14mr15074050ejv.9.1618285018097; Mon, 12 Apr 2021 20:36:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618285018; cv=none; d=google.com; s=arc-20160816; b=xmc351Nfkc4AMfs40oHECN0ePSpbCfnJ2wG6aU2k8OWRGS7xYW1Q7irxiOBT4xGdnQ NvesMRqfXJR6v4OPSAMOJd8G3YapyWIeEwZOAw94FYsk5UefQiFzjFserq92QIabNJRl df73Xl6KJ3L1jhphCqumR/HDAegv/3je37dwC6uYspLH0i4JP1+XmG1dWDXOv9bVa6HP 6Wfsh2+kmx7kVDXm5OrnCbTOZfoQHe8HTjiiq4vUeIVVqAWe6/NRdeD43kNQXI2Yx7Eo uX6Y51z1vq8N05X3wQQxQ99OQKGIHXXHrmVL2TiTVAKZfDXGXiYv1iTdfD0jf3fRZ70R 8hOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ghtUNvP6W4rUDXB8GC3MxVGM3FS9B5+TJ3i4rt5aKc8=; b=hOmwzch2SAR7tzMI5o4x/d/h4w9vrmdJLQwx0dj1e29bTDfgs0R07BFnSk5hNdWLJG c96OS63HAc0RsT3bByGKqvf5+ZRpUjHYOmBedC2M2iMbptMVOXNsb6GMDFihUgmai3Iz RdQlBumTg/5gTDGSIsphFXNuKPTSYeE+Gx8PVMrmbVpNZEFe2bqqHBAZ0IACkPKxuHFd xgH7bpWcfaGLjuCeMCw4FS4pYOhR8bZhNI+cqvyJXAzI6U4nCIzBc4rHVpOaV5BUxY12 87sgqGg0HvSYmW4K/mBWSLMBTPdhthMND2mQBRvR/pEJr4Cmxu8HfoVAjaM9hach+6NO CygQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=JYBZ+xuO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k19si9113119eds.343.2021.04.12.20.36.35; Mon, 12 Apr 2021 20:36:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=JYBZ+xuO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242653AbhDLPNK (ORCPT + 99 others); Mon, 12 Apr 2021 11:13:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242495AbhDLPNI (ORCPT ); Mon, 12 Apr 2021 11:13:08 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6D81C061574; Mon, 12 Apr 2021 08:12:50 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 67B923F0; Mon, 12 Apr 2021 17:12:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1618240367; bh=Vz+OMcuaVIUWh/1V5VDfgCmz0MaadcYAni8v3UeFzEc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JYBZ+xuOtRSZiVxFnDNer1U5JH1VoI2j3hrHgR3tSGsE8T2LCGLtA/ItGDhhig7/6 IV3PuSJuBTmY7hOqGK3pTsOYaJitbvRoB+W7Z9JQvYsd3vh84rltHc0yOEhyKWboIQ iR/lYBOkwE8QUuvDHDznHxbLb2j9e95K/syDs0sw= Date: Mon, 12 Apr 2021 18:11:58 +0300 From: Laurent Pinchart To: ascordeiro Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel][PATCH 1/4 v2] staging: media: omap4iss: Replace macro function by static inline function in file iss.c Message-ID: References: <7457fd4eb5afbf66b3a6f2fed4dd1e440e6ed422.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7457fd4eb5afbf66b3a6f2fed4dd1e440e6ed422.camel@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Aline, On Mon, Apr 12, 2021 at 10:58:45AM -0300, ascordeiro wrote: > Em seg, 2021-04-12 às 16:40 +0300, Laurent Pinchart escreveu: > > While testing on a device isn't a requirement as you can't be expected > > to have the necessary hardware, changes are expected to be at least > > compile-tested before being submitted. > > Hi Laurent, > > I thought recompiling the kernel would be enough in this case. > I recompiled it in native Ubuntu 16.04 without errors. Did it compile the driver you modified ? -- Regards, Laurent Pinchart