Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2381748pxb; Tue, 13 Apr 2021 00:00:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwk7MUY2Rr1U1j2fJOjCom4chL2zW4zuFEIGmDW2Mb8VXoHX0LPQ/9KPADtqvMT0gxCBVQV X-Received: by 2002:a17:90b:344e:: with SMTP id lj14mr3322378pjb.89.1618297236037; Tue, 13 Apr 2021 00:00:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618297236; cv=none; d=google.com; s=arc-20160816; b=pt+rMXtDQzo1Di3XjnarHVEdIILvRRikowdW3m5a7eubHdadWshm6moPhYteCBB8MS JzFz6VThrwfCVSoEP+9tFhrFliW3GeFqw4JimIaxcKufPuypWTeTBl2sq5Riu1VEB470 OaV4iNAKhY21KQMLqYIBNNVt/9SQTKoi7jwswxJRBK+FzqMtleIaXO4u0oB+nZi6N8fP bkwDNSipC3YxAyq00icNd1kOIl7AZcCeLvqV/g+MxTuCWFBenkXLiO0QepzQi1sXUm0c qFG/xHJ4QG5Qu9YhGQ73CjQ1423Zg0lu5NMQEwiaqYvyESAxWQjkZSCMIrSS7NJag62L +9eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=WVDXmeX52NfVN0DmkVlJtvmcxR3Npy2o/kss1K8CAaU=; b=l4FiQyXu0KiS/JO1I/iG6PgdhQ/kD5lKQNqXFXXmYy0tQkOwvy6Nytr08VZKdnDQk/ y1fDjwgpC1AevGyamU2LEc1ue5uGr+elUMOqyFsXFYWmLtHl/leAdQGwKSpAVk43mMZd 3Yj5NkaM9/2pjmmqvx/bxFXaa0k12chcGKbpkFkXvrEObB+5jZvKqqDJPGRPvaTF4XDG FLXACF73VpGfrmhSgrExT/v3CAT5ZdmEvpi/M004+sxMpVE05A0nK/ODVSmQz4c7y9e7 s1ymJBjt58pP6L5kFJ4n1zNSuwMsI3ysX2jX8SrjahWxQF6zOmCUoYVHl6x85ec8qHR5 aiWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VM5OO7HG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t9si16700056plg.79.2021.04.13.00.00.24; Tue, 13 Apr 2021 00:00:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VM5OO7HG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237373AbhDLUDI (ORCPT + 99 others); Mon, 12 Apr 2021 16:03:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236520AbhDLUDH (ORCPT ); Mon, 12 Apr 2021 16:03:07 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13A0AC061574 for ; Mon, 12 Apr 2021 13:02:49 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id n38so9911380pfv.2 for ; Mon, 12 Apr 2021 13:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WVDXmeX52NfVN0DmkVlJtvmcxR3Npy2o/kss1K8CAaU=; b=VM5OO7HGLu6YFlVH4dlpvNPofEOfL9YasDMNEwSlAGZZT7jxKthbkCcEQIC5gNzULh aY9OuADEmOlDvM/9f7+Uk1ln8J02NJFqoVJ/ahaNWe7/YGpL1y1pc0qonBrflIq+0Lbt ZMwCXMbUa50IQF78qjUP1MrxgtbHXUErSXc6OhIp0LB6I7LqTfn27vD93uto3VXaj4BR NBiSmvjfJFGs66t2mXNlj25BtVKKfIQlcSJgVujI188ttZFIcQtHfUHxm6jFDT4RhAhL 0xxH9gsTvRGcYvwR85p0aEyhkryrAF3kWPzkuJ8AVNgaxLADfM50PJcUW4A/6JGoqEp+ z+Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WVDXmeX52NfVN0DmkVlJtvmcxR3Npy2o/kss1K8CAaU=; b=dOJ3CmNXKIxD4PnnBfkp1i1pIHbDGmsJlOlHLahNRC7HBvp4D4c757/oh9zqXl+Acc m/QDl+7i0JmE821jlscc8zfbhONTik8lRgcRGwpUlRCqB/UuKI078cYfShjJbKp/0cEo 4JYlF9Qyq9HSRa7oVWrgNWudtWCnoAxnf0l3DfKJQdEDjAdXG0ZTbO2ys/hKSRVgxyDC YqS0j7kWQx3M3MbVgiKt/4rDcpgbIz7aigPKsUB/zYw1X0p1ErvaRMLtj6EsbSMK6XCz 9AKd7B7Sej8PSWICh6PlvebdOutcZ9oALI8jyWdNLo49EquQY8R3Clta37QmErQRn7Bz RpUA== X-Gm-Message-State: AOAM530sjTgSFybcMkCZs2aJxklfmXpMfdizWCrYyIT/op2WSnQ1CibY WEp80owZZU9PX60iXCyTGlAmsQ== X-Received: by 2002:a63:f926:: with SMTP id h38mr29530934pgi.257.1618257768578; Mon, 12 Apr 2021 13:02:48 -0700 (PDT) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id v123sm10493376pfb.80.2021.04.12.13.02.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Apr 2021 13:02:48 -0700 (PDT) Date: Mon, 12 Apr 2021 14:02:45 -0600 From: Mathieu Poirier To: Arnaud Pouliquen Cc: Bjorn Andersson , Ohad Ben-Cohen , Andy Gross , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 0/7] Restructure the rpmsg char and introduce the rpmsg-raw channel Message-ID: <20210412200245.GB582352@xps15> References: <20210323122737.23035-1-arnaud.pouliquen@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210323122737.23035-1-arnaud.pouliquen@foss.st.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 23, 2021 at 01:27:30PM +0100, Arnaud Pouliquen wrote: > This series is the second step in the division of the series [1]: > "Introducing a Generic IOCTL Interface for RPMsg Channel Management". > > The purpose of this patchset is to: > - split the control code related to the control > and the endpoint. > - define the rpmsg-raw channel, associated with the rpmsg char device to > allow it to be instantiated using a name service announcement. > > An important point to keep in mind for this patchset is that the concept of > channel is associated with a default endpoint. To facilitate communication > with the remote side, this default endpoint must have a fixed address. > > Consequently, for this series, I made a design choice to fix the endpoint > on the "rpmsg-raw" channel probe, and not allow to create/destroy an endpoint > on FS open/close. > > This is only applicable for channels probed by the rpmsg bus. The behavior, > using the RPMSG_CREATE_EPT_IOCTL and RPMSG_DESTROY_EPT_IOCTL controls, is > preserved. > > The next steps should be to correct this: > Introduce the IOCTLs RPMSG_CREATE_DEV_IOCTL and RPMSG_DESTROY_DEV_IOCTL > to instantiate the rpmsg devices > > [1]: https://patchwork.kernel.org/project/linux-remoteproc/list/?series=435523 > > Arnaud Pouliquen (7): > rpmsg: char: Export eptdev create an destroy functions > rpmsg: Move the rpmsg control device from rpmsg_char to rpmsg_ctrl > rpmsg: Update rpmsg_chrdev_register_device function > rpmsg: char: Introduce __rpmsg_chrdev_create_eptdev function > rpmsg: char: Introduce a rpmsg driver for the rpmsg char device > rpmsg: char: No dynamic endpoint management for the default one > rpmsg: char: Return error if user try to destroy a default endpoint. > I am done reviewing this set. Thanks, Mathieu > drivers/rpmsg/Kconfig | 9 ++ > drivers/rpmsg/Makefile | 1 + > drivers/rpmsg/qcom_glink_native.c | 2 +- > drivers/rpmsg/qcom_smd.c | 2 +- > drivers/rpmsg/rpmsg_char.c | 221 +++++++++------------------- > drivers/rpmsg/rpmsg_char.h | 50 +++++++ > drivers/rpmsg/rpmsg_ctrl.c | 233 ++++++++++++++++++++++++++++++ > drivers/rpmsg/rpmsg_internal.h | 8 +- > drivers/rpmsg/virtio_rpmsg_bus.c | 2 +- > 9 files changed, 368 insertions(+), 160 deletions(-) > create mode 100644 drivers/rpmsg/rpmsg_char.h > create mode 100644 drivers/rpmsg/rpmsg_ctrl.c > > -- > 2.17.1 >