Subject: Re: [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti()
	removal
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Amol Lad <amol@verismonetworks.com>
Cc: linux kernel <linux-kernel@vger.kernel.org>,
       kernel Janitors <kernel-janitors@lists.osdl.org>
In-Reply-To: <1160811574.19143.391.camel@amol.verismonetworks.com>
References: <1160739628.19143.376.camel@amol.verismonetworks.com>
	 <1160751657.25218.47.camel@localhost.localdomain>
	 <1160811574.19143.391.camel@amol.verismonetworks.com>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Date: Sat, 14 Oct 2006 13:18:12 +0100
Message-Id: <1160828292.5732.2.camel@localhost.localdomain>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 860
Lines: 22

Ar Sad, 2006-10-14 am 13:09 +0530, ysgrifennodd Amol Lad:
> On Fri, 2006-10-13 at 16:00 +0100, Alan Cox wrote:
> > Ar Gwe, 2006-10-13 am 17:10 +0530, ysgrifennodd Amol Lad:
> > > Removed save_flags()/cli()/sti() and used (light weight) spin locks
> > > 
> > 
> > Have you tested this and verified there are no recursive locking cases
> > in your changes ?
> 
> I doxygend riscom8.c and used call graphs to verify there are no
> recursive locks. I did a code review also

Thanks for the info. I'll give the code a second review (also not having
hardware) and then send you/Andrew either an Ack or corrections.

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/