Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932227AbWJNMQN (ORCPT ); Sat, 14 Oct 2006 08:16:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932228AbWJNMQM (ORCPT ); Sat, 14 Oct 2006 08:16:12 -0400 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:2834 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S932227AbWJNMQL (ORCPT ); Sat, 14 Oct 2006 08:16:11 -0400 Date: Sat, 14 Oct 2006 14:16:08 +0200 From: Adrian Bunk To: mchehab@infradead.org Cc: linux-kernel@vger.kernel.org, linux-dvb-maintainer@linuxtv.org, Michael Krufky Subject: Re: [PATCH 08/18] V4L/DVB (4734): Tda826x: fix frontend selection for dvb_attach Message-ID: <20061014121608.GN30596@stusta.de> References: <20061014115356.PS36551000000@infradead.org> <20061014120050.PS78628900008@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061014120050.PS78628900008@infradead.org> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2059 Lines: 56 On Sat, Oct 14, 2006 at 09:00:50AM -0300, mchehab@infradead.org wrote: > > From: Michael Krufky > > Signed-off-by: Michael Krufky > Signed-off-by: Mauro Carvalho Chehab > --- > > drivers/media/dvb/frontends/tda826x.h | 19 ++++++++++++++++--- > 1 files changed, 16 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/dvb/frontends/tda826x.h b/drivers/media/dvb/frontends/tda826x.h > index 3307607..83998c0 100644 > --- a/drivers/media/dvb/frontends/tda826x.h > +++ b/drivers/media/dvb/frontends/tda826x.h > @@ -35,6 +35,19 @@ #include "dvb_frontend.h" > * @param has_loopthrough Set to 1 if the card has a loopthrough RF connector. > * @return FE pointer on success, NULL on failure. > */ > -extern struct dvb_frontend *tda826x_attach(struct dvb_frontend *fe, int addr, struct i2c_adapter *i2c, int has_loopthrough); > - > -#endif > +#if defined(CONFIG_DVB_TDA826X) || defined(CONFIG_DVB_TDA826X_MODULE) > +extern struct dvb_frontend* tda826x_attach(struct dvb_frontend *fe, int addr, > + struct i2c_adapter *i2c, > + int has_loopthrough); > +#else > +static inline struct dvb_frontend* tda826x_attach(struct dvb_frontend *fe, > + int addr, > + struct i2c_adapter *i2c, > + int has_loopthrough) > +{ > + printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __FUNCTION__); > + return NULL; > +} > +#endif // CONFIG_DVB_TDA826X > + > +#endif // __DVB_TDA826X_H__ This breaks with CONFIG_VIDEO_SAA7134_DVB=y, CONFIG_DVB_TDA826X=m. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/