Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <a70a17e3873f84681de379bde82d49ab96e70d21.camel@gmail.com>
Subject: Re: [PATCH v3 2/2] mmc: core: Let sanitize not retry in case of
 timeout/failure
From:   Bean Huo <huobean@gmail.com>
To:     Ulf Hansson <ulf.hansson@linaro.org>
Cc:     "Shimoda, Yoshihiro" <yoshihiro.shimoda.uh@renesas.com>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-mmc <linux-mmc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Bean Huo <beanhuo@micron.com>
Date:   Mon, 12 Apr 2021 19:46:56 +0200
In-Reply-To: <CAPDyKFoT4YoG1wwHYXMMpXmq-ybLMh_qipzr5yKkWUY8Yt5q0A@mail.gmail.com>
References: <20210402092432.25069-1-huobean@gmail.com>
         <20210402092432.25069-3-huobean@gmail.com>
         <CAPDyKFoT4YoG1wwHYXMMpXmq-ybLMh_qipzr5yKkWUY8Yt5q0A@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.4-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2021-04-12 at 09:50 +0200, Ulf Hansson wrote:
> > diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
> > index 8bfd4d95b386..9778093d7006 100644
> > --- a/drivers/mmc/core/block.c
> > +++ b/drivers/mmc/core/block.c
> > @@ -836,7 +836,7 @@ static inline int mmc_blk_part_switch(struct
> > mmc_card *card,
> >                  ret = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
> >                                   EXT_CSD_PART_CONFIG, part_config,
> > -                                card->ext_csd.part_time);
> > +                                card->ext_csd.part_time,
> > MMC_CMD_RETRIES);
> 
> 
> I would rather not change the mmc_switch() function definition, but
> 
> only __mmc_switch(). Just let mmc_switch() pass another in-parameter
> 
> (MMC_CMD_RETRIES) to __mmc_switch(), which means all callers of
> 
> mmc_switch() doesn't need to get changed, but only callers of
> 
> __mmc_switch().
> 
> 
> 
> [...]
> 
> 
> 
Hi Uffe,
Good point, I will change it in the next version of this patch.

thanks,
Bean

> Kind regards
> 
> Uffe