Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>
To:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC:     Lu Baolu <baolu.lu@linux.intel.com>,
        Camille Lu <camille.lu@hpe.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Joerg Roedel <joro@8bytes.org>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 5.4 v2 1/1] iommu/vt-d: Fix agaw for a supported 48 bit
 guest address width
Thread-Topic: [PATCH 5.4 v2 1/1] iommu/vt-d: Fix agaw for a supported 48 bit
 guest address width
Thread-Index: AQHXK92E2Pb9yfR2lku6DbKUN6XPZ6qpw5SAgAX4kQCAAEa0AIABN+qA
Date:   Mon, 12 Apr 2021 18:25:44 +0000
Message-ID: <DEA60498-1BFD-441D-B641-BC843695ED96@oracle.com>
References: <20210407184030.21683-1-saeed.mirzamohammadi@oracle.com>
 <deca9431-a52a-2818-4493-5a6ffeadccb9@linux.intel.com>
 <E3377E7A-073F-4D9C-92FE-8CC4836343AF@oracle.com>
 <036429a7-9924-7ed5-6be9-2bd087594e9b@linux.intel.com>
In-Reply-To: <036429a7-9924-7ed5-6be9-2bd087594e9b@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <60D8DE9EF6901F468FA534DF22B3FFB9@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e39764e-88b4-4ce5-cf4a-08d8fde062df
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2021 18:25:44.4942
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +B8fTMTr6690t4xHHPslRIXYo9BiIXHY5RYVqrXJRActhtyekV4SBZEQt8a73E9Ird5HX8KTsNFLpFa3jjVCKIaERZ9voioY5kqZZZEoZao=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1857
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9952 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0
 mlxscore=0 malwarescore=0 adultscore=0 bulkscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104060000 definitions=main-2104120117
X-Proofpoint-ORIG-GUID: HIbDX2gBRbVJd0s-sWIGF1k6gTmloOxm
X-Proofpoint-GUID: HIbDX2gBRbVJd0s-sWIGF1k6gTmloOxm
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9952 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0
 phishscore=0 suspectscore=0 mlxlogscore=999 priorityscore=1501
 clxscore=1011 lowpriorityscore=0 spamscore=0 impostorscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104060000 definitions=main-2104120117
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Greg,

This patch fixes an issue with the IOMMU driver and it only applies to 5.4,=
 4.19, and 4.14 stable kernels. May I know when this patch would be availab=
le in the stable kernels?

Subject: iommu/vt-d: Fix agaw for a supported 48 bit guest address width

Thanks,
Saeed


> On Apr 11, 2021, at 4:49 PM, Lu Baolu <baolu.lu@linux.intel.com> wrote:
>=20
> I guess you need to ask Greg KH <gregkh@linuxfoundation.org> with this
> Cc-ing to stable@vger.kernel.org.
>=20
> Best regards,
> baolu
>=20
> On 2021/4/12 3:36, Saeed Mirzamohammadi wrote:
>> Hi Lu,
>> Thanks for the review. May I know when do we expect this to be applied t=
o 5.4?
>> Thanks,
>> Saeed
>>> On Apr 7, 2021, at 5:25 PM, Lu Baolu <baolu.lu@linux.intel.com <mailto:=
baolu.lu@linux.intel.com>> wrote:
>>>=20
>>> On 4/8/21 2:40 AM, Saeed Mirzamohammadi wrote:
>>>> The IOMMU driver calculates the guest addressability for a DMA request
>>>> based on the value of the mgaw reported from the IOMMU. However, this
>>>> is a fused value and as mentioned in the spec, the guest width
>>>> should be calculated based on the minimum of supported adjusted guest
>>>> address width (SAGAW) and MGAW.
>>>> This is from specification:
>>>> "Guest addressability for a given DMA request is limited to the
>>>> minimum of the value reported through this field and the adjusted
>>>> guest address width of the corresponding page-table structure.
>>>> (Adjusted guest address widths supported by hardware are reported
>>>> through the SAGAW field)."
>>>> This causes domain initialization to fail and following
>>>> errors appear for EHCI PCI driver:
>>>> [    2.486393] ehci-pci 0000:01:00.4: EHCI Host Controller
>>>> [    2.486624] ehci-pci 0000:01:00.4: new USB bus registered, assigned=
 bus
>>>> number 1
>>>> [    2.489127] ehci-pci 0000:01:00.4: DMAR: Allocating domain failed
>>>> [    2.489350] ehci-pci 0000:01:00.4: DMAR: 32bit DMA uses non-identit=
y
>>>> mapping
>>>> [    2.489359] ehci-pci 0000:01:00.4: can't setup: -12
>>>> [    2.489531] ehci-pci 0000:01:00.4: USB bus 1 deregistered
>>>> [    2.490023] ehci-pci 0000:01:00.4: init 0000:01:00.4 fail, -12
>>>> [    2.490358] ehci-pci: probe of 0000:01:00.4 failed with error -12
>>>> This issue happens when the value of the sagaw corresponds to a
>>>> 48-bit agaw. This fix updates the calculation of the agaw based on
>>>> the minimum of IOMMU's sagaw value and MGAW.
>>>> Signed-off-by: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com <=
mailto:saeed.mirzamohammadi@oracle.com>>
>>>> Tested-by: Camille Lu <camille.lu@hpe.com <mailto:camille.lu@hpe.com>>
>>>> ---
>>>> Change in v2:
>>>> - Added cap_width to calculate AGAW based on the minimum value of MGAW=
 and AGAW.
>>>> ---
>>>>  drivers/iommu/intel-iommu.c | 7 ++++---
>>>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>>> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
>>>> index 953d86ca6d2b..a2a03df97704 100644
>>>> --- a/drivers/iommu/intel-iommu.c
>>>> +++ b/drivers/iommu/intel-iommu.c
>>>> @@ -1853,7 +1853,7 @@ static inline int guestwidth_to_adjustwidth(int =
gaw)
>>>>  static int domain_init(struct dmar_domain *domain, struct intel_iommu=
 *iommu,
>>>>       int guest_width)
>>>>  {
>>>> -int adjust_width, agaw;
>>>> +int adjust_width, agaw, cap_width;
>>>> unsigned long sagaw;
>>>> int err;
>>>>  @@ -1867,8 +1867,9 @@ static int domain_init(struct dmar_domain *doma=
in, struct intel_iommu *iommu,
>>>> domain_reserve_special_ranges(domain);
>>>> /* calculate AGAW */
>>>> -if (guest_width > cap_mgaw(iommu->cap))
>>>> -guest_width =3D cap_mgaw(iommu->cap);
>>>> +cap_width =3D min_t(int, cap_mgaw(iommu->cap), agaw_to_width(iommu->a=
gaw));
>>>> +if (guest_width > cap_width)
>>>> +guest_width =3D cap_width;
>>>> domain->gaw =3D guest_width;
>>>> adjust_width =3D guestwidth_to_adjustwidth(guest_width);
>>>> agaw =3D width_to_agaw(adjust_width);
>>>=20
>>> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com <mailto:baolu.lu@linux.=
intel.com>>
>>>=20
>>> Best regards,
>>> baolu