Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: dmr2gpNcziaft2lAtz8FzrUGWi4O82ilPK5nZYf+B3rfmHAC8uK/Vo9e9f7OqpMnY1fdxB56fL
 cQurdDduRUMQ==
IronPort-SDR: Ry9iw0SKTQ0K3efJJcq7X3P3Ky2VuQ7yAyv8p8I6gieNe4zJ4V7W9s7qIrfo03Dgk2m5JqQiaM
 FpVmZdmxVT2g==
Message-ID: <56550dd3c63b062efca5fc7d41c2a251e8fc55ba.camel@linux.intel.com>
Subject: Re: [PATCH] HID: hid-sensor-custom: remove useless variable
From:   srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To:     Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        jikos@kernel.org, benjamin.tissoires@redhat.com,
        linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Mon, 12 Apr 2021 15:27:03 -0700
In-Reply-To: <20210412112039.00006821@Huawei.com>
References: <1617952508-47150-1-git-send-email-jiapeng.chong@linux.alibaba.com>
         <4079bb49a9c0022603abeffcdaec32208f449e51.camel@linux.intel.com>
         <20210411145635.3c6b48d1@jic23-huawei>
         <ceb25b0000013f1c3e89d772c62b5e967a032446.camel@linux.intel.com>
         <20210412112039.00006821@Huawei.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 2021-04-12 at 11:20 +0100, Jonathan Cameron wrote:
> On Sun, 11 Apr 2021 09:06:35 -0700
> Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> wrote:
> 
> > On Sun, 2021-04-11 at 14:56 +0100, Jonathan Cameron wrote:
> > > On Fri, 09 Apr 2021 11:19:12 -0700
> > > Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> wrote:
> > >   
> > > > On Fri, 2021-04-09 at 15:15 +0800, Jiapeng Chong wrote:  
> > > > > Fix the following gcc warning:
> > > > > 
> > > > > drivers/hid/hid-sensor-custom.c:400:7: warning: variable
> > > > > ‘ret’
> > > > > set
> > > > > but
> > > > > not used [-Wunused-but-set-variable].
> > > > > 
> > > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > > > > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com
> > > > > >    
> > > > Acked-by: Srinivas Pandruvada <
> > > > srinivas.pandruvada@linux.intel.com  
> > > 
> > > Perhaps better to return ret if it is non zero?
> > > I can't immediately figure out if there is a reason we know that
> > > can't
> > > happen.  
> > Only time it can fail when there is no report descriptor or the
> > field
> > index is >= report->maxfield.
> > But since the attribute is registered from the report descriptor
> > and
> > index, this can't happen.
> > But we can enhance sensor_hub_set_feature() to fail when
> >  hid_set_field() fails. There is one case where field-
> > >logical_minimum
> > < 0  and value is out of range.
> 
> I'll go with what you think.  Apply as is, or handle the
> return value because we might at some later date return an error that
> can actually happen from here?
> 
I will send you a patch this week to handle error condition.

Thanks,
Srinivas

> Jonathan
> 
> > Thanks,
> > Srinivas
> > 
> > 
> > > Jonathan
> > >   
> > > > > ---
> > > > >  drivers/hid/hid-sensor-custom.c | 5 ++---
> > > > >  1 file changed, 2 insertions(+), 3 deletions(-)
> > > > > 
> > > > > diff --git a/drivers/hid/hid-sensor-custom.c
> > > > > b/drivers/hid/hid-
> > > > > sensor-custom.c
> > > > > index 2628bc5..e430673 100644
> > > > > --- a/drivers/hid/hid-sensor-custom.c
> > > > > +++ b/drivers/hid/hid-sensor-custom.c
> > > > > @@ -397,15 +397,14 @@ static ssize_t store_value(struct
> > > > > device
> > > > > *dev,
> > > > > struct device_attribute *attr,
> > > > >  
> > > > >  	if (!strncmp(name, "value", strlen("value"))) {
> > > > >  		u32 report_id;
> > > > > -		int ret;
> > > > >  
> > > > >  		if (kstrtoint(buf, 0, &value) != 0)
> > > > >  			return -EINVAL;
> > > > >  
> > > > >  		report_id = sensor_inst-
> > > > > >fields[field_index].attribute.
> > > > >  								
> > > > > report_
> > > > > id;
> > > > > -		ret = sensor_hub_set_feature(sensor_inst-
> > > > > >hsdev,
> > > > > report_id,
> > > > > -					     index,
> > > > > sizeof(value),
> > > > > &value);
> > > > > +		sensor_hub_set_feature(sensor_inst->hsdev,
> > > > > report_id,
> > > > > index,
> > > > > +				       sizeof(value), &value);
> > > > >  	} else
> > > > >  		return -EINVAL;
> > > > >