Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2579705pxb; Tue, 13 Apr 2021 05:31:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz48sVPD1GtPKTc/uSlqf0N2bkge/XHgzzRb6Ja7E9z16NJyvQfRv1oAwqNsVG5M1pwhFgD X-Received: by 2002:a17:906:fa83:: with SMTP id lt3mr6014837ejb.299.1618317113767; Tue, 13 Apr 2021 05:31:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618317113; cv=none; d=google.com; s=arc-20160816; b=eEB9uEJgg56yhB+zb8VkMqmHS8AidWQ9CvZunCuXexgw67jyXrxx3w5Nz+514Pf3kT tMktUo3vHjDMAUqbCA7ssp/PZfEQaGlQAgqe4uZlnnvf26GA9sEe8MM52cokdUARM7ZL +t3JGycNhyGjuqsHxMio5niLU7U5eEvas1OgGIO0nit1o+Eso4+k007cNKSLYUptQH4+ HH1qux7iL9bzSjBHZDOv9uFgyiX7ifxdAmBCZ2HId06GcU3PsYrS26WzlZN3Nz+1dpD8 jUYNNEruHTweozU8hGrkcP9JAd6XucKpy8nOADnd1ZUlp9DfpqTs9cfsukziBWo+HYJf AF9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=j5372T7oiTYIcSbokwY9txcLYb4l3MFl5tmPs5Qu1g4=; b=tk0MxH5X4/GGABYXIKHtrwJ1eoKFYzy6hsnyEvr9ELEZUgpfb3Cwidhb2Ho36ntXEq As6VJighgZ9imBZXYD7i7wQhuIu2HwXFqs4KRKWtDNK5S3VnhfMQYUs0PQqinzNHEGkr qdtfkLBnf+evoHJ2HgZMAMwCn+wCAx5sz9vo8KIHx9u8O+CloQ0fnVhgPlADthwJFvrb /qtOC1TFnga/V93ZUeHYJKBU2UGb7L2w6bA7bquQZe0Am8lHYXBbtOhlxeWQAhdyh0sY GhvfjmEA8FU973ewOBkDfKqQH1UJc+4jutH4Wb5WqRk7PAU38WgYSPXly4vANx/ATgMY 6IFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=BFfi9g7c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dm24si9496007edb.297.2021.04.13.05.31.30; Tue, 13 Apr 2021 05:31:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=BFfi9g7c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229818AbhDME37 (ORCPT + 99 others); Tue, 13 Apr 2021 00:29:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229695AbhDME3z (ORCPT ); Tue, 13 Apr 2021 00:29:55 -0400 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15427C061574; Mon, 12 Apr 2021 21:29:34 -0700 (PDT) Received: by mail-yb1-xb29.google.com with SMTP id 65so16719967ybc.4; Mon, 12 Apr 2021 21:29:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=j5372T7oiTYIcSbokwY9txcLYb4l3MFl5tmPs5Qu1g4=; b=BFfi9g7cTyM4uAYGsM8ghUZhjP3ucL5jxhFX0bLofyQI2XfE9XFq9dDaNQ1DQKpBqC 6LxmdhThUqD6gDMy9szjRZxc4ntZFhaYMjeGrNh52rsoO5TWEF8EPLQrDoR74rVYSUGr c2GdHiiXS6r349VFN1VfeA6MAxz8CMgcev7EVBBYdm3Z0uJKxa92HuHBpBUT2sPeADsz PtuyEc7k8AoNYeJOBX0z2QCfW8AstnLaw3y3VgUBLXCcj15EFReyU1FXHhTEUOwdTJy7 y/mJWr1ooUu7lSgFZvfYPba2o2p5q4vENaMeW5BSpH3ceb7lxubBCA8rozstp6g3iQ71 dnOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=j5372T7oiTYIcSbokwY9txcLYb4l3MFl5tmPs5Qu1g4=; b=I73oLMgYd+aJ6EUB2Idh7bO3KcAwM0YNZl2Rc/MM2aavnlKR7o9cimqXehKPFJVVMS nBFGDWURWZEkjNSacHv23ZQuj4Wwb6rg6XbY0w8MhaOIRZPsy6x4X3Xebi6+7vujixaF 4PtfA1aKJwC4frH7pNZZnhoZ4dcDpzxPFv1nHM9iuAqVdsxW7W0J9UZ+f2ZfJQYGDSiX ONDJ8vJS+/a9rSpm1yiC1yxYiWIdywXHlaWOtQNcqJhFiW4DuXvaQeouldr6ygv6jYwg j10ihOVnh3fBzAS1h2d1tfxgPJlZ43NpN8LfzHDOhSEOR1UxSIyWtINY/N6OTikF9/7o HjOA== X-Gm-Message-State: AOAM533CY/O0Wrrgl8sSni1wAJ3yKvqq+CebAlhtQGqimqRRDExXfx05 V2J4IPWYKwL8p0b7nNhR7FWcdkSjtXujNNaAbnM= X-Received: by 2002:a25:9942:: with SMTP id n2mr41399080ybo.230.1618288173358; Mon, 12 Apr 2021 21:29:33 -0700 (PDT) MIME-Version: 1.0 References: <20210412192434.944343-1-pctammela@mojatatu.com> In-Reply-To: <20210412192434.944343-1-pctammela@mojatatu.com> From: Andrii Nakryiko Date: Mon, 12 Apr 2021 21:29:22 -0700 Message-ID: Subject: Re: [PATCH bpf-next v2] libbpf: clarify flags in ringbuf helpers To: Pedro Tammela Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Joe Stringer , Quentin Monnet , "open list:BPF (Safe dynamic programs and tools)" , "open list:BPF (Safe dynamic programs and tools)" , open list , Pedro Tammela Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 12, 2021 at 12:25 PM Pedro Tammela wrote: > > In 'bpf_ringbuf_reserve()' we require the flag to '0' at the moment. > > For 'bpf_ringbuf_{discard,submit,output}' a flag of '0' might send a > notification to the process if needed. > > Signed-off-by: Pedro Tammela > --- Great, thanks! Applied to bpf-next. > include/uapi/linux/bpf.h | 16 ++++++++++++++++ > tools/include/uapi/linux/bpf.h | 16 ++++++++++++++++ > 2 files changed, 32 insertions(+) > [...]