Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2589684pxb; Tue, 13 Apr 2021 05:45:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz8wt/PwrqZ+bI+LlbvnUojSa6rOl96J8qUclAGdXSY3M520PIx0Oocq3mcI3IVk4Vq0ZOk X-Received: by 2002:a17:902:be10:b029:e9:78a0:dd33 with SMTP id r16-20020a170902be10b02900e978a0dd33mr29163234pls.1.1618317933147; Tue, 13 Apr 2021 05:45:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618317933; cv=none; d=google.com; s=arc-20160816; b=HbrNYwjJXJxXSlFKNHzn9x3DMjdQrJ4LSkhbgZklzGx1TGmeMTPMkiMpiayH48hkYh 5f+Cpd6YrVq9joL4XJYPMT8Y19PBwa+3mKf9iTdz0FZabR7dW01AfwBsUZ1zNxDkHyiE PtKVvZK++I6/aALHtJaujqBgEBnpr2rhova7P6FAoKVfo/sScnyl5DdCP6T8l1+w8FNq uIEGj6zi6vodGlvob4uvSJMSmFf9KBA71kNibz7cU7sIcGWy21xsmMtu6Vu0j7oTNQWT m6kcVeHJxY/RtJRxSZeZCnERxR2s/akck3HojbEVsdZKOMJ+WUt+OAwUTq9r1fIHJs2b BVOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=GJP8fy7iKl8dKDV7E0klDhAvK0oVKdzafF/dYILoImU=; b=D0kaD1nYhQLdEFvBs1QvaQiLNiTRrOfL50vWlKh5g80ib9/D/zyOzdr4ZjE+TmpXVW LVQTAtYmqwFRVv98A5LPsApdmw5YDLiKNTiI2ZxxqUQA30akHLpZ9Jy8O5k/lkvlzZ4w m0yEVdAhkZPxooD5PFROataFk6ZRvyoeEdLNu1I4DF3UWocN6wa+9SbFehBxw7rjlSYB oHYH0acC+QHvRxN5vi1/z7QAls6WscXI6tM4nCKQDOZ0T7HoM8DXQgTxutrUsUgtGoHJ EzSuPxYrajCy+dfRkxiV+uoFKmV0EMQoQCAS9lBGDDCOncVVO3sEV1blOM0ZGnsdn7/9 BhTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="LJI7/2S4"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u12si17527178pls.117.2021.04.13.05.45.20; Tue, 13 Apr 2021 05:45:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="LJI7/2S4"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345073AbhDMGtP (ORCPT + 99 others); Tue, 13 Apr 2021 02:49:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:38976 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245077AbhDMGtI (ORCPT ); Tue, 13 Apr 2021 02:49:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618296528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GJP8fy7iKl8dKDV7E0klDhAvK0oVKdzafF/dYILoImU=; b=LJI7/2S4imkvlvRrVQ0QleTE9OcAjzjNrDZF3FRxbM/AFLaKjc2b5H2GOqFaIJ7tB9oQx3 fuZNVIz6ucxp1AAywhCSGSpiEnhQ70XFXBrRtIhQvNDqUTOrvtIiwXXN8DzSdxYHhN0JmA YZRKA5JvsHarYk7nDzVoDfNxbhcGchM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-48-uCC3GaStOo-ZktgeWFkllg-1; Tue, 13 Apr 2021 02:48:44 -0400 X-MC-Unique: uCC3GaStOo-ZktgeWFkllg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B3C7A18766D4; Tue, 13 Apr 2021 06:48:42 +0000 (UTC) Received: from gondolin (ovpn-113-97.ams2.redhat.com [10.36.113.97]) by smtp.corp.redhat.com (Postfix) with ESMTP id 094F96062F; Tue, 13 Apr 2021 06:48:36 +0000 (UTC) Date: Tue, 13 Apr 2021 08:48:34 +0200 From: Cornelia Huck To: "Christian A. Ehrhardt" Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Alex Williamson , Alexey Kardashevskiy , David Gibson , Michael Ellerman Subject: Re: [PATCH] vfio/pci: Add missing range check in vfio_pci_mmap Message-ID: <20210413084834.1d5cd6cb.cohuck@redhat.com> In-Reply-To: <20210412214124.GA241759@lisa.in-ulm.de> References: <20210410230013.GC416417@lisa.in-ulm.de> <20210412140238.184e141f@omen> <20210412214124.GA241759@lisa.in-ulm.de> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Apr 2021 23:41:24 +0200 "Christian A. Ehrhardt" wrote: > When mmaping an extra device region verify that the region index > derived from the mmap offset is valid. > > Fixes: a15b1883fee1 ("vfio_pci: Allow mapping extra regions") > Cc: stable@vger.kernel.org > Signed-off-by: Christian A. Ehrhardt > --- > drivers/vfio/pci/vfio_pci.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Cornelia Huck