Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751899AbWJNToR (ORCPT ); Sat, 14 Oct 2006 15:44:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752171AbWJNToR (ORCPT ); Sat, 14 Oct 2006 15:44:17 -0400 Received: from smtp.osdl.org ([65.172.181.4]:20383 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1751899AbWJNToR (ORCPT ); Sat, 14 Oct 2006 15:44:17 -0400 Date: Sat, 14 Oct 2006 12:43:51 -0700 From: Andrew Morton To: Greg KH Cc: Chandra Seetharaman , Joel Becker , ckrm-tech@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/5] Allow more than PAGESIZE data read in configfs Message-Id: <20061014124351.63434962.akpm@osdl.org> In-Reply-To: <20061014080107.GB19325@kroah.com> References: <20061010182043.20990.83892.sendpatchset@localhost.localdomain> <20061010203511.GF7911@ca-server1.us.oracle.com> <20061011131935.448a8696.akpm@osdl.org> <20061011221822.GD7911@ca-server1.us.oracle.com> <20061011154836.9befa359.akpm@osdl.org> <1160609233.6389.82.camel@linuxchandra> <20061014080107.GB19325@kroah.com> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1712 Lines: 42 On Sat, 14 Oct 2006 01:01:07 -0700 Greg KH wrote: > On Wed, Oct 11, 2006 at 04:27:13PM -0700, Chandra Seetharaman wrote: > > On Wed, 2006-10-11 at 15:48 -0700, Andrew Morton wrote: > > > On Wed, 11 Oct 2006 15:18:22 -0700 > > > Joel Becker wrote: > > > > > > > On Wed, Oct 11, 2006 at 01:19:35PM -0700, Andrew Morton wrote: > > > > > The patch deletes a pile of custom code from configfs and replaces it with > > > > > calls to standard kernel infrastructure and fixes a shortcoming/bug in the > > > > > process. Migration over to the new interface is trivial and almost > > > > > scriptable. > > > > > > > > The configfs stuff is based on the sysfs code too. Should we > > > > migrate sysfs/file.c to the same seq_file code? Serious question, if > > > > the cleanup is considered better. > > > > > > > > > > I don't see why not. I don't know if anyone has though of/proposed it > > > before. > > > > I can generate a patch for that too. > > Argh!!!! > > Are you going to honestly tell me you have a single attribute in sysfs > that is larger than PAGE_SIZE? He does not. It's a matter of reusing existing facilities rather than impementing similar things in multiple places. The equivalent patch in configfs removed a decent amount of code: fs/configfs/file.c | 130 ++++++++++------------------------------------- include/linux/configfs.h | 3 - 2 files changed, 31 insertions(+), 102 deletions(-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/