Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2682262pxb;
        Tue, 13 Apr 2021 07:46:18 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxyeL844pxM05qZGjItnd8eZfVUbVHx5LjfGNhfGwuXOGpCvR80rXZz3PMi058qRtR7xy9p
X-Received: by 2002:a17:906:7c9:: with SMTP id m9mr14480114ejc.54.1618325178531;
        Tue, 13 Apr 2021 07:46:18 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1618325178; cv=none;
        d=google.com; s=arc-20160816;
        b=DvpZguVHV0NgWP5708WJCHmNGUaT0SxH4Qrrb3Z4zW9EfFIwF9Yq7iJd9jSiVThU4I
         yDhx0GO1RMVnRcobjoRhjVh2606ruVMBYZQPdUD/RrIhP+x0O14xWISyuPPHLzrlCWFx
         qYxMfyrccUVohKkg0pj2Ts8zXYoNdlMihyWQT0h1nVhhKQ0lFBZqyRV2g1SbBXCql+VZ
         yNrEzfbbEUv7HGlcUWBmJjM7mvnkebPcp3z1ThybumbzQl/h72ne3pDvLPrYwiXsgMS7
         sv1qizErC+dp1JGP7zLBSH5nM6Vrq9sQV856bz63hNRxVPvLNzbVVLAdqKMu7P4Ef+50
         wyiA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:user-agent:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=OvNQM6IzRqdh+yn7nQwJNg/YLF9PnNkxrdQ/ThWGjc8=;
        b=ltxfxuuTNIUCNdiwqzzjlG96aZRdcGm3fPj5clezZobo0Z5KPFZxepXvNaNcn4znZb
         xLmO1Yn2RdiJTtQzHSe8ZdzyLcn5nOiRJ79HWBDNj5iIIYM1TJS3QphENh6xg+YxY4gR
         qOsfM562Y3FeN0YfTJN8B5Aj9mImekkzHq2QiZUFlfuJNwKDd5gNjgdSxnljJ4TS+/fP
         ns0TNMC0wEkbtJBgss6cU8s/cBUZlCOspZtOPgqgnODJkQ/29izeYdwmKDBJkSmra/p5
         R84aukaDfpvkJl0OlaSFVqS5/cY7CHAVGskEsMwCdH4H3th1jsXj1vLKE6a6h2jQlqA4
         gW8g==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=htgGNyWt;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id k10si4652657ejh.253.2021.04.13.07.45.50;
        Tue, 13 Apr 2021 07:46:18 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=htgGNyWt;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S245109AbhDMLSW (ORCPT <rfc822;linux.whf@gmail.com> + 99 others);
        Tue, 13 Apr 2021 07:18:22 -0400
Received: from mail.kernel.org ([198.145.29.99]:35998 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S237455AbhDMLSV (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 13 Apr 2021 07:18:21 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id A3A0861042;
        Tue, 13 Apr 2021 11:18:01 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1618312682;
        bh=OvNQM6IzRqdh+yn7nQwJNg/YLF9PnNkxrdQ/ThWGjc8=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=htgGNyWtADlGcCPiJP5fBSZhNRgAP9DbAFrZhvgLiryC1QRZlhGvJXNZDD+IIoBNI
         YUUNKK/nXIE9FpLQXqnHcHRSUiJl03dgeG6ns3XsK3sIdyO22ABpkHgjvuA616eeAU
         wT2975oa+rTorepMsYpRm2/xf2k0xLd6GUTFQ3Wbu9sy3uslPOBpT1Veubj8PJhsVt
         4ykAGmiFYX0Cect+JMR6Eh3OxDz0VGjxseL0INNTq7YDGCCyce8Ws06dhz7G9Cl8T9
         +qPNBcUezQhHnLQgyLUXPgo0brB3b1Pmj2q9VmQ9Rvk3DOqKPCnW7qCG41MiG8sUom
         mvbKSM/MDDwmw==
Date:   Tue, 13 Apr 2021 12:17:40 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Shengjiu Wang <shengjiu.wang@nxp.com>
Cc:     lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: ak5558: correct reset polarity
Message-ID: <20210413111740.GC5586@sirena.org.uk>
References: <1618293991-6611-1-git-send-email-shengjiu.wang@nxp.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="IpbVkmxF4tDyP/Kb"
Content-Disposition: inline
In-Reply-To: <1618293991-6611-1-git-send-email-shengjiu.wang@nxp.com>
X-Cookie: Shake well before using.
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--IpbVkmxF4tDyP/Kb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Apr 13, 2021 at 02:06:31PM +0800, Shengjiu Wang wrote:

> Reset (aka power off) happens when the reset gpio is made active.
> Change function name to ak5558_reset to match devicetree property
> "reset-gpios".

Please split the fix to polarity out from the refactoring, the
refactoring completely dominates this patch so it's very hard to review.

--IpbVkmxF4tDyP/Kb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmB1fdQACgkQJNaLcl1U
h9AZMQf8C+Dzhlre7G7rflNnG0xa6JsHdDP7W7C7EqGltU5gMyqxmtEyDgrvbO4y
2ww8ck76dmT6S4xm8QWVfkxuSWGFntwg52fZzCqg/lIirPusSY8FI5fEZAhjQTDs
Y9Biodef+9uS23aH4Ga7qwQ6da1tVAPOOVsMwAf6dwVB65qMQIwzvyu1ZXPC/itD
OX1rMqBRVEWzpTBRhd5gqOLCiSran9pTOreC3GxVAZ8H/gPpKbwiZDBSjMMkW8hI
emSeeHsb/qeeuoBd64tFgiS/5l9SRuP/fNeJ0ZebUjWekKg+jZ/REgVAVQgKSuzV
OdpFIr7Si0sE/VHdvtMnG/uH1prYAg==
=85l7
-----END PGP SIGNATURE-----

--IpbVkmxF4tDyP/Kb--