Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 13 Apr 2021 13:41:20 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc:     Clemens Gruber <clemens.gruber@pqgruber.com>,
        linux-pwm@vger.kernel.org, Sven Van Asbroeck <TheSven73@gmail.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v8 4/8] dt-bindings: pwm: Support new PWM_USAGE_POWER flag
Message-ID: <YHWDYOPKGylFKQvl@orome.fritz.box>
References: <20210412132745.76609-1-clemens.gruber@pqgruber.com>
 <20210412132745.76609-4-clemens.gruber@pqgruber.com>
 <20210412162723.7hlhgqp6wlfbkeky@pengutronix.de>
 <YHR5eyLPqiwhTGrr@workstation.tuxnet>
 <20210413113805.mjft5jxt3qhsxg6e@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="1vkEgIoTkhyBIpER"
Content-Disposition: inline
In-Reply-To: <20210413113805.mjft5jxt3qhsxg6e@pengutronix.de>
User-Agent: Mutt/2.0.6 (98f8cb83) (2021-03-06)
Precedence: bulk


--1vkEgIoTkhyBIpER
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 13, 2021 at 01:38:05PM +0200, Uwe Kleine-K=C3=B6nig wrote:
> Hello,
>=20
> On Mon, Apr 12, 2021 at 06:46:51PM +0200, Clemens Gruber wrote:
> > On Mon, Apr 12, 2021 at 06:27:23PM +0200, Uwe Kleine-K=C3=B6nig wrote:
> > > On Mon, Apr 12, 2021 at 03:27:41PM +0200, Clemens Gruber wrote:
> > > > Add the flag and corresponding documentation for PWM_USAGE_POWER.
> > >=20
> > > My concern here in the previous round was that PWM_USAGE_POWER isn't a
> > > name that intuitively suggests its semantic. Do you disagree?
> >=20
> > No. It is more abstract and requires documentation. But I also didn't
> > want to waste too much time on discussing names, so I used Thierry's
> > suggestion.
>=20
> If you introduce API thinking about the name before actually introducing
> it is a good idea in general. (OK, the name doesn't become part of the
> (binary) dt API, but we don't even agree about its semantic here.)
>=20
> And IMHO a bad name with a good documentation isn't good enough.
> Otherwise we can better just agree on using plain numbers in the .dts
> files.

Plain numbers or not doesn't change anything. The meaning of the bit has
to be defined. This has nothing to do with the symbolic name at all.

Thierry

--1vkEgIoTkhyBIpER
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmB1g2AACgkQ3SOs138+
s6GFIhAAsJVQtvNUbdNjFIrlooVmgFsgZDdz6nvRDINjq5wAXhr9VC25lzKFUu2y
M3obnsBkTZ54FR4GGbtMFmQnrQcDj+E8xpxqNMaupLBmTwWpgZgsSCqxag1quVFL
NNZvyIrnYKDaRRfxvWVVPI8GXWlzceEuCpStmggjjp8qv2isqlvPGq+VxW9AURLR
zuGWp7a7DIgO5i5bbhJ7gPAI48V0QIqN0c1Oq4jkPsQm0x5L8+qoTlD/4o1smhxE
HKBqgKyLtcnT2FJKvcbVsVhCQK+ZtWBYiTM/NIQ2Ym/70jD9Ktz6a3w5EDMu5Rfl
S0iUTFQ0tAZUGlDs3aLl0EH95/bdvlu5eEp8r7HzTh/vrvcv+fSI5Fj1Isek37+c
NEDuJb0LP7CChm7KiN6WCtpxeBQSJ9t7MUk0/1EEqR++PD/iFQ04X6I66gxBBJLf
Su6ho/Pet3SgjkridToUUDmxZqTrfZ4fzxG1Jf4yIAO9ePfwPxTnLSrayZDVFl6M
IymcjlBuel15E5rXIhUIBKQjNamZQUG11LEviQtvmF3YWddsaOQcFyoc27lM508h
nLjyFhxSGa+AXSM3GB/eR8ZRHt8XfQ76JFdSK4MKT+VwJKZnWClH03IRo+XnqsKM
xWmvvP3aT9+/sInV4Fl5FyKCcdmEw0oSCSWGbSQx2+AbFWbAk7M=
=GeVW
-----END PGP SIGNATURE-----

--1vkEgIoTkhyBIpER--