Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2718760pxb; Tue, 13 Apr 2021 08:34:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxTGFmhVahd1Xiwxg/QrkNuJ4tQLC6viMuxWQmuwHdmU90C5mK8JHrB8ta7dLXId/o0m0OW X-Received: by 2002:aa7:cd6a:: with SMTP id ca10mr33539404edb.16.1618328098799; Tue, 13 Apr 2021 08:34:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618328098; cv=none; d=google.com; s=arc-20160816; b=ubz1t6M716FyM2eGgdSRRoZrGeY6ZvK3VkUPUcnuRMQHah21WBuydRUBgCYu3WDldH kcOCe9ujWOoZLRKnmGqRdvqN05I5Zs46m+CQAcL1WWfbDkAuBIK0yuAmqjI0H8/am08N h+zRW7nvOUU76ggQ6ikHEiLQdcqCuu4Gfrsfz/w2bzi0BzhX6Pyh1ee4GgcQXcQUYytf SlBBYMjW6Y8tk1EKXzLfZ4HxyIncFzOhcOLULkbl6gPePSHdQTmqO3z0clr3Cx8BLFAM Yy25Hv1cOpZEMB4duG2TXBUv/bgEqJ8bgzoLRkNYCXBh+za821abachd7NClLR/RjZPu rd1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=3QjEnMGGCweLgbWk3VDURE6Y1ge38LSGs2vO7CeEpeY=; b=iHpyhjtQzgUyv+m4njG8bCx1jMgJMZQ/PdigObIlm6cS3raecGQjsCS//fglzzgaE6 RW2ReRRKSQpeta8/ZzHU6ncmO2kbnAkUb2VVh8moTm9SuKLaWXJJ7/q94N+LZW3FtaC0 uPq+blvm5I/IpET/SReZ/t9mXFJhi3SVpFAWRVqPY6/T0N7A19/xKOMZYnnlx9cTP6In 5E7hh/PGXtQxICyPDiD5i6mCe/IJ2S7jb00v0lZyyql6wSDDrrhwV+t3NFd2YS9R/nCg yIsKLXF5sfCxj/CMuHicNFk2Ttp2b0DmHu/cqMyYXwMp+mqvfLLXAL7z1xUj/fUeAoDh Pw2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l15si10618789edb.89.2021.04.13.08.34.34; Tue, 13 Apr 2021 08:34:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231738AbhDMN6G (ORCPT + 99 others); Tue, 13 Apr 2021 09:58:06 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:48352 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229741AbhDMN6E (ORCPT ); Tue, 13 Apr 2021 09:58:04 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lWJXv-00GTsG-JC; Tue, 13 Apr 2021 15:57:39 +0200 Date: Tue, 13 Apr 2021 15:57:39 +0200 From: Andrew Lunn To: Christian Herber Cc: "Radu-nicolae Pirea (OSS)" , "hkallweit1@gmail.com" , "linux@armlinux.org.uk" , "davem@davemloft.net" , "kuba@kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] phy: nxp-c45: add driver for tja1103 Message-ID: References: <64e44d26f45a4fcfc792073fe195e731e6f7e6d9.camel@oss.nxp.com> <111528aed55593de83a17dc8bd6d762c1c5a3171.camel@oss.nxp.com> <82741edede173f50a5cae54e68cf51f6b8eb3fe3.camel@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Ok, we can agree that there will not be a perfect naming. Would it be a > possibility to rename the existing TJA11xx driver to TJA1100-1-2 or is that > unwanted? It is generally a bad idea. It makes back porting fixing harder if the file changes name. > If nxp-c45.c is to generic (I take from your comments that' your > conclusion), we could at least lean towards nxp-c45-bt1.c? Unfortunately, > the product naming schemes are not sufficiently methodical to have a a good > driver name based on product names. And what does bt1 stand for? How about nxp-c45-tja11xx.c. It is not ideal, but it does at least give an indication of what devices it does cover, even if there is a big overlap with nxp-tja11xx.c, in terms of pattern matching. And if you do decide to have a major change of registers, your can call the device tja1201 and have a new driver nxp-c45-tja12xx. Andrew