Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 13 Apr 2021 13:51:15 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc:     Clemens Gruber <clemens.gruber@pqgruber.com>,
        linux-pwm@vger.kernel.org, Sven Van Asbroeck <TheSven73@gmail.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v8 4/8] dt-bindings: pwm: Support new PWM_USAGE_POWER flag
Message-ID: <YHWFs1f0XHkqbddp@orome.fritz.box>
References: <20210412132745.76609-1-clemens.gruber@pqgruber.com>
 <20210412132745.76609-4-clemens.gruber@pqgruber.com>
 <20210412162723.7hlhgqp6wlfbkeky@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="CeMXB2IKKXvrsAIH"
Content-Disposition: inline
In-Reply-To: <20210412162723.7hlhgqp6wlfbkeky@pengutronix.de>
User-Agent: Mutt/2.0.6 (98f8cb83) (2021-03-06)
Precedence: bulk


--CeMXB2IKKXvrsAIH
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 12, 2021 at 06:27:23PM +0200, Uwe Kleine-K=C3=B6nig wrote:
> On Mon, Apr 12, 2021 at 03:27:41PM +0200, Clemens Gruber wrote:
> > Add the flag and corresponding documentation for PWM_USAGE_POWER.
>=20
> My concern here in the previous round was that PWM_USAGE_POWER isn't a
> name that intuitively suggests its semantic. Do you disagree?

I suggested PWM_USAGE_POWER because I think it accurately captures what
we want here.

> > Cc: Rob Herring <robh+dt@kernel.org>
> > Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
> > ---
> >  Documentation/devicetree/bindings/pwm/pwm.txt | 3 +++
> >  include/dt-bindings/pwm/pwm.h                 | 1 +
> >  2 files changed, 4 insertions(+)
> >=20
> > diff --git a/Documentation/devicetree/bindings/pwm/pwm.txt b/Documentat=
ion/devicetree/bindings/pwm/pwm.txt
> > index 084886bd721e..fe3a28f887c0 100644
> > --- a/Documentation/devicetree/bindings/pwm/pwm.txt
> > +++ b/Documentation/devicetree/bindings/pwm/pwm.txt
> > @@ -46,6 +46,9 @@ period in nanoseconds.
> >  Optionally, the pwm-specifier can encode a number of flags (defined in
> >  <dt-bindings/pwm/pwm.h>) in a third cell:
> >  - PWM_POLARITY_INVERTED: invert the PWM signal polarity
> > +- PWM_USAGE_POWER: Only care about the power output of the signal. This
> > +  allows drivers (if supported) to optimize the signals, for example to
> > +  improve EMI and reduce current spikes.
>=20
> IMHO there are too many open questions about which freedom this gives to
> the lowlevel driver. If the consumer requests .duty_cycle =3D 25ns +
> .period =3D 100ns, can the driver provide .duty_cycle =3D 25s + .period =
=3D
> 100s which nominally has the same power output? Let's not introduce more
> ambiguity than there already is.

The freedom given to the driver should be to adjust the signal within
reasonable bounds. Changing the time unit by a factor of 1000000000 is
not within reason, and I doubt anyone would interpret it that way, even
if we didn't document this at all.

To be frank I think that quest of yours to try and rid the PWM API of
all ambiguity is futile. I've been trying to be lenient because you seem
motivated, but I think you're taking this too far. There are always
going to be cases that aren't completely clear-cut and where drivers
need the flexibility to cheat in order to be useful at all. If we get to
a point where everything needs to be 100% accurate, the majority of the
PWM controllers won't be usable at all.

Don't let perfect be the enemy of good.

Thierry

--CeMXB2IKKXvrsAIH
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmB1hbMACgkQ3SOs138+
s6HYLhAAhdf86s3re5qOKds5oPjtXld/X7JkGE4TVl5uSJ57Lft2n3oVTuXtIbMJ
j07WfvLgEDG2B2dX7LcSoCd6VH1A3f4iop/VbkyLe5xT0NZ4AtEA2rZBRuUs5gvw
K3GrPOtQeU2V1WX2rRcVGZDBqlv+Hrwy0AF09MrZw8XW4YIYnkXPDmp5OD/oBzKv
Jk9ZPWZngieA3y5KGaA25sWOSoz5owkEBcHlw0FDr0y3lGljl8yVXxVs0fbXio9V
IgFL1mU6cFz3Xh71H6qBy0aql/I+tnB3Q/cKVFk5N3pnh5j3K0nxYuNG2NXnNkd2
9lMt/5rk8SRwa0UWbarxGBK1bZAEUpFAfVaWmKB2uzp1iixyNxvDJOKuYnmpIrE3
kBMKguVf7Xj8OJKcBkk6R3RRgORPdEKTKE890wqRx/NISsp5gNnqRTdWNfrmnIzS
zPJK1vqmymqggapL2/xuvdIFfntTaR6THH1R5i5tRS7RrVb+jswLwk7fBn1F7St0
6dh/fJ0qR0uqtq4Pw2TQVmBc/ku+/dxae41YAcM+tLM20JWECQOUerVTWB6F9Hfm
bw6M8AQYZIkUCGbImBNJlqC7kSiqfyGH0gss82y4nNvk6hmfeBX0cs6glX6WPOLd
tXrTwTktfGcS+xfBVUo2qqt5P4qmBH7HzCxP1TRlaTu9BQG1jAQ=
=nXbs
-----END PGP SIGNATURE-----

--CeMXB2IKKXvrsAIH--