Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2865369pxb; Tue, 13 Apr 2021 12:07:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy5Y35z6IizQP+FCaDxDlReb2w7J1HZdjiDJTovvoq4lExVSnSSQULJmmawoWxPnr9vktE6 X-Received: by 2002:a05:6402:354b:: with SMTP id f11mr36186300edd.361.1618340837938; Tue, 13 Apr 2021 12:07:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618340837; cv=none; d=google.com; s=arc-20160816; b=xb7GuZAqjyR2M1nxtcAGRbQmsSfP/4pQOe84CTgqN1uyA2flHIhai8fZNxieQgHfJN buOapombJiK48B7efWaXL0iSVDIYkULGKjtaQ0WFVBCSAjXTrD+ZOxxsvKp4O8BHxT99 +Xgu/qZBUek2C6uHb8dbf7xQYF9WM2xAG0+0PT0Oa0EA45GpRXF2roHh9saU/P5qk1eo CUaPE6en8sw2CNyyfLIk02xPR/j/12il6rI2ta0PpSSJPF24SkhWgNj3Oy06n44fo9Cr n6m6QaIGHCtRsvgrZScCMuhFN5bjsq9xKCmTM4jLU+5q9s8N08sgvBV0GSwbbNNNwqI4 OLOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=dUP0mmYc5PS53JTmGtYQ/UoruFkNut8DqFGyPA4/gAQ=; b=J1nVe6JJcoMvF8APEVvH3b6OiZXaSljcCPYJlkj/14181dPbuZliQTrn98Z++6T/7n X0HYXGk1hX3+zaI8Tp+oMsjonfvcZEyszSRBOGfId+/HJxwQY5Zy/LY+r2APJ+Aq4Eje BVXZ2JYZKt2gyh8lEWz+6w0OzC2Ur7PdAYSqWMQQZ/Da9EFolnhWY7PcEqkWJ/XN8KMh vtspZ+OaLm0YmSJloZoLL1syxyaFEhXvNXNF1rArZzZueHY0ttTuFEOoelceOhmuEdmC odI+kd5zgByblrzJKaYtylZ/la9nR5SuZsvUZA7HdlGO6x9tRxrVQShRoHHGFj3DDpJy xXqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="HJgxHZ/J"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id af16si11065276ejc.294.2021.04.13.12.06.54; Tue, 13 Apr 2021 12:07:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="HJgxHZ/J"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237361AbhDMOq3 (ORCPT + 99 others); Tue, 13 Apr 2021 10:46:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbhDMOq1 (ORCPT ); Tue, 13 Apr 2021 10:46:27 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 203B3C061574; Tue, 13 Apr 2021 07:46:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dUP0mmYc5PS53JTmGtYQ/UoruFkNut8DqFGyPA4/gAQ=; b=HJgxHZ/JL///I5K5iiFNwZboW8 4em50NAFunOC0gXIhElilt+ak46BHJjXM3OXhm27crqL1OOWiNxoxtMRNQaRtZnia7/V0+46DU52v 2yWmjbd5YfcUwnfnyiwUBfClz3ptH96NUqzW53PmMRx7CR/LXiGfDEeeSwoLSqG/tpAeMvesqQXgL I2HYrOFXT8ergZI1nTtVDp1I5ZopAXyNh8ixU29VSOeQ/apuzui2m+GQ9fWtTL1WrbZ/UErQpXOuP ngolUfu/4pKaoCITCCJJns/JEgxAFYz/qFuDBtfr5KvYKjZSdy/OricpfYEVf7UnoJg/RPCWdD6GB zxo7+t4g==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lWKHm-005s4L-Vd; Tue, 13 Apr 2021 14:45:19 +0000 Date: Tue, 13 Apr 2021 15:45:02 +0100 From: Matthew Wilcox To: Miklos Szeredi Cc: linux-fsdevel@vger.kernel.org, Al Viro , "Darrick J . Wong" , Amir Goldstein , David Sterba , Christian Brauner , Eric Biggers , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 01/18] vfs: add fileattr ops Message-ID: <20210413144502.GP2531743@casper.infradead.org> References: <20210325193755.294925-1-mszeredi@redhat.com> <20210325193755.294925-2-mszeredi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210325193755.294925-2-mszeredi@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 25, 2021 at 08:37:38PM +0100, Miklos Szeredi wrote: > @@ -107,6 +110,8 @@ fiemap: no > update_time: no > atomic_open: shared (exclusive if O_CREAT is set in open flags) > tmpfile: no > +fileattr_get: no or exclusive > +fileattr_set: exclusive > ============ ============================================= This introduces a warning to `make htmldocs`: /home/willy/kernel/folio/Documentation/filesystems/locking.rst:113: WARNING: Malformed table. Text in column margin in table line 24. You need to add an extra '=' to the first batch of '=' (on all three lines of the table). Like this: @@ -87,9 +87,9 @@ prototypes:: locking rules: all may block -============ ============================================= +============= ============================================= ops i_rwsem(inode) -============ ============================================= +============= ============================================= lookup: shared create: exclusive link: exclusive (both) @@ -112,7 +112,7 @@ atomic_open: shared (exclusive if O_CREAT is set in open flags) tmpfile: no fileattr_get: no or exclusive fileattr_set: exclusive -============ ============================================= +============= ============================================= (whitespace damaged)