Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2881532pxb; Tue, 13 Apr 2021 12:34:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzG0SATZ2I97Uv6BExLsPiizUZ/Qt5NLzg3wnxtl0m1UQ35P2ToaxxJ/ioCVaYZ0DdrINRy X-Received: by 2002:a63:5223:: with SMTP id g35mr2338743pgb.164.1618342447860; Tue, 13 Apr 2021 12:34:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618342447; cv=none; d=google.com; s=arc-20160816; b=dVUUjzGfsN2hHYVyx/ACeaVmQn3Foycor3fvM5MBv/7rppoTpLTxWegHf2yLzLo7oO WnmtKHvA/Jp6cqn//ukBhwNdiX3hrJn9VvMYeOWIoCUBKPdhhW6RMN7hPF/kbMfTKgaq fnTEj/uSvbY+SN9u2xFnoap9riOGaxedzXQdnCl5LaMEMcTivZISc7XS57Umo+pJ0Zap 2kTVT8UmPiPwuRtkBvhlyHRPTqSIdI2mE9KvCCPa2deVaF/m8MNy5vRphbCc7HaoMEw0 panT1tRY294N73ddw4sSDOtWZe29iHLKugvOneAvlWK7pG6SGSzIdmuL1O1dMXhm2Z5y 9SQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=YhnPP6u9N/CNuPG8a6wrzWC7SaSzVdUFxXGQFLTxZ5c=; b=Fdf6e+QDkmoHMSSwTCTHKj6yRu638pT5LAoNYNmNItLksYw9HOLvTZSeMB2dhqedZf ti/WQml1J/6xHgEtN8vEfjjfbfcsHmHIj5yV4k5iD2zQLwzaPwrOD060+vrAyRrUPhyh zeH7yt1xJpCFVKZSvuqxCu2eJU+mAUmyA+SRs4mrRFvDkfm8IARyFYysFkhMm5tilvpu lRq6IuYj7fKBzOTVMM7SfjRWglOFaduxfBVkAT3GdL+ltK4w1gcgclIsqwwSM2ta7gRB jZ0x+r/J1LIAeY1NYJboB3zlY7JqBYobW3XbJm3n5eJpCZuf68xE7uzT/GWu+b2/vkQg Ktfw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t21si16767964pfg.64.2021.04.13.12.33.54; Tue, 13 Apr 2021 12:34:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346243AbhDMOGI (ORCPT + 99 others); Tue, 13 Apr 2021 10:06:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:39528 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237811AbhDMOGH (ORCPT ); Tue, 13 Apr 2021 10:06:07 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CA1C261242; Tue, 13 Apr 2021 14:05:47 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=hot-poop.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lWJfl-007FMf-M4; Tue, 13 Apr 2021 15:05:45 +0100 From: Marc Zyngier To: james.morse@arm.com, eric.auger.pro@gmail.com, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, alexandru.elisei@arm.com, kvm@vger.kernel.org, Eric Auger , suzuki.poulose@arm.com Cc: gshan@redhat.com, drjones@redhat.com Subject: Re: [PATCH] KVM: arm/arm64: Fix KVM_VGIC_V3_ADDR_TYPE_REDIST read Date: Tue, 13 Apr 2021 15:05:41 +0100 Message-Id: <161832273337.3709196.17485368965759835272.b4-ty@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210412150034.29185-1-eric.auger@redhat.com> References: <20210412150034.29185-1-eric.auger@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: james.morse@arm.com, eric.auger.pro@gmail.com, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, alexandru.elisei@arm.com, kvm@vger.kernel.org, eric.auger@redhat.com, suzuki.poulose@arm.com, gshan@redhat.com, drjones@redhat.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Apr 2021 17:00:34 +0200, Eric Auger wrote: > When reading the base address of the a REDIST region > through KVM_VGIC_V3_ADDR_TYPE_REDIST we expect the > redistributor region list to be populated with a single > element. > > However list_first_entry() expects the list to be non empty. > Instead we should use list_first_entry_or_null which effectively > returns NULL if the list is empty. Applied to kvm-arm64/vgic-5.13, thanks! [1/1] KVM: arm/arm64: Fix KVM_VGIC_V3_ADDR_TYPE_REDIST read commit: 94ac0835391efc1a30feda6fc908913ec012951e Cheers, M. -- Without deviation from the norm, progress is not possible.