Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 13 Apr 2021 17:52:45 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Fabio Aiuto <fabioaiuto83@gmail.com>
Cc:     gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/19] staging: rtl8723bs: remove unnecessary bracks on
 DBG_871X removal sites
Message-ID: <20210413145245.GG6021@kadam>
References: <cover.1617802415.git.fabioaiuto83@gmail.com>
 <35f5edf0f39b717b3de3ad7861cbaa5f4ba60576.1617802415.git.fabioaiuto83@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <35f5edf0f39b717b3de3ad7861cbaa5f4ba60576.1617802415.git.fabioaiuto83@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Wed, Apr 07, 2021 at 03:49:36PM +0200, Fabio Aiuto wrote:
> @@ -2586,11 +2583,9 @@ static int rtw_dbg_port(struct net_device *dev,
>  
>  								plist = get_next(plist);
>  
> -								if (extra_arg == psta->aid) {
> -									for (j = 0; j < 16; j++) {
> +								if (extra_arg == psta->aid)
> +									for (j = 0; j < 16; j++)
>  										preorder_ctrl = &psta->recvreorder_ctrl[j];
> -									}
> -								}

I think Greg already applied this so no stress (don't bother fixing),
but you removed a bit too much on this one.  Multi-line indents normally
get curly braces for readability.  In other words:

				if (extra_arg == psta->aid) {
					for (j = 0; j < 16; j++)
						preorder_ctrl = &psta->recvreorder_ctrl[j];
				}

regards,
dan carpenter