Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 13 Apr 2021 12:20:47 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To:     Or Cohen <orcohen@paloaltonetworks.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        vyasevich@gmail.com, nhorman@tuxdriver.com, davem@davemloft.net,
        kuba@kernel.org, linux-sctp@vger.kernel.org, lucien.xin@gmail.com,
        nmarkus@paloaltonetworks.com
Subject: Re: [PATCH] net/sctp: fix race condition in sctp_destroy_sock
Message-ID: <YHW2zwdoDLVRPB/6@horizon.localdomain>
References: <20210413093153.27281-1-orcohen@paloaltonetworks.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210413093153.27281-1-orcohen@paloaltonetworks.com>
Precedence: bulk

On Tue, Apr 13, 2021 at 12:31:53PM +0300, Or Cohen wrote:
> +++ b/net/sctp/socket.c
> @@ -1520,11 +1520,9 @@ static void sctp_close(struct sock *sk, long timeout)
>  
>  	/* Supposedly, no process has access to the socket, but
>  	 * the net layers still may.
> -	 * Also, sctp_destroy_sock() needs to be called with addr_wq_lock
> -	 * held and that should be grabbed before socket lock.
>  	 */

Please also update the following comment in sctp_init_sock():
          /* Nothing can fail after this block, otherwise
           * sctp_destroy_sock() will be called without addr_wq_lock held
           */

Other than this, LGTM. Thanks.

  Marcelo