Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750757AbWJOMru (ORCPT ); Sun, 15 Oct 2006 08:47:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750754AbWJOMru (ORCPT ); Sun, 15 Oct 2006 08:47:50 -0400 Received: from mailer.gwdg.de ([134.76.10.26]:55973 "EHLO mailer.gwdg.de") by vger.kernel.org with ESMTP id S1750748AbWJOMrt (ORCPT ); Sun, 15 Oct 2006 08:47:49 -0400 Date: Sun, 15 Oct 2006 14:36:08 +0200 (MEST) From: Jan Engelhardt To: Josef Sipek cc: Andrew Morton , linux-kernel@vger.kernel.org, torvalds@osdl.org, hch@infradead.org, viro@ftp.linux.org.uk, linux-fsdevel@vger.kernel.org, penberg@cs.helsinki.fi, ezk@cs.sunysb.edu, mhalcrow@us.ibm.com Subject: Re: [PATCH 1 of 2] Stackfs: Introduce stackfs_copy_{attr,inode}_* In-Reply-To: <20061013200705.GB31928@filer.fsl.cs.sunysb.edu> Message-ID: References: <20061013122706.56970df2.akpm@osdl.org> <20061013200705.GB31928@filer.fsl.cs.sunysb.edu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Report: Content analysis: 0.0 points, 6.0 required _SUMMARY_ Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 659 Lines: 20 >> Many of these functions are too large to be inlined. Suggest they be >> placed in fs/fs-stack.c (or whatever we call it). fs/stack.c would probably be enough -- fs/fs-stack.c is like include/linux/reiserfs_fs.h >Ack. As a rule of thumb, for functions like these (laundry list of >assignments), what's a good threshold? 3 or 4 I guess. Might want to take a look at other static-inline functions. -`J' -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/