Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2957636pxb; Tue, 13 Apr 2021 14:46:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJww4ZiGZqzzM6eiORoOt+2FZ2JuijW1Dt9pUuDujvwyjezioivPlcTAz7c6SPRcb9RcgY6F X-Received: by 2002:a05:6402:518c:: with SMTP id q12mr37764512edd.11.1618350405942; Tue, 13 Apr 2021 14:46:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618350405; cv=none; d=google.com; s=arc-20160816; b=dRk4vbrRRyOA0PsLZMCjXn2QqNVBh5cW2azVDPFtDNwyoTtA+UnK8WPD1xv8VKPWe9 h2qHBZW0C5B6Q4SvNFAySwEy5k5XEUV5I80qjzLms4WC45wYZEBX93A7fprAsUNujCme v3DJesxqWgwRCttREiIzZUeJUB2ziNcHcMUkXIPs6q7gKdWuFDIl4PuY4ODfDazXPfFq Zs9hjHUSVkMjI8kNJqLbQH1c3/S9C8Uf1ggPNSnTdPCL8lkGM9JuRLX5+N2LdGZji44p A+X8lqLav/N8LF9aIBaxWVdBhOmvlo2F52x00bsbdViGmUxFKK7Nq/KQa9PQVZMEFAMx nY0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=ITBPa+AGfqX46GioQvT8Yuq8ZSdb73IcX5vEeJ3QJb4=; b=yUbzNBd0e8Ughq7Hm2mVVH3r6/4unClTSy5FM621m1vqo2bHfemd7by/ABiUqBOfS1 BD20ssfN998ogBK6/dEMQ4nx8LJyaPX9flMH1qRBNLIvdrjh9l7VefUAjkqFUDvkwTDV fPIjtwGDSXyF35olaKJJoeZKy2CuEvv5XkseMOZx43iaVaHgH35RD/lk4I+2OKf/YW5x SC4nJ0oJdHXc8Cv6ThAbiLioHRdIr4RsGi3RcdUxUiu4Hs4/9nceT5TeJWBm/tpD37Xz e2pcXLUQFwocEJ6mCbBMBTANrT0+K3c5/TaXPnKiOPgyIR3i/8pYsSavtekB7HEYLXdK 9a9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn3si2296926ejc.690.2021.04.13.14.46.22; Tue, 13 Apr 2021 14:46:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346832AbhDMQkR (ORCPT + 99 others); Tue, 13 Apr 2021 12:40:17 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:2847 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231330AbhDMQkP (ORCPT ); Tue, 13 Apr 2021 12:40:15 -0400 Received: from fraeml745-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4FKWKm5RPgz689NR; Wed, 14 Apr 2021 00:30:04 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml745-chm.china.huawei.com (10.206.15.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 13 Apr 2021 18:39:54 +0200 Received: from [10.47.4.3] (10.47.4.3) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2106.2; Tue, 13 Apr 2021 17:39:53 +0100 Subject: Re: [PATCH v2 1/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU To: "liuqi (BA)" , "will@kernel.org" , "mark.rutland@arm.com" , "bhelgaas@google.com" CC: "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Zhangshaokun References: <1617959157-22956-1-git-send-email-liuqi115@huawei.com> <1617959157-22956-2-git-send-email-liuqi115@huawei.com> <4cae4206-aa50-f111-2f6f-d035bc36856e@huawei.com> <9c577f11-46e7-55a0-95e8-6c3376077049@huawei.com> From: John Garry Message-ID: <60dffcdf-f5a5-b533-2474-ba44580191a9@huawei.com> Date: Tue, 13 Apr 2021 17:37:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.4.3] X-ClientProxiedBy: lhreml704-chm.china.huawei.com (10.201.108.53) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/04/2021 10:12, liuqi (BA) wrote: >>>> >>>> I do wonder why we even need maintain pcie_pmu->cpumask >>>> >>>> Can't we just use cpu_online_mask as appropiate instead? >> >> ? > Sorry, missed it yesterday. > It seems that cpumask is always same as cpu_online_mask, So do we need > to reserve the cpumask sysfs interface? I'm not saying that we don't require the cpumask sysfs interface. I am just asking why you maintain a separate cpumask, when, as I said, they seem the same. Thanks, John