Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2965463pxb; Tue, 13 Apr 2021 15:01:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzs06k/ewT/H8Pv0xg2YRSn+2iAx9pTSl4K3gkCpGlV2rR5zomlxhlKDonOR/uHQzGt3v/Y X-Received: by 2002:a17:902:720b:b029:e9:abcc:e60a with SMTP id ba11-20020a170902720bb02900e9abcce60amr24665911plb.20.1618351272354; Tue, 13 Apr 2021 15:01:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618351272; cv=none; d=google.com; s=arc-20160816; b=ntpLkcM3P+LNyKDYVPotHQr7MbpDMBy+TIk0guNzCwsQFBIHP6oY8tZ9g24vbyZ8DM Oh4nNG2gTqD352czakoIVA/TGl2A2lsuesB/6EmATXOYw6w9sQ2lfPxqjcU5GjoKbH/o H9WHTBRxC+6EuVipgRnrusUc4+aNxWh0dB6FXib+jPKNOhfEQDoUqZ03yVNfJ967UJvi HU7bIxLonQz3n3aFihhwhpIknkDNYWCiSlbWrtg2bEMtrZDELGgUVS3mNDCDgtiqAweu xuRgOMFjC1aQl6ShtqeQ4wdIf7hlJzGk2XaqOfQMnBIkT1fTsR+IqiCJ8qQA4WBlco/a iEKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature; bh=K/kiVlWr9jXTw6l1mfaywK3J5oBfrjHUAoZh2g85M0w=; b=PRU+cwKE5Z9+6I3vPhLLegcneIvz6zwe2O90QxYr5BJ+5EmTkecNEje3J3of1j0LDL NhPSUEFMSU/0alQqze6+G9XkgPhmzlFEOFGyFSGYrZHAo7ooqG1WR4roGHswLCqmaMc+ gtRdAEE+yjC5sZMuIPddFWU4LeEqwqaz6A/w69fAye8QKSmM8jwQR/CSR/HVXKIJS8sM pdRZzY+AlFItqPAjjVG2AkvsprW5/PaoC3UBUGTPahnOXAbdNuOhZTDfd+C+FYK+qW3H Oot+5lOSXFiaA4fSJCraGl9XmLE5YeK+7a/EaZy8UnNGHGtO9tPB2IbLWtBPUTfR6oY8 y7lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=XED4oB6R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p12si18626629pgr.411.2021.04.13.15.00.59; Tue, 13 Apr 2021 15:01:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=XED4oB6R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347117AbhDMRIl (ORCPT + 99 others); Tue, 13 Apr 2021 13:08:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347118AbhDMRIj (ORCPT ); Tue, 13 Apr 2021 13:08:39 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A00FC061574; Tue, 13 Apr 2021 10:08:16 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id h4so8160399wrt.12; Tue, 13 Apr 2021 10:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=K/kiVlWr9jXTw6l1mfaywK3J5oBfrjHUAoZh2g85M0w=; b=XED4oB6RsgA4wpo+b6abLPediKo9oasX8Sx58+/FjuOA9VqncW09qfnpEFg675hYYS 37IsYdS/2p/SDCVXUifyYfTAmpU2GP8aQ1BaDPFgcirbn4oM8FE2Ld5topCMnRDBM4Nq PcUfmhAcCJp+Vtnrum16aLe720VQFhCGhASJRAXoMVJSkvIBB//rzO2WjsOoW8tD0P/e H3OjcdZ/ZI8qp2nFNtajq+EynV2SLhOGuBG0I84V6iqSCw7DPeG8OXwvQvRVa69HLGJA BTTi9tOeqKrtXrgawdhxW7iHMKji8wfBVi68l1jwhOw/bUCG8q33mmjNfRBAHksBmHQW 87Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=K/kiVlWr9jXTw6l1mfaywK3J5oBfrjHUAoZh2g85M0w=; b=ibWoy/X/+MFeAKIiYr1k6ZoFn5hPRNG3A7bGkHewoE8ZN+bsVIVjevR3ZIPythMveT 2/DX+FU3as7amBxt0bR/oZEVkL/k7zNnDnxuBg1zhK+CTg5vRo+5hGhnJ/glLdJmmlXy BJWf/1qQfg+AWPdoiRktiEntEU8VCA10PzqslwYo4kf2unHh1A7kgFJH1qyCwr1vuBPd 15hBr0x1acsHX+HQLeHcPfXDeQud55Ca8i01Zdl00iseWK62tf7CuBeyhDFjh6PocXRp hRZTSJjbpyRJWr7C5HQ3VbfTIPE8G2VLGhx4LN1FYLkimJGDxzBCL/1CZCJ+6LRPV+Yj 2xZQ== X-Gm-Message-State: AOAM532jPRCktjwyMKkcRA635DHdLRxvcvkKfy/1bnnpVo99bbtsr1eF V0RlaIKxRlC/ZD0QKhE6Pls= X-Received: by 2002:adf:fb05:: with SMTP id c5mr39073342wrr.302.1618333695126; Tue, 13 Apr 2021 10:08:15 -0700 (PDT) Received: from 192.168.10.5 ([39.46.65.172]) by smtp.gmail.com with ESMTPSA id i12sm879580wmd.3.2021.04.13.10.08.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 10:08:14 -0700 (PDT) Message-ID: <3caf81e242edacd91e32217261e2d21ceb5d4dc7.camel@gmail.com> Subject: Re: [PATCH] xen/pciback: Fix incorrect type warnings From: Muhammad Usama Anjum To: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , "moderated list:XEN HYPERVISOR INTERFACE" , open list , kernel-janitors@vger.kernel.org, colin.king@canonical.com, dan.carpenter@oracle.com Cc: musamaanjum@gmail.com Date: Tue, 13 Apr 2021 22:08:10 +0500 In-Reply-To: References: <20210326181442.GA1735905@LEGION> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reminder! On Mon, 2021-03-29 at 09:24 +0200, Juergen Gross wrote: > On 26.03.21 19:14, Muhammad Usama Anjum wrote: > > Correct enum pci_channel_io_normal should be used instead of putting > > integer value 1. > > > > Fix following smatch warnings: > > drivers/xen/xen-pciback/pci_stub.c:805:40: warning: incorrect type in argument 2 (different base types) > > drivers/xen/xen-pciback/pci_stub.c:805:40: expected restricted pci_channel_state_t [usertype] state > > drivers/xen/xen-pciback/pci_stub.c:805:40: got int > > drivers/xen/xen-pciback/pci_stub.c:862:40: warning: incorrect type in argument 2 (different base types) > > drivers/xen/xen-pciback/pci_stub.c:862:40: expected restricted pci_channel_state_t [usertype] state > > drivers/xen/xen-pciback/pci_stub.c:862:40: got int > > drivers/xen/xen-pciback/pci_stub.c:973:31: warning: incorrect type in argument 2 (different base types) > > drivers/xen/xen-pciback/pci_stub.c:973:31: expected restricted pci_channel_state_t [usertype] state > > drivers/xen/xen-pciback/pci_stub.c:973:31: got int > > > > Signed-off-by: Muhammad Usama Anjum > > Reviewed-by: Juergen Gross > > > Juergen