Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp2995978pxb; Tue, 13 Apr 2021 15:56:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxDMJP25gOiLVmu+G/+IR+v5iuP1kMknbhtfGCqwgD2tTFz1y9ztmO5NRq3u0J1QG+yv57A X-Received: by 2002:aa7:9516:0:b029:24c:c0:4fd2 with SMTP id b22-20020aa795160000b029024c00c04fd2mr13537448pfp.30.1618354585064; Tue, 13 Apr 2021 15:56:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618354585; cv=none; d=google.com; s=arc-20160816; b=oXoipk5mIzlXS4s4e7mA2cUO8TjbGs2TWSKMmDhOza6gTO11TO+56hTNNT1QmI8wu9 8ILBmbtpxUp2ftAZIEp+UN/oFccazgjvGRbWrqHZlFkdMcm8ztWJhQHqDWSFXcm/FMbP cyOYE7FqKVcffUtjVVsG0g/2hyU/+bbQJ4hx6spSLL+tc5KYREYjOhuFw+xewXqcLsqk lsTxR+SbnmXMxWG7WuQMNvreN14AvWhJrgSk1eO9wXo2TuDRUI0yGkquof9JSvTCOqlp Y+/Kbw6fFOvzymh3kGmwJRevX0WN79B4hcYlxb4tM6pKmyFlMLLiSNg8UQQgi03SkZ08 bACg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:references:mime-version :message-id:in-reply-to:date:reply-to:dkim-signature; bh=3pnXNHyPtgGcg37a0kVWxRztf39QNHtD0Ft3zXb2qAc=; b=hruJxjO1RazOmWQx8Jfn2dlUgUy+NbXuF7f14lryMtQniEwRnW0lkSeCS1qBCkccuF lqx5pQezMgJy6NM2yEYlh7V3tEfmB33REulD6uPXhxuJRRddPP1LTj91RLV7x6Mm+K2q e9vxyOIivP7U7nX2Nf1z+QiSpu0lXAMsJ7q0ZDqWbUgvRihJRPDqRFXvlsz4DKKTmpi+ eKhyo3Q4IBjEdcs0KAp7LwRU7cI04H9D7pMzO+fc2q97Td+bXoft4MFxkxtzSMVvppmr LfPbq6FU0Ue0r0fTjnjz9jk2HmMdXyqBZAub+zhhKnA477U0Yvvjbxa+BkRw2gGlQMMS wKVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="lhG/UfcH"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e3si18041851pgd.419.2021.04.13.15.56.11; Tue, 13 Apr 2021 15:56:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="lhG/UfcH"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347772AbhDMSaK (ORCPT + 99 others); Tue, 13 Apr 2021 14:30:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347767AbhDMSaG (ORCPT ); Tue, 13 Apr 2021 14:30:06 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C40AC06138C for ; Tue, 13 Apr 2021 11:29:45 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id g7so17060939ybm.13 for ; Tue, 13 Apr 2021 11:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=reply-to:date:in-reply-to:message-id:mime-version:references :subject:from:to:cc; bh=3pnXNHyPtgGcg37a0kVWxRztf39QNHtD0Ft3zXb2qAc=; b=lhG/UfcHROVd7145tjdD3BwEBuqi+DUF9UbliOiMwye9gVed6mLHJO2wx//Xr/G++W 5wGxFA6bEExFF6iD59g/Ry0/dLm2bxLqGjt+zvz3jnczKvxYQUhqUJsaAK7ah3PtQz16 LWK+pzC8efhXYd0kQGJQzTTRNcj8AClyrDM0OGsB25R/8c3/lAAunUecBkozode5ZuT8 sN6zeNZrE0BllHAwx1VURW5YbckNh8ovpfh9VLvL9EUFuaHHw8v3zv20iHTprVg0oKGl h2jjSfSNfEnH10NoWbGbzNqXLZvm8LPMZ9UKaQSB+MTQz0qo6nH1xqgRgZHdgXQk3Lac BEcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:date:in-reply-to:message-id :mime-version:references:subject:from:to:cc; bh=3pnXNHyPtgGcg37a0kVWxRztf39QNHtD0Ft3zXb2qAc=; b=m/LWxc0yWFlKPK28qJzniPbu0YkcgIEPvTHjhzX7CRGAhzOmEtWwvEWED1iYMCq+El QClFYBZ2TtJWMJb/USUr2h3dykGbZCqYXyC1uBh1+GRKRi3d9d5DdK1i1WJhZLzjugpY Gv2gwWrd77JFR0+ZlFGdyz8CG7ks/Yo7JyhPezus2rNkQfYGs494NHvVoQuXLjCaoUkX 9vob06dHLYZ98U/82XQW4R2mqRC8CUdmjU+QhwiEbGeUxdCsDB7iIvgvWlYT39jCS5WS Gc/v9bRFKZtX0wqHDYlwtWAFKxbFZ/fJ/e23QHKeaLKkt34DPgSrSUNmUhobR9FZMHbk Aupg== X-Gm-Message-State: AOAM531mOJ8CnXzXhJmw6km2JQwiGYbal3s0kbG0E2dNTo6jPbT0kWuu NiuiiEFQqZnjNpTfwFxJRo2ZE7Ehyp4= X-Received: from seanjc798194.pdx.corp.google.com ([2620:15c:f:10:f031:9c1c:56c7:c3bf]) (user=seanjc job=sendgmr) by 2002:a25:dfd0:: with SMTP id w199mr13235033ybg.92.1618338584829; Tue, 13 Apr 2021 11:29:44 -0700 (PDT) Reply-To: Sean Christopherson Date: Tue, 13 Apr 2021 11:29:28 -0700 In-Reply-To: <20210413182933.1046389-1-seanjc@google.com> Message-Id: <20210413182933.1046389-3-seanjc@google.com> Mime-Version: 1.0 References: <20210413182933.1046389-1-seanjc@google.com> X-Mailer: git-send-email 2.31.1.295.g9ea45b61b8-goog Subject: [RFC PATCH 2/7] context_tracking: Move guest enter/exit logic to standalone helpers From: Sean Christopherson To: Paolo Bonzini Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Christian Borntraeger , Michael Tokarev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Move guest enter/exit context tracking to standalone helpers, so that the existing wrappers can be moved under KVM. No functional change intended. Signed-off-by: Sean Christopherson --- include/linux/context_tracking.h | 43 +++++++++++++++++++------------- 1 file changed, 26 insertions(+), 17 deletions(-) diff --git a/include/linux/context_tracking.h b/include/linux/context_tracking.h index 58f9a7251d3b..89a1a5ccb2ab 100644 --- a/include/linux/context_tracking.h +++ b/include/linux/context_tracking.h @@ -71,6 +71,30 @@ static inline void exception_exit(enum ctx_state prev_ctx) } } +static __always_inline void context_tracking_guest_enter_irqoff(void) +{ + if (context_tracking_enabled()) + __context_tracking_enter(CONTEXT_GUEST); + + /* KVM does not hold any references to rcu protected data when it + * switches CPU into a guest mode. In fact switching to a guest mode + * is very similar to exiting to userspace from rcu point of view. In + * addition CPU may stay in a guest mode for quite a long time (up to + * one time slice). Lets treat guest mode as quiescent state, just like + * we do with user-mode execution. + */ + if (!context_tracking_enabled_this_cpu()) { + instrumentation_begin(); + rcu_virt_note_context_switch(smp_processor_id()); + instrumentation_end(); + } +} + +static __always_inline void context_tracking_guest_exit_irqoff(void) +{ + if (context_tracking_enabled()) + __context_tracking_exit(CONTEXT_GUEST); +} /** * ct_state() - return the current context tracking state if known @@ -110,27 +134,12 @@ static __always_inline void guest_enter_irqoff(void) vtime_account_guest_enter(); instrumentation_end(); - if (context_tracking_enabled()) - __context_tracking_enter(CONTEXT_GUEST); - - /* KVM does not hold any references to rcu protected data when it - * switches CPU into a guest mode. In fact switching to a guest mode - * is very similar to exiting to userspace from rcu point of view. In - * addition CPU may stay in a guest mode for quite a long time (up to - * one time slice). Lets treat guest mode as quiescent state, just like - * we do with user-mode execution. - */ - if (!context_tracking_enabled_this_cpu()) { - instrumentation_begin(); - rcu_virt_note_context_switch(smp_processor_id()); - instrumentation_end(); - } + context_tracking_guest_enter_irqoff(); } static __always_inline void guest_exit_irqoff(void) { - if (context_tracking_enabled()) - __context_tracking_exit(CONTEXT_GUEST); + context_tracking_guest_exit_irqoff(); instrumentation_begin(); vtime_account_guest_exit(); -- 2.31.1.295.g9ea45b61b8-goog