Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From:   Giulio Benetti <giulio.benetti@benettiengineering.com>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH v6 1/2] dt-bindings: touchscreen: Add HY46XX bindings
Date:   Tue, 13 Apr 2021 20:34:29 +0200
Message-Id: <4B3FA892-C04C-49C7-B306-4105759C7157@benettiengineering.com>
References: <CAL_JsqLZo45pY+mB+vvsAaGaE8N-P=4ojOMGSra4=6y1ESTJBw@mail.gmail.com>
Cc:     Linux Input <linux-input@vger.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Henrik Rydberg <rydberg@bitmath.org>,
        devicetree@vger.kernel.org,
        =?utf-8?Q?Jonathan_Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        linux-kernel@vger.kernel.org
In-Reply-To: <CAL_JsqLZo45pY+mB+vvsAaGaE8N-P=4ojOMGSra4=6y1ESTJBw@mail.gmail.com>
To:     Rob Herring <robh@kernel.org>
Precedence: bulk


> Il giorno 13 apr 2021, alle ore 19:58, Rob Herring <robh@kernel.org> ha sc=
ritto:
>=20
> =EF=BB=BFOn Tue, Apr 13, 2021 at 10:27 AM Giulio Benetti
> <giulio.benetti@benettiengineering.com> wrote:
>>=20
>>> On 4/13/21 5:07 PM, Rob Herring wrote:
>>> On Mon, 12 Apr 2021 17:23:59 +0200, Giulio Benetti wrote:
>>>> This adds device tree bindings for the Hycon HY46XX touchscreen series.=

>>>>=20
>>>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>>>> ---
>>>> V1->V2:
>>>> As suggested by Rob Herring:
>>>> * fixed $id: address
>>>> * added "hycon," in front of every custom property
>>>> * changed all possible property to boolean type
>>>> * removed proximity-sensor-switch property since it's not handled in dr=
iver
>>>> V2->V3:
>>>> As suggested by Jonathan Neusch=C3=A4fer:
>>>> * fixed some typo
>>>> * fixed description indentation
>>>> * improved boolean properties descriptions
>>>> * improved hycon,report-speed description
>>>> V3->V4:
>>>> * fixed binding compatible string in example as suggested by Jonathan N=
eusch=C3=A4fer
>>>> V4->V5:
>>>> As suggested by Rob Herring:
>>>> * drop hycon- prefix from compatible
>>>> * use Hertz unit suffix for hycon,report-speed instead of u32
>>>> * set hycon,report-speed minimum to 1Hz, 0Hz make controller to do noth=
ing
>>>> * change hycon,power-noise-enable property name to hycon,noise-filter-e=
nable
>>>> * improve hycon,filter-data property description
>>>> * use generic touchscreen node name in example
>>>> V5->V6:
>>>> * changed report-speed property name into report-speed-hz according to
>>>> Rob Herring's suggestion
>>>> ---
>>>>  .../input/touchscreen/hycon,hy46xx.yaml       | 119 ++++++++++++++++++=

>>>>  MAINTAINERS                                   |   6 +
>>>>  2 files changed, 125 insertions(+)
>>>>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen=
/hycon,hy46xx.yaml
>>>>=20
>>>=20
>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>=20
>> I've sent v7[1] before receiving your Reviewed-by.
>> Do I have to re-submit it once and if I receive a Reviewed-by from you
>> as a v8 with all your Reviewed-by's?
>=20
> I gave it on v7 too, so only if there are other changes on any of the
> patches.

Ah ok, thank you.

> The tools will generally pick up any tags on the version
> applied. You just can't expect maintainers to go rummage thru old
> versions to find any tags.

Sure not, this is the reason why I=E2=80=99ve asked, I=E2=80=99ve forgotten t=
o add some tag to my commits that I usually do, that=E2=80=99s why I=E2=80=99=
ve messed things up.

Thank you again for reviewing and explaining me.
Best regards
Giulio Benetti

>=20
> Rob