Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 13 Apr 2021 16:08:27 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To:     Or Cohen <orcohen@paloaltonetworks.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        vyasevich@gmail.com, nhorman@tuxdriver.com, davem@davemloft.net,
        kuba@kernel.org, linux-sctp@vger.kernel.org, lucien.xin@gmail.com,
        nmarkus@paloaltonetworks.com
Subject: Re: [PATCH v2] net/sctp: fix race condition in sctp_destroy_sock
Message-ID: <YHXsK3DzBTsO00lb@horizon.localdomain>
References: <20210413181031.27557-1-orcohen@paloaltonetworks.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210413181031.27557-1-orcohen@paloaltonetworks.com>
Precedence: bulk

On Tue, Apr 13, 2021 at 09:10:31PM +0300, Or Cohen wrote:
> If sctp_destroy_sock is called without sock_net(sk)->sctp.addr_wq_lock
> held and sp->do_auto_asconf is true, then an element is removed
> from the auto_asconf_splist without any proper locking.
> 
> This can happen in the following functions:
> 1. In sctp_accept, if sctp_sock_migrate fails.
> 2. In inet_create or inet6_create, if there is a bpf program
>    attached to BPF_CGROUP_INET_SOCK_CREATE which denies
>    creation of the sctp socket.
> 
> The bug is fixed by acquiring addr_wq_lock in sctp_destroy_sock
> instead of sctp_close.
> 
> This addresses CVE-2021-23133.
> 
> Reported-by: Or Cohen <orcohen@paloaltonetworks.com>
> Reviewed-by: Xin Long <lucien.xin@gmail.com>
> Fixes: 610236587600 ("bpf: Add new cgroup attach type to enable sock modifications")
> Signed-off-by: Or Cohen <orcohen@paloaltonetworks.com>

Thanks folks.
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>