Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 13 Apr 2021 09:57:30 -0500
From:   Rob Herring <robh@kernel.org>
To:     Ikjoon Jang <ikjn@chromium.org>
Cc:     linux-input@vger.kernel.org, devicetree@vger.kernel.org,
        Hsin-Yi Wang <hsinyi@chromium.org>,
        Dmitry Torokhov <dtor@chromium.org>,
        Nicolas Boichat <drinkcat@chromium.org>,
        Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Guenter Roeck <groeck@chromium.org>,
        Lee Jones <lee.jones@linaro.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] mfd: google,cros-ec: add DT bindings for a
 baseboard's switch device
Message-ID: <20210413145730.GA1667299@robh.at.kernel.org>
References: <20210412113020.2724134-1-ikjn@chromium.org>
 <20210412113020.2724134-2-ikjn@chromium.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210412113020.2724134-2-ikjn@chromium.org>
Precedence: bulk

On Mon, Apr 12, 2021 at 07:30:19PM +0800, Ikjoon Jang wrote:
> This is for ChromeOS tablets which have a 'cros_cbas' switch device
> in the "Whiskers" base board. This device can be instantiated only by
> device tree on ARM platforms. ChromeOS EC doesn't provide a way to
> probe the device.
> 
> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
> 
> ---
> 
> Changes in v4:
> Define cros-cbase bindings inside google,cros-ec.yaml instead of
> a seperated binding document.
> 
>  .../devicetree/bindings/mfd/google,cros-ec.yaml  | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> index 76bf16ee27ec..c76809cd9f7f 100644
> --- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
> @@ -127,6 +127,18 @@ patternProperties:
>      type: object
>      $ref: "/schemas/extcon/extcon-usbc-cros-ec.yaml#"
>  
> +  "^cbas$":

Not a pattern, put under 'properties'.

> +    type: object
> +    properties:
> +      compatible:
> +        const: google,cros-cbas

Blank line

> +    required:
> +      - compatible

Blank line

> +    additionalProperties: false
> +    description:

Make this 1st or at least before 'properties'.

> +      This device is used to signal when a detachable base is attached
> +      to a Chrome OS tablet.

This can't happen at runtime?

> +
>  required:
>    - compatible
>  
> @@ -180,6 +192,10 @@ examples:
>              interrupts = <99 0>;
>              interrupt-parent = <&gpio7>;
>              spi-max-frequency = <5000000>;
> +
> +            base_detection: cbas {
> +                compatible = "google,cros-cbas";
> +            };
>          };
>      };
>  
> -- 
> 2.31.1.295.g9ea45b61b8-goog
>