Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: r8m9em0NkVXxo5RcGBdGd0vmeSau9gh7sEjDnI38b383ogy3m6imq0MsExrACLyuRMvhNWi2fm
 AE9IsXnJAM/A==
IronPort-SDR: ru4crNMreHoXQpsxGuzZMkdEosvf9+r3cFUPGuvreADT9tP6nftbq1raPDbxxsb2etlBCuEIfz
 E+6gqYoUayfg==
Date:   Tue, 13 Apr 2021 19:10:22 +0300
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
To:     Daniel Scally <djrscally@gmail.com>
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        Yong Zhi <yong.zhi@intel.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Bingbu Cao <bingbu.cao@intel.com>,
        Tianshu Qiu <tian.shu.qiu@intel.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v1 1/1] media: ipu3-cio2: Fix referece counting when
 looping over ACPI devices
Message-ID: <YHXCboJUF1VuZiKz@smile.fi.intel.com>
References: <20210404181409.1451026-1-andy.shevchenko@gmail.com>
 <1ab48622-be85-f1d7-caa4-8b04a4727d5d@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1ab48622-be85-f1d7-caa4-8b04a4727d5d@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Mon, Apr 05, 2021 at 09:37:28PM +0100, Daniel Scally wrote:
> On 04/04/2021 19:14, Andy Shevchenko wrote:
> > When we continue, due to device is disabled, loop we have to drop reference count.
> > When we have an array full of devices we have to also drop the reference count.
> > Note, in this case the cio2_bridge_unregister_sensors() is called by the caller.
> >
> > Fixes: 803abec64ef9 ("media: ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver")
> > Cc: Daniel Scally <djrscally@gmail.com>
> > Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
> > Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> 
> Ah; thanks for catching those, I'm annoyed to have missed the
> acpi_dev_put() calls in particular
> 
> Reviewed-by: Daniel Scally <djrscally@gmail.com>

Sakari, Mauro, can this be applied as v5.12 material, please?

-- 
With Best Regards,
Andy Shevchenko