Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp3215753pxb; Tue, 13 Apr 2021 23:14:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxgTfWS+g/N1aIaGoMAfXCMyrt8ct4dqsnPJXoxzhpYQ/+iHvXS/9Rb3B4fQTEw8dp+8obY X-Received: by 2002:a63:7a07:: with SMTP id v7mr35485647pgc.26.1618380899228; Tue, 13 Apr 2021 23:14:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618380899; cv=none; d=google.com; s=arc-20160816; b=pZqaajiBIcYe0SDVIkbhlkAzhTM42vk9rwM+e1gCK1tMc/9PK+Axd3I/MY1tS+Wynj AVa9f7Ax1b86WniREB2XSr+e//2AgErQTgZmtMfdVSsg9LKD+VdKglXRFrHyw0kN55NR YDyPgTNpgcquvifZ+ac7LCBk+qqxygHbXOZJFt/jXM7rMvZhk4ETu3DVZ4tIyy0hKkNe 3iK0w9jb89Njl5JLXzCoIa5KeRPLpaFgWfXTy1jt7IGneybVKmBafrjn9UiML2v6odih LwU+cKPgUHcWYUA3AVXt9eEKCKEf3T5VRYYn6GfC6q1BCByNc9U+ffRnumd3av9ZX1kU zziQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=+hqJq34n0AnsS7Jg0uuwPsdCOG2bhe2hU36BXCgMW6s=; b=d8hUcNkE3DXGuN8mnGzS9leHDPGDTzv8nJdE2dLsiCC7Vi8J0YQ+xTFdD3I7Znj6Gl oVCRP/OjjntKPKAVKDxkOE26f2YOONEaqe2JwuKwNXJbpQ+0+Rb0gYWA9o+/YWdAgb5K stONnqgPjCYRRSDl59NBHugnpVBDAWH1Iz9+vhSSBdjtJWFdx3vMkDt0jRkwX6SIPVA+ rXcvqKcN2LNO1mnvPs8YMxbjRlJZlWR+HDlEHn5TzQGzzR2wRYxYwFc7JF1N4C6HsFVe 0dKyw5BZdASYZD7FTWgOyH8Li2zkILEYn1yHfRoYg4WO2dOEYpyID2esgNsN2z2A/MKH jRdw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e24si905380pgg.219.2021.04.13.23.14.46; Tue, 13 Apr 2021 23:14:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347936AbhDMSf0 convert rfc822-to-8bit (ORCPT + 99 others); Tue, 13 Apr 2021 14:35:26 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:48454 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347929AbhDMSfY (ORCPT ); Tue, 13 Apr 2021 14:35:24 -0400 Received: from marcel-macbook.holtmann.net (p5b3d235a.dip0.t-ipconnect.de [91.61.35.90]) by mail.holtmann.org (Postfix) with ESMTPSA id 84989CECCC; Tue, 13 Apr 2021 20:42:47 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Subject: Re: [PATCH] Bluetooth: btusb: fix memory leak From: Marcel Holtmann In-Reply-To: <20210413175208.GA560049@LEGION> Date: Tue, 13 Apr 2021 20:35:02 +0200 Cc: Johan Hedberg , Luiz Augusto von Dentz , "mark-yw.chen" , "open list:BLUETOOTH DRIVERS" , open list , kernel-janitors@vger.kernel.org, dan.carpenter@oracle.com, colin.king@canonical.com Content-Transfer-Encoding: 8BIT Message-Id: References: <20210413175208.GA560049@LEGION> To: Muhammad Usama Anjum X-Mailer: Apple Mail (2.3654.60.0.2.21) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Muhammad, > If btusb_mtk_submit_wmt_recv_urb returns error, wc should be freed and > then error should be returned to prevent memory leak. > > Addresses-Coverity: ("Prevent memory leak") > Fixes: 4cbb375e997d ("Bluetooth: btusb: Fixed too many in-token issue for Mediatek Chip.") > Signed-off-by: Muhammad Usama Anjum > --- > drivers/bluetooth/btusb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel