Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp3513910pxb; Wed, 14 Apr 2021 07:14:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw+uecelf8jH/ZuOCZFY2Q3p10osf6Kn6xKW7mJgXxTvDI1P1KtwkGaGf6xbSqjRu0JxLlZ X-Received: by 2002:a17:906:d795:: with SMTP id pj21mr18906641ejb.102.1618409653999; Wed, 14 Apr 2021 07:14:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618409653; cv=none; d=google.com; s=arc-20160816; b=E/+df7fpQ4gwuFaBUJoUMfUSIyj4yRLGtHFbVfsIxukXXrHGWDxFeccJH665OXnehj rfLrWjIOzwbQ2rim9ahH4QLETZ0H4Z4y53Cvk0ZiZRpm1vFkOS0arwcqmyhMKL7Wya0H sXFTedqprjngOyWIdjEJ9Q6oftY88ZXTaGo8ucsfzd5Eifq2ZGG+cI3v6MWzG3JwVmuL W+GzkL+VprKytrQ8vdNZjgFQn7m+QmI2IML1pw7naZyTglXcmLq4I9y/37nO6Q0+PoW0 Ej3I/YuabnzZiWiiOpH0w7337ZbFMoRwzdW5IZo+q+RrL29rN6l5MmzguJo+px0OHfZF w+AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=/CFTfILqfJh5uZk6ReeOGhwZDRZhRj/gI7BOPGIeuu4=; b=ZUZg5rP8nYgsoxOQQCZyh9UpJtk6IIUNpY3RofmDX/TbKsT/UC16L9tML/IQ44MKNY JCQwLG7Wzm/jlGRG/XK/ykm5WzeV5vIpDseRJLWiSPm99yAviNqCB5E17Atp2JyvpCDR eZ+XRXDTcHvmbLn7NKtL+PhPAaNFxfBdG3f9CCQRUQErsL5maHs8luSLdKMzjPjoWd70 BF/hJuBAr3HxW2Nq+0Ga9xg5XlviUvFtIf2GazOK/znKScv1ZT3ex1v/RV5teHgDyRnb Y12wpQWSo519OQyS5GECqHlTUY1kjBj83maf2hSob27dmxbaFwim42EZBApx9BFU2Rwq Hwog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ih3QkoGW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kj9si8760567ejc.391.2021.04.14.07.13.50; Wed, 14 Apr 2021 07:14:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ih3QkoGW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232600AbhDNHMP (ORCPT + 99 others); Wed, 14 Apr 2021 03:12:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231480AbhDNHMO (ORCPT ); Wed, 14 Apr 2021 03:12:14 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1229CC061756 for ; Wed, 14 Apr 2021 00:11:53 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id x19so1039540lfa.2 for ; Wed, 14 Apr 2021 00:11:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/CFTfILqfJh5uZk6ReeOGhwZDRZhRj/gI7BOPGIeuu4=; b=Ih3QkoGW6dkE+rXyOwP4ao/9lIPJbwBxfFDiITcYDglNyNW4ozmCUE6sM+j4hXhtmt 1mTyXcRZftRi3EipiP5sIRj+x/JukCRPAQiB7sZpnFsigQ2DxAa1NokHVweKb2MLi2r1 91+5Rmj2tlfk9wQJRusvqaa0+d63OxThayYY+9cCHLhehRTPbEaxKLnfM8R5gG1tlqor ACqJs5StaiB+ULWhBnL0if0KoglJmF9iN2VltskeaMx5X0cP0Aali/ptqcQ6ZwdP3rkb YafI1n/DOffqqkgIMd7WuVyzmWZpxmrmHgAvgBjwEWQOdlpY5m1os6yxIwiWOUe3mRzX yb3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/CFTfILqfJh5uZk6ReeOGhwZDRZhRj/gI7BOPGIeuu4=; b=R1Tc66frXLumiyHZY+f5H66ACM9hoXl6hG/p8LRlgBndGVa0tR6dQGZGNhGnA82JEf QDzk8sVspDq4PjiQgo3VifcvNiy8swIMhVoEm4PKNuvSyOzhUAggtEU8YrMItlCsn3me gUfuCawLqbaA1mGwUGMVgAPqa8CHvp6yYEVgSFpxQ/VdcK2YuZoD0p/fVY5AV2UFLXRB H6wQ3PxB0vZ3Se+IXbQJuH4Y9g8vJg2KZS140u1D0Qv/wS9HnlfGsWwCdj5pPLstmGup lD5aC1or3Zynl/BJUpyGM0tJfbjTunaO6v9PC8vwOsLXPuRGSY1IBIocLE5m78/gvtPV yg9Q== X-Gm-Message-State: AOAM530NAVHxSiUEyQpsJaUz1GIYtMva6r3dnxyCcC0j2BmRmI7QYhc+ F7r5E1RocysDi1DahzQE4bt8LJCOshXRjCx4PEPlZw== X-Received: by 2002:ac2:529c:: with SMTP id q28mr13761428lfm.586.1618384311564; Wed, 14 Apr 2021 00:11:51 -0700 (PDT) MIME-Version: 1.0 References: <20210414025138.480085-1-julianbraha@gmail.com> In-Reply-To: <20210414025138.480085-1-julianbraha@gmail.com> From: Linus Walleij Date: Wed, 14 Apr 2021 09:11:40 +0200 Message-ID: Subject: Re: [PATCH v2] drivers: pinctrl: qcom: fix Kconfig dependency on GPIOLIB To: Julian Braha Cc: Bjorn Andersson , linux-kernel , "open list:GPIO SUBSYSTEM" , MSM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 14, 2021 at 4:51 AM Julian Braha wrote: > When PINCTRL_MSM is enabled, and GPIOLIB is disabled, > Kbuild gives the following warning: > > WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP > Depends on [n]: GPIOLIB [=n] > Selected by [y]: > - PINCTRL_MSM [=y] && PINCTRL [=y] && (ARCH_QCOM || COMPILE_TEST [=y]) > > This is because PINCTRL_MSM selects GPIOLIB_IRQCHIP, > without selecting or depending on GPIOLIB, despite > GPIOLIB_IRQCHIP depending on GPIOLIB. Having PINCTRL_MSM > select GPIOLIB will cause a recursive dependency error. > > Signed-off-by: Julian Braha Patch applied. Yours, Linus Walleij