Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ocfs2/dlm: remove unused function
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, mark@fasheh.com,
        akpm <akpm@linux-foundation.org>
Cc:     jlbec@evilplan.org, ocfs2-devel@oss.oracle.com,
        linux-kernel@vger.kernel.org
References: <1618382761-5784-1-git-send-email-jiapeng.chong@linux.alibaba.com>
From:   Joseph Qi <joseph.qi@linux.alibaba.com>
Message-ID: <d5e3ba19-abac-891d-9e88-6d3a0cef931b@linux.alibaba.com>
Date:   Wed, 14 Apr 2021 19:44:40 +0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <1618382761-5784-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 4/14/21 2:46 PM, Jiapeng Chong wrote:
> Fix the following clang warning:
> 
> fs/ocfs2/dlm/dlmrecovery.c:129:20: warning: unused function
> 'dlm_reset_recovery' [-Wunused-function].
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Seems after commit ded2cf71419b ("ocfs2: dlm: fix recovery hung"),
dlm_reset_recovery() no longer has any user.

Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com>

> ---
>  fs/ocfs2/dlm/dlmrecovery.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c
> index 4b566e8..afc5173 100644
> --- a/fs/ocfs2/dlm/dlmrecovery.c
> +++ b/fs/ocfs2/dlm/dlmrecovery.c
> @@ -126,13 +126,6 @@ static inline void __dlm_reset_recovery(struct dlm_ctxt *dlm)
>  	dlm_set_reco_master(dlm, O2NM_INVALID_NODE_NUM);
>  }
>  
> -static inline void dlm_reset_recovery(struct dlm_ctxt *dlm)
> -{
> -	spin_lock(&dlm->spinlock);
> -	__dlm_reset_recovery(dlm);
> -	spin_unlock(&dlm->spinlock);
> -}
> -
>  /* Worker function used during recovery. */
>  void dlm_dispatch_work(struct work_struct *work)
>  {
>