Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 14 Apr 2021 17:43:19 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Aswath Govindraju <a-govindraju@ti.com>
Cc:     linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-phy@lists.infradead.org,
        Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>, linux-can@vger.kernel.org,
        netdev@vger.kernel.org, Vignesh Raghavendra <vigneshr@ti.com>,
        Lokesh Vutla <lokeshvutla@ti.com>,
        Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [PATCH v2 0/6] CAN TRANSCEIVER: Add support for CAN transceivers
Message-ID: <20210414154319.knn323wo6vi3t2dp@pengutronix.de>
References: <20210414140521.11463-1-a-govindraju@ti.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ls64vuqf5liwgxeq"
Content-Disposition: inline
In-Reply-To: <20210414140521.11463-1-a-govindraju@ti.com>
Precedence: bulk


--ls64vuqf5liwgxeq
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 14.04.2021 19:35:15, Aswath Govindraju wrote:
> The following series of patches add support for CAN transceivers.
>=20
> TCAN1042 has a standby signal that needs to be pulled high for
> sending/receiving messages[1]. TCAN1043 has a enable signal along with
> standby signal that needs to be pulled up for sending/receiving
> messages[2], and other combinations of the two lines can be used to put t=
he
> transceiver in different states to reduce power consumption. On boards
> like the AM654-idk and J721e-evm these signals are controlled using gpios.
>=20
> Patch 1 rewords the comment that restricts max_link_rate attribute to have
> units of Mbps.
>=20
> Patch 2 adds an API for devm_of_phy_optional_get_by_index

You probably want to split this into 2 or even 3 separate series. The
first one would be patches 1+2 then 3+4 they can go via the phy tree.
Patches 5+6 can go via linux-can-next

> Patch 3 models the transceiver as a phy device tree node with properties
> for max bit rate supported, gpio properties for indicating gpio pin numbe=
rs
> to which standby and enable signals are connected.
>=20
> Patch 4 adds a generic driver to support CAN transceivers.
>=20
> Patches 5 & 6 add support for implementing the transceiver as a phy of
> m_can_platform driver.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--ls64vuqf5liwgxeq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmB3DZQACgkQqclaivrt
76l7xQf9EU/0dxjIIELdncw7YgkbG5MzMjxlZsTwehF/S7YPFD+SrhSE33kjSFr/
yan8/T+N6Gg3fSsLFQxpw3E5w2i5+0d2UjFErypXkUrLsTgT0d1rjKgywvakE7lj
+4hn33gfbCEK3Nx7vdDsZTbjmPpkXuCgrZKuFhvC8mtVTVMLC2p9hxdpvpzD7pOL
AmQJJwLv3ubkD2PUihd1Tbj1xbVK0vKtOFeGBCi4qE/EIdJMSldDvFkC9+6525pN
XXB7gAkAO/GGx+rkfmyV36bj97nfyoVoNGFjdPPY+VtIAiL7Vg8xBuXL7O7Eod70
AqwTVUnL6UCnpbH4gqtjjkock/G82w==
=kqEi
-----END PGP SIGNATURE-----

--ls64vuqf5liwgxeq--