Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp170578pxb; Wed, 14 Apr 2021 12:09:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEcPnA9bI5nSsLu9nLSrK79YAddiMnccVMHThyL9XENN4sG3tl3+wdY7ra6F01cmD0Zb+J X-Received: by 2002:a63:ff22:: with SMTP id k34mr5160611pgi.336.1618427368857; Wed, 14 Apr 2021 12:09:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618427368; cv=none; d=google.com; s=arc-20160816; b=Jjm5w+X782uMtP5Oc8+khS7wOU57Y3qpSoonr8JEOydFdHiCX4AM0eOdu+gq5KzQCl WG04dusTgUTVnItPgH7+0SAVN40dU5trQ9u0ykxy1ZqgGXqtjeFFNwwlVCuTt9fWuRm8 vIWVcSwErhR9wdcmPElXiozG3TNw6+m5woGYa40XI3x7l/M4gWtnuQ0TenevnEpfUkON EmhJNI53tgq/A1lXPyJJa3VMbVfH0lOGtIj1YBCBgPbW/ZpxHqmr45JSn85fVxWAT5b5 MgzWU30W4XvNR+WGW9cnrJLKq5oIhva6hn4QudYcbSiKnGcwCtal5emUgtWA1kc5qAxn 53pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:to:from; bh=R1T1geunjnX2kLKdexsA3aYAIMgBrMvqHfbhXTdNjdA=; b=Yd6n6dBzaeEyC7oPnGWzu6Yz0p8AukAB+Z75Ckcti1z0FFxqndq17c4rCekN3xmHCh BTvPlhykv3fGNT0hxE5knKJ9+c96GX1N9SD8o8h+B+aGIMikFIQ3cBSz8sBR77qxZYS8 nTrYxfpZxIgWX7VkJfOztocLk00YFsUodieAKxK0ph7r0GyhFajvhzsqZiHL1C/QDCLL izc9uDCmp3nWekWwoJ6zaMhzSC3wAYZ9RRBbm7FX5aVm+lEWgjV4LuTDZ3SmyIHyGw3U L/bKtG+q9PegR7687ztQ1Ab/VqBy4xywdZSvvM5Ed8gMeLe8Z5MvKoHtH67SiekGnXvj mArw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o17si389268pgu.586.2021.04.14.12.09.16; Wed, 14 Apr 2021 12:09:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349357AbhDNGtE (ORCPT + 99 others); Wed, 14 Apr 2021 02:49:04 -0400 Received: from inva020.nxp.com ([92.121.34.13]:42824 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349338AbhDNGs7 (ORCPT ); Wed, 14 Apr 2021 02:48:59 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 6B0801A3EA1; Wed, 14 Apr 2021 08:48:37 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id C9CDC1A41FA; Wed, 14 Apr 2021 08:48:34 +0200 (CEST) Received: from localhost.localdomain (shlinux2.ap.freescale.net [10.192.224.44]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 2B4EE4031C; Wed, 14 Apr 2021 08:48:31 +0200 (CEST) From: Shengjiu Wang To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 -next 1/2] ASoC: ak5558: correct reset polarity Date: Wed, 14 Apr 2021 14:33:43 +0800 Message-Id: <1618382024-31725-1-git-send-email-shengjiu.wang@nxp.com> X-Mailer: git-send-email 2.7.4 X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reset (aka power off) happens when the reset gpio is made active. The reset gpio is GPIO_ACTIVE_LOW Fixes: 920884777480 ("ASoC: ak5558: Add support for AK5558 ADC driver") Signed-off-by: Shengjiu Wang --- changes in v2: - split the patch to two patches. sound/soc/codecs/ak5558.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/ak5558.c b/sound/soc/codecs/ak5558.c index 8e4dca753f0b..f24d91b728dd 100644 --- a/sound/soc/codecs/ak5558.c +++ b/sound/soc/codecs/ak5558.c @@ -323,7 +323,7 @@ static void ak5558_power_off(struct ak5558_priv *ak5558) if (!ak5558->reset_gpiod) return; - gpiod_set_value_cansleep(ak5558->reset_gpiod, 0); + gpiod_set_value_cansleep(ak5558->reset_gpiod, 1); usleep_range(1000, 2000); } @@ -332,7 +332,7 @@ static void ak5558_power_on(struct ak5558_priv *ak5558) if (!ak5558->reset_gpiod) return; - gpiod_set_value_cansleep(ak5558->reset_gpiod, 1); + gpiod_set_value_cansleep(ak5558->reset_gpiod, 0); usleep_range(1000, 2000); } -- 2.27.0