Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp177653pxb; Wed, 14 Apr 2021 12:20:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzg1n8zPr12gxQI3oOQ1iIoSr89LFLbCBk5QJKjuDERBYn+9DTGbsNFlhgm+FgSXpRkC3AQ X-Received: by 2002:a17:906:c7ca:: with SMTP id dc10mr420463ejb.294.1618428053215; Wed, 14 Apr 2021 12:20:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618428053; cv=none; d=google.com; s=arc-20160816; b=ihI8TXJhWkdzO/3kFWXWaHuHCEHuDrkCexLaVMnFE7RMV0JUGycG2XH5ue+UaHa1Ta VGwX7WPPXon9jyp1s9Fmk8bjQfZ87JFyyEtQaQlWARGSXkxX8+mjuerpH2mQjFXjtW5m LgKHWx1u99RK+qSClXUh0z1UfgPhckxzl8bxP6svzF1/SpTRaAQw9QtIH7CI7wfOyF6K AdqIZB/J7Uc20yvARnkP4cvS/NeYV2dm31c2H5FWl/DArLfBUUGdD01Y8YCTtFeArBNT pJTEsRxVeHWkgt0PGa88gPlAgl4TK39r2AGgfWnntZT+5nIIO2vRW+DV9pxedM+b80fN ZJGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=n7+3QnJX09xtUiZLgT6asa5+Q/TRuyToSsXTxo7gGCU=; b=E7AG7ukLD8+AE4RQyKDYQdzjzpN2DslD5FDLpaLbh3C/UHgesUsmixjq8saXgIg2G2 hzQxWig6HEuVC2SlPik0KmO2J+Tp4g1HVi0zqxyFlQWso5zDQi8YIwinBdZGu6ghKlsP B091FS2o6SahXYsukOMwonPPGBOFBSMlCK+6NIa9mXfza+T5grtQ6XIgugqff+7gF2l+ +KUHRdrPdcV0xmC3bCi6HIykZ6ZXZcVA3hBj+XLi/57iMxK0eqxMBX/HRaWu1xJPVTIG reTCBI+BRn6OuZCcwjsfs5AVPy3jPnOfFifxjNs3eVh/4+Z6e/+v3XoYxQC70Kc5mXke MX7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=d4jaPQmI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r13si346018edw.386.2021.04.14.12.20.30; Wed, 14 Apr 2021 12:20:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=d4jaPQmI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345326AbhDNGmB (ORCPT + 99 others); Wed, 14 Apr 2021 02:42:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:41182 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232403AbhDNGmA (ORCPT ); Wed, 14 Apr 2021 02:42:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E2CDC6120E; Wed, 14 Apr 2021 06:41:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618382499; bh=kA8zOgdDuts/SjL+HhXf1S6TGSm7w76OyzQRoZXsuFY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d4jaPQmIJT2wWYTgZX2W1xgXbF3Kuwhz1fUFxu7OMfRZDLjJdAyCBOQffWnZpbZ7S f/XC9+6Sgvt2QcL4Zks0/4rFGbOXv5PV0QaVmcM6yYr7p7Aotzn9s/BreAbiF+ux8Q tC1mpZl1xDMjTUmtlo0mnYZpAloE6cIP9bwddcSc= Date: Wed, 14 Apr 2021 08:41:35 +0200 From: Greg KH To: Saeed Mirzamohammadi Cc: saeed.mirzamohammadi@oracle.com, stable@vger.kernel.org, Camille Lu , Lu Baolu , David Woodhouse , Joerg Roedel , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5.4 v3 1/1] iommu/vt-d: Fix agaw for a supported 48 bit guest address width Message-ID: References: <20210412202736.70765-1-saeed.mirzamohammadi@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210412202736.70765-1-saeed.mirzamohammadi@oracle.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 12, 2021 at 01:27:35PM -0700, Saeed Mirzamohammadi wrote: > The IOMMU driver calculates the guest addressability for a DMA request > based on the value of the mgaw reported from the IOMMU. However, this > is a fused value and as mentioned in the spec, the guest width > should be calculated based on the minimum of supported adjusted guest > address width (SAGAW) and MGAW. > > This is from specification: > "Guest addressability for a given DMA request is limited to the > minimum of the value reported through this field and the adjusted > guest address width of the corresponding page-table structure. > (Adjusted guest address widths supported by hardware are reported > through the SAGAW field)." > > This causes domain initialization to fail and following > errors appear for EHCI PCI driver: > > [ 2.486393] ehci-pci 0000:01:00.4: EHCI Host Controller > [ 2.486624] ehci-pci 0000:01:00.4: new USB bus registered, assigned bus > number 1 > [ 2.489127] ehci-pci 0000:01:00.4: DMAR: Allocating domain failed > [ 2.489350] ehci-pci 0000:01:00.4: DMAR: 32bit DMA uses non-identity > mapping > [ 2.489359] ehci-pci 0000:01:00.4: can't setup: -12 > [ 2.489531] ehci-pci 0000:01:00.4: USB bus 1 deregistered > [ 2.490023] ehci-pci 0000:01:00.4: init 0000:01:00.4 fail, -12 > [ 2.490358] ehci-pci: probe of 0000:01:00.4 failed with error -12 > > This issue happens when the value of the sagaw corresponds to a > 48-bit agaw. This fix updates the calculation of the agaw based on > the minimum of IOMMU's sagaw value and MGAW. > > Cc: stable@vger.kernel.org > Signed-off-by: Saeed Mirzamohammadi > Tested-by: Camille Lu > Reviewed-by: Lu Baolu > > --- Also when you resend this, please state the commit that this fixes, as this must be a regression, right? What kernel version did this previous work for? thanks, greg k-h