Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp178348pxb; Wed, 14 Apr 2021 12:22:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw+VnWGR27W6zztft9hkFQ0OJVEJAqZq7Jh/vCnfneBIBnz4hRdtEL4wFhIHhshmutXNDHf X-Received: by 2002:a05:6402:30ae:: with SMTP id df14mr470768edb.97.1618428127380; Wed, 14 Apr 2021 12:22:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618428127; cv=none; d=google.com; s=arc-20160816; b=I3Qi9GQ05GMNhgYQ+WWXgqmqA7jcxlxBN5D1DRhBDYvK9A4BjBwQhtu69pYTZKkPaO DBeFigY2gfg79dK8iEI2IgNsuhmqZPxG+IxBv0XD4pFDNR4mhfsLjJVt2FQKE77YlrNm bPzpl1XnYYzDLCj3b5EyIxLx7sX3XBO3XipuPEMW1ULsF4Y7uc9183r6sk4IjSv4oBWb K1FhbZ6P8qxGuaZ8slhu6YNg7ovVoEsgbojH2RtveX/aUa3Knsz8prei9tF50VLtgoFT 7Ce3qd/cSJnxnNs2NQJerrQ7l0C4kyVDyBaswLLtlgJLSbEr+it03FETYO2RMgg7KQPq mOIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=64gjXIhv/+g283uK3HI1Fy6VCqL/A34oMNdA2BrGOz4=; b=T30HeUCBB0xzGATaifP+jAgmwx/FVbnsiDCPG10wugZ/uCi6AfNTrWw7iRuL8hEG1k M95xkLYf9fuwI86VmprrKyDMPBa6hhVjfYrTF9oNjmrjgmSQ/5OnQ5M+5nyvMN6BsJrS 2vx986rGxwfymddOOpiW9IchG6MqPRxzlGjByVJ1NZ+3ILabmY4rk3LN1SI54wXaAeGl OV2Ad6C8pCeqrDrMTGEGntDaMsJKEvwzc3pco8mO+pi02LI2TFU8kaYbBazSK5bYwzpP ZMTQovLiFDmw9qB/iyBnP2NGB8+maltl6GxITMGzlmrTmQNy8IqwPh0kFcXDZulu+toO SelA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@who-t.net header.s=fm2 header.b="SMaCRGz/"; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=kmSpfRPs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dm10si210274ejc.418.2021.04.14.12.21.44; Wed, 14 Apr 2021 12:22:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@who-t.net header.s=fm2 header.b="SMaCRGz/"; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=kmSpfRPs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349315AbhDNGrQ (ORCPT + 99 others); Wed, 14 Apr 2021 02:47:16 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:32783 "EHLO wout1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348255AbhDNGrP (ORCPT ); Wed, 14 Apr 2021 02:47:15 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 2787B177F; Wed, 14 Apr 2021 02:46:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 14 Apr 2021 02:46:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=who-t.net; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=64gjXIhv/+g283uK3HI1Fy6VCqL /A34oMNdA2BrGOz4=; b=SMaCRGz/2atN6NqYrJ7F7wtHeKeBu0pQtw6+0+gxgrv jNqGUiEsy9osUhvQazpqF2fAcobI4KnuqEWNBgPfyKGpkBtICKwziz398aDmFxzm u7gidnodlPnFNrVdsAIAfQNWAYC00b0OCWGnJ5A02WVuJIJsCzXo1fZkWNLtUsf/ XRapJVw1mBCRMgQLUlVCoKVb/szbct8avqt1lc+QuHRq37yyvMuu6Esw8CDovf38 jxM7c6MZECEefHH5sfVT581pvi/7y+/vdCRcs0GrHqbIgEE6c9GFhbs91cvKQC0L 9pFn6la4Zb2Dr/qno7G6U5A7TmnPcXVIB9BEF75vCrA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=64gjXI hv/+g283uK3HI1Fy6VCqL/A34oMNdA2BrGOz4=; b=kmSpfRPsS/4s5V9AxcP3tq 6O0I+QZfYcEC9/0B+V8P8lznnN82Q/flYNTwhFkfetilxr/zlAnt5Zxl1SsXNE5F IWNJXtZsRDPvWUS/OzYWHoGwImEX0+spE0nmyl2jUsPviNz0YG5pqaZA5P/pJonb 1Qj7KNLrNGH8H5poklrRVzMTEZXh/mc2Hz5yipbK7ClREB8taIOsw/sif/YKUHuG eu6pYbXaXfY2/Zq3/sc5R9CPyxzJMXNpHlMaYPuKKcTOtcg422Lj9XRkGNCuw/2K gnNZuuLFXTj/XTVPPKmoXUoa29CP6zRUwT/GmM4w0PSyJjAAUE18s0DquDOVkF2Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeltddgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomheprfgvthgv rhcujfhuthhtvghrvghruceophgvthgvrhdrhhhuthhtvghrvghrseifhhhoqdhtrdhnvg htqeenucggtffrrghtthgvrhhnpeehhfehfffgheelgeeuudelhefgvdefveekudevjeev jeevvefggefguddufeeuveenucfkphepuddujedrvddtrdejuddrvddvkeenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrdhhuhht thgvrhgvrhesfihhohdqthdrnhgvth X-ME-Proxy: Received: from koala (117-20-71-228.751447.bne.nbn.aussiebb.net [117.20.71.228]) by mail.messagingengine.com (Postfix) with ESMTPA id E271524005C; Wed, 14 Apr 2021 02:46:50 -0400 (EDT) Date: Wed, 14 Apr 2021 16:46:44 +1000 From: Peter Hutterer To: Dmitry Torokhov Cc: Giulio Benetti , Rob Herring , Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , Henrik Rydberg , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 3/3] Input: add driver for the Hycon HY46XX touchpanel series Message-ID: References: <20210413144446.2277817-1-giulio.benetti@benettiengineering.com> <20210413144446.2277817-4-giulio.benetti@benettiengineering.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 13, 2021 at 10:44:07PM -0700, Dmitry Torokhov wrote: > Hi Giulio, > > On Tue, Apr 13, 2021 at 04:44:46PM +0200, Giulio Benetti wrote: > > + > > + input_mt_report_pointer_emulation(tsdata->input, true); > > For touchscreens it does not make much sense to report BTN_DOUBLETAP, > BTN_TRIPLETAP, etc, events (they are really for touchpads), so I changed > this to > > input_mt_report_pointer_emulation(tsdata->input, false); > > to only report ABS_X, ABS_Y, and BTN_TOUCH, and applied. Can you expand on this please, just to make sure I'm not misinterpreting those codes? Those bits are just for how many fingers are down (but without position), dropping those bits means you restrict the device to a pure single-touch screen. Or am I missing something here? then again, MT support has been in the kernel for long enough that by now everything should understand it, so there's a certain "meh" factor. Cheers, Peter