Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp214626pxb; Wed, 14 Apr 2021 13:26:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz8eojaoq8NX4vPqu+wY3q2j8PbIMz0OPew49D1m9uLl4zLv9qWRtqVx5S0Kv+Rpw0DhS6G X-Received: by 2002:a17:902:e9c4:b029:eb:4626:feba with SMTP id 4-20020a170902e9c4b02900eb4626febamr7607373plk.39.1618431989249; Wed, 14 Apr 2021 13:26:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618431989; cv=none; d=google.com; s=arc-20160816; b=pvlD2Zqm8P2LNvprpFj8SnQ5BQygN/bf4LqWuGr+NdJwybu03Nzbgx6zLOvObPfnSZ swfiqNaOO0WhDb/NWPnoHVkt5xgn4wo6MH+qN5O5NQyKHM4BCH9cj21zqkuhkA5PClAf fvKR1r2hz0UsKLbK7UBLEjFMgFxPszB0bmK51cFy1eE2L9snKgqWsw0VRgkNEpo/ZDYg 3wMeE1BYDyv/Uoha90v+2NuiMWCR9casU3w1LgiIMg8o9p67mn39mrctkGKj91Q0numK w5uhqk/Eex7WfpJvXueouYatXLDo8oE1t79eCvjebeRBBWcRozVcj759nUdTLz0KCY24 UqkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=A17+YvYKeT74dwM5NvpYH2hMlwLgSEqUmsE8h5iCq7E=; b=tqJgouewgNqJmQf+M2cggPGNfQTYB0JZdZwxT4tStIBx7D54ZpAlGZQQNVnolXgM+t /f4u1JzfPxg3OvkfOW7h3xeAQCaHFKCjvyPc3xybl+Mn5trtMZpn3r9CucD5RdQhXBSW ihAeguQMmRS5xisaLJ/Cof7543/Csk7WuIuc6TdZf+XcLQgGCQI80TobN6/P30l28jDo lEPvtuqjtZ6oD+/7B0tE0xK9xVV6SB4d89wDRamF0uOWC7r2nsA7UORqe4iWHDsLEQWd wApQMn5RlQX9wEpPBafdCivAX7BuIfZZfVQ2lyqFlLx57EIPr8EKaUeHAW+EjquA/wTn Yg6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fSX6jBuL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v6si742371pjr.166.2021.04.14.13.26.16; Wed, 14 Apr 2021 13:26:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fSX6jBuL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349842AbhDNIB4 (ORCPT + 99 others); Wed, 14 Apr 2021 04:01:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:53410 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349824AbhDNIBn (ORCPT ); Wed, 14 Apr 2021 04:01:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BDCCF601FE; Wed, 14 Apr 2021 08:01:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618387282; bh=A17+YvYKeT74dwM5NvpYH2hMlwLgSEqUmsE8h5iCq7E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fSX6jBuLw2uXn3nPd1pScagSSVO6HZLk44dMSHJEMQpzlA1praHv3HMbQAJwVMAVv as1vgm/DByYWPi+HxzMxsVLUA2w6PY5EMa/CmRk2rd6kQomag4VTCCkYQbN2sCeTHC /WUxn/YdBgcamrNoIBiyEHhR/2n4PFDnOSeHK8ZRhO5VlUI9IoZI9otcw7xBU+q5qj yTn0bwEpndUH/jkQ87Uw9UclAygJ22IkyekBbMOwacRf2uwVAUUQTIDKHc9a3bs14y TiM/gv8fBqOIPrSGdA5HDPa3/c0M/t+VAAdRXCRFJxD5CV0jSZFZT9FDG9/KoZi4sl vyOKBTY0jGlYw== Date: Wed, 14 Apr 2021 10:01:19 +0200 From: Wolfram Sang To: Li Huafei Cc: vigneshr@ti.com, tony@atomide.com, aaro.koskinen@iki.fi, linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, yangjihong1@huawei.com, zhangjinhao2@huawei.com Subject: Re: [PATCH -next] i2c: omap: fix PM reference leak in omap_i2c_probe() Message-ID: <20210414080119.GH2180@ninjato> References: <20210408125648.136519-1-lihuafei1@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vkEkAx9hr54EJ73W" Content-Disposition: inline In-Reply-To: <20210408125648.136519-1-lihuafei1@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --vkEkAx9hr54EJ73W Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 08, 2021 at 08:56:48PM +0800, Li Huafei wrote: > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. Fix > it by replacing it with pm_runtime_resume_and_get to keep usage counter > balanced. >=20 > Reported-by: Hulk Robot > Signed-off-by: Li Huafei Thanks, yet I applied this series now: http://patchwork.ozlabs.org/project/linux-i2c/list/?series=3D217733&state= =3D* --vkEkAx9hr54EJ73W Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmB2oU8ACgkQFA3kzBSg KbajnQ//YhDJxuRkElFaaDkaZtFneMSAu9lzddsixSEr6XBiuFq7fOMtQFuO1KX0 phbObJkYzN5ZmS4Ew3qr+pEjY3xcpSyEevtUbDHsTFeiyXkosestDcMDHuwsAvi1 DEIf2kk985o91ficI186zA5xl+4lEccpuQXw/oJHmupT+4vtCUe92DOEuhjHHCPQ uINfCdGxGsK7tOdIS3ErwKCuCbdgQdde8vcyY7KvhPWMRDUC9hTBqXphRDMkHI6y XzVS6VC64PfiU873IcarwtFuXmPtwA2u/9PMBCLeON7/XP2cKUScb8WoY0TA4Yi4 Y7JVpwYvPgxcB/FVhN1X3OY64cjt1xZYnG/E5bctGkFmRC0F0ghVVypbOIPxwbX4 U6twNKfWUSjpMRPzqlfC3FfgOxYugidhdUGZf16zA0TfqVS70lbgyDzCUfLFjv++ 5n6lICh9M7tcr4bPTRbQq0ZVH4sUCnUM7EAgaHhK4zRMSsf9GhT7eJUcwHxs/9gD 0ctHQBtMQZLnxp1ewitC2zRGZMyaUJORIpcdlchZtvuJCzZ71WwmncJcujVG1CCi ghakMnyhbcWp2x9Kd40Pl6scLGxILQqGdgR/53t3H/lk2SLOUlZKYTMw4+k7L6/s wQt4splKRzhzml0zKHquWgRDYS3c2fE7WizjM6n+uXhbWTszfEc= =/cPS -----END PGP SIGNATURE----- --vkEkAx9hr54EJ73W--