Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp239525pxb; Wed, 14 Apr 2021 14:12:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjh/JFkdJX2FujF+xNi/K9Hc2n5i/tlmevSR8yFHVtiyINj7ell4pQthwB3VCg6NJj0EmD X-Received: by 2002:a17:906:c09:: with SMTP id s9mr45746ejf.145.1618434755547; Wed, 14 Apr 2021 14:12:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618434755; cv=none; d=google.com; s=arc-20160816; b=HurS4oJgKGxsALMREztTRIgaBjD5qPBl9q8nu7It2VVf3MW5TTvcnKZf71X23Z8iBV U9zpbFNmoyXiNCWl6KvZzCfkiJMEdogEM/bmhlzSB97bLVH0+xqZu6JiGbpTtU/XQhYL uU6breeQBYIvE2EhcqRpk2Md74yWGr0zgw8brJh1jaaVta8XYdF8pSKj6MM619S+F6fG oc1a9EElGrZMZzzw5wqAzZk8w97GSEDLY36nQzNKND3AOIj61/CrF/c/iWusUQjAy8IK gTmt9XGRaT3Z4Gb1k3XBicMTmd6alTJRTN0nxVenDhIVmT2RsKYYeJT2lEZt9lY6FBAV kQgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=fS/iMC+2RLWWnTdGUm5WaXPKK8dicJ3b0eXSS5YLLkg=; b=SGk+Vdo5ulb6s/JAROo0VEvtuI9fZr5Gy3XHhJpXMrzivMEsItJkk+HTNhw0BKRfrM YA4uHWQctKCUHFNx1zVymXYMmvlJ8ClPFO05K+M8i6k3L+7IzgNwgwONKc0C/OO8KdPp +/FXv55X+ANLaKZC2Hb8/PRLG76iouCnHWUYkZLFt1I0/fkf0y2m6a16q0THx4zDSESl G8+Z1y101bAibGk4j/Hvk6kVzHoxf+HMpNNCFu2DezmWZeUYiqlrWcrKSAjeyOwJKAH4 X0NlRNNGxkeGchTSpQokMJGo0RBtU/I78QxCTfW9QT9Qn7vP6p/FmFLVi6VuRZftJ57E vNtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=q2bdX1gf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o19si584579edv.160.2021.04.14.14.12.03; Wed, 14 Apr 2021 14:12:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=q2bdX1gf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231895AbhDNI0H (ORCPT + 99 others); Wed, 14 Apr 2021 04:26:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:43664 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229467AbhDNI0G (ORCPT ); Wed, 14 Apr 2021 04:26:06 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EF256613B1; Wed, 14 Apr 2021 08:25:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618388742; bh=0gCby2KW5PmeDy4G/e/A5rV0irl5mDAIJanXOzBp1NE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q2bdX1gftwlU3QQyRQO2IgsuEkyFKQbh/fWiaUq591BUm1so9MDjLVz5x8bS/9PiU ybyfS6D5YEEuTM7wUN2nZjpvS2gfOr1Dej9yGMJ7fgzEQUm4kFOLw56f0RHsx7agBA 0zkHcPUz6MKl8XA0LfuEuW/B3yTnCPacTAsg9ghU= Date: Wed, 14 Apr 2021 10:25:40 +0200 From: Greg KH To: Fabio Aiuto Cc: julia.lawall@inria.fr, joe@perches.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] staging: rtl8723bs: put a new line after ';' Message-ID: References: <7e796fe7a5a370d055be201204dcac14f09c974a.1618325614.git.fabioaiuto83@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7e796fe7a5a370d055be201204dcac14f09c974a.1618325614.git.fabioaiuto83@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 13, 2021 at 04:56:33PM +0200, Fabio Aiuto wrote: > fix the following post commit hook checkpatch issue: > > ERROR: space required after that ';' (ctx:VxV) > 232: FILE: drivers/staging/rtl8723bs/core/rtw_odm.c:160: > + "AdapEn_RSSI", "IGI_LowerBound");netdev_dbg > (adapter->pnetdev, > > This was coccinelle script output coding style issue. > > Signed-off-by: Fabio Aiuto > --- > drivers/staging/rtl8723bs/core/rtw_odm.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_odm.c b/drivers/staging/rtl8723bs/core/rtw_odm.c > index 084f6ae040ee..f4a0ef428564 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_odm.c > +++ b/drivers/staging/rtl8723bs/core/rtw_odm.c > @@ -157,14 +157,15 @@ void rtw_odm_adaptivity_parm_msg(void *sel, struct adapter *adapter) > > netdev_dbg(adapter->pnetdev, "%10s %16s %8s %10s %11s %14s\n", > "TH_L2H_ini", "TH_EDCCA_HL_diff", "IGI_Base", "ForceEDCCA", > - "AdapEn_RSSI", "IGI_LowerBound");netdev_dbg(adapter->pnetdev, > - "0x%-8x %-16d 0x%-6x %-10d %-11u %-14u\n", > - (u8)odm->TH_L2H_ini, > - odm->TH_EDCCA_HL_diff, > - odm->IGI_Base, > - odm->ForceEDCCA, > - odm->AdapEn_RSSI, > - odm->IGI_LowerBound); > + "AdapEn_RSSI", "IGI_LowerBound"); > + netdev_dbg(adapter->pnetdev, > + "0x%-8x %-16d 0x%-6x %-10d %-11u %-14u\n", > + (u8)odm->TH_L2H_ini, > + odm->TH_EDCCA_HL_diff, > + odm->IGI_Base, > + odm->ForceEDCCA, > + odm->AdapEn_RSSI, > + odm->IGI_LowerBound); > } > > void rtw_odm_adaptivity_parm_set(struct adapter *adapter, s8 TH_L2H_ini, > -- > 2.20.1 This patch should not be needed, your commit that caused this error should not have done so. Please fix that instead. thanks, greg k-h