Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp244319pxb; Wed, 14 Apr 2021 14:21:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwp2Oz0uUktsYc25qvu7a3UaXUrznV7Tf4JHWB0l66Vio+OkfPBtQ8o8eGxqelZlAnhflnV X-Received: by 2002:a17:90a:ba05:: with SMTP id s5mr150698pjr.194.1618435286115; Wed, 14 Apr 2021 14:21:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618435286; cv=none; d=google.com; s=arc-20160816; b=FaAFUrOe/GFteWvuJufmazmlHNSvl4Zml3KGcYDP+9frd8Gj/KnNW4G6aIZsQfIpxA d9RlAEVZBRg4UhvZAFr40Wud+QF/1ZcobCUMIc4ylpr+NoK+oWZi5cvQb/DU1JFhSIh6 h0g5p/6FGTrVpvVt3+hQUGjaa95vGy/BtTXX9jWV98XvBze/nwEMl56eSNjd0Llq0Hoq uimW29VVQUHfTa/R28E+L/7ZzyaoDYyV4ngM56VTIlvx2Wn8Q5vqbNOq1eJU+GF/BrsN /Cplrh5BTHhFgBl6h56yAbp5Fuce5svpXygOcaRlBnnq1xuNnAwgPAYEAauLI50cVP0K Y3ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=6SQfNRGxSjXRzedcsX9gd93FwU4XNVzxarlmDX1+Htg=; b=PTuV7JHGUWcAApA5HrrfqBGtso9Lec+igVU4u3/G3JPJu1NgajPEl5ISWyRaWHWve1 ZXPRebyOmIOIMzbhf5apT8gv0ccyC7mQhUBF0oHnHIfzXLXEUyf61UbRX2J+h2Htd/Ei WndkOGH3pRLsqxfbeA1VmKxY0esppTvIS2qmlzBdITiV+oNkjcQHUnj+C9kIhfEYgww4 Jm7sDzYWs0VBZP/gpgZ5U71pdt1Xm/qLQaKuvr4ys60tw9/UodDu+PL5b1S90CwHDjGx 3MVm5SKqnfEhUAgst8kM3jMoA1YLLXWmDoe4S5/F8Kc3pwsjkLnD+Vo20no9GW8NxmSF MQXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eI+o9nvw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o12si656934pgp.583.2021.04.14.14.19.39; Wed, 14 Apr 2021 14:21:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eI+o9nvw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232036AbhDNIoU (ORCPT + 99 others); Wed, 14 Apr 2021 04:44:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243057AbhDNIoE (ORCPT ); Wed, 14 Apr 2021 04:44:04 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8C58C061574 for ; Wed, 14 Apr 2021 01:43:41 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id r9so30170220ejj.3 for ; Wed, 14 Apr 2021 01:43:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=6SQfNRGxSjXRzedcsX9gd93FwU4XNVzxarlmDX1+Htg=; b=eI+o9nvwetyLFlEebNLWvXJTKP1fojiRNrpkjoQvQXmF8TZDu8IkJxXtAj0iumSH/L Oqnhc+/lGuZWPtl24duYGsLFeRXWlLxbRsVwUzOd4+IJ1kEPW7CoJJLSRxp307itbxOJ 48HMquiHGXIUpopas+i8vMSw2B9eA2bpMNgEfNbXAj4silYIfb+OibEjRXUsBQ56hztY zA40sC5EDA4WhSDUp8ykRzEdNoaxDT3ANeyYZdw38wX54PazAXCN6HdqIK16pwGvhKy8 mF8FQ2csq09pBwYFNZDkFNQIedRM1AXVM4aCZOiEsi+50Kmo+8kFph3Fv3bHXvuVRkHG 8pIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=6SQfNRGxSjXRzedcsX9gd93FwU4XNVzxarlmDX1+Htg=; b=cG7Xt32Xxsqsc+j3/IQ3roqButs99WURYObAbgp2RtdX2Rrbt960hR1e62SMDbWv48 o7WIrIUcBNdz8ObKHqEaD/GYH2ODIw6XQ++jcz216vzLx/OrSzNAjauwbzjmfAm8tels UfGEUKwNI4wcdAG3651DNG9ryGnV+CpEAzCGq6jMKytkRLHZ4OVQE926/Lwfoh/GPZvS nJc7RhRu2YrOjeKFKmLf5vhnnq+zF799lKBKtAwC/sxS6l/RKVLs/FvUdprQalhAQNDp Bgu2GUxOsHblP66w820UfZVpmjndENjDV1xkj3UnmkSsK7iOxOR9mgteLudjBdo1mZn1 lkdA== X-Gm-Message-State: AOAM532hnaqMLGyAcqV6ghb/DGf9bUsi+Wdsz+ZL8OjDHAFR8HoFWerV a+BzZkjcLrlSFDlmZERHEp2Tzw== X-Received: by 2002:a17:907:961b:: with SMTP id gb27mr35528345ejc.402.1618389820552; Wed, 14 Apr 2021 01:43:40 -0700 (PDT) Received: from dell ([91.110.221.215]) by smtp.gmail.com with ESMTPSA id w13sm10935849edc.81.2021.04.14.01.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Apr 2021 01:43:40 -0700 (PDT) Date: Wed, 14 Apr 2021 09:43:38 +0100 From: Lee Jones To: Wan Jiabing Cc: linux-kernel@vger.kernel.org, kael_w@yeah.net Subject: Re: [PATCH] mfd: abx500: Remove repeated struct declaration Message-ID: <20210414084338.GI4869@dell> References: <20210401093052.1004712-1-wanjiabing@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210401093052.1004712-1-wanjiabing@vivo.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 01 Apr 2021, Wan Jiabing wrote: > struct ab8500_fg is declared twice. The blew one at 457th line > is closer to user. Remove the duplicate here. > Move "Forward declaration" annotation to the suitable place. > > Signed-off-by: Wan Jiabing > --- > include/linux/mfd/abx500/ab8500-bm.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Please check, but I don't think this patch is valid anymore. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog