Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <d03e8b4ce25fe9e3b5e5597d83802eea83e7caa2.camel@perches.com>
Subject: Re: [PATCH 12/19] staging: rtl8723bs: remove unnecessary bracks on
 DBG_871X removal sites
From:   Joe Perches <joe@perches.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>,
        Fabio Aiuto <fabioaiuto83@gmail.com>
Cc:     gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Date:   Wed, 14 Apr 2021 01:32:27 -0700
In-Reply-To: <20210413145245.GG6021@kadam>
References: <cover.1617802415.git.fabioaiuto83@gmail.com>
         <35f5edf0f39b717b3de3ad7861cbaa5f4ba60576.1617802415.git.fabioaiuto83@gmail.com>
         <20210413145245.GG6021@kadam>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Tue, 2021-04-13 at 17:52 +0300, Dan Carpenter wrote:
> On Wed, Apr 07, 2021 at 03:49:36PM +0200, Fabio Aiuto wrote:
> > @@ -2586,11 +2583,9 @@ static int rtw_dbg_port(struct net_device *dev,
> > ?
> > 
> > ?								plist = get_next(plist);
> > ?
> > 
> > -								if (extra_arg == psta->aid) {
> > -									for (j = 0; j < 16; j++) {
> > +								if (extra_arg == psta->aid)
> > +									for (j = 0; j < 16; j++)
> > ?										preorder_ctrl = &psta->recvreorder_ctrl[j];
> > -									}
> > -								}
> 
> I think Greg already applied this so no stress (don't bother fixing),
> but you removed a bit too much on this one.  Multi-line indents normally
> get curly braces for readability.  In other words:
> 
> 				if (extra_arg == psta->aid) {
> 					for (j = 0; j < 16; j++)
> 						preorder_ctrl = &psta->recvreorder_ctrl[j];
> 				}
> 
> regards,
> dan carpenter
>