Received: by 2002:a05:6a10:17d3:0:0:0:0 with SMTP id hz19csp352650pxb; Wed, 14 Apr 2021 17:34:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyx9/ToBbn7B1f5P0Hw4L71kg51yGAThE7k4E6iq/lY/EI7dqi9TJoe3VcM+aIfA7Ij2myQ X-Received: by 2002:a17:906:a10e:: with SMTP id t14mr691639ejy.103.1618446882167; Wed, 14 Apr 2021 17:34:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618446882; cv=none; d=google.com; s=arc-20160816; b=KqcR2a0izgxF9NysNAnJirWxeq5yn01ME5EDRgveqO1dr6E7XSL+EICIHA24C7glD7 v+ZnRMD9ZcAy3NvGtVTiQMwTaqCCnPt2Q9KBMiZeLJI1lbmcbZX84+/CupMhTLNXXGWg ByCF1TF9Aj+fzii13XXe4J3e/PROmIDXaJJnpkJQ5PTvphc8jo+rJLgDiA5S+teYQUtu 4o2jx8nH3vXqD+b7Y71dDzBuCZFuY4iR9y60gma48vv7Gn97p2aCypowvvIOa7kPoaeE pZ6glqQaUJqTrbzBUrrw6/K533M0v7P4lxe6TAC+zXYjo22m7QLMo7oCVNfE3kpvcomF u76w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=9OWHrkFlyIz6unUzH5h2UbHwAatKHOO/WQEITHV/ixw=; b=EHmHr2q4jt1QYQfnpogf5gPqrgdjElTyN9N6YFlZ5RxDXCwqsDG4OQwj6qKqqWYT/E FaPvvGj2bxUz6VktcUN0Wspo4+hw4wJLh4Q0N93zwTQi8LEiemi8HHkNlyf7ouPLlPT6 0+iGoV6JxTUTVgB9GLwtg7S6TcJardG+u0eGRamb0xuIqfIwA8dExQOe6k1lyme7Tava BU0raEUDj+NwPZoFbJLSh175cKPbfqJSH60GkZVhvB4guEcMGpk4HhyC6sPfKcHh15KA 2WwouRd6HgDET7nNBfVuST8kTGupvsuGO2yorJBXWJixIb4M2SRAkwRo96o9OZn7+X6L Rzgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e5si721269ejl.220.2021.04.14.17.34.19; Wed, 14 Apr 2021 17:34:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350931AbhDNPxF (ORCPT + 99 others); Wed, 14 Apr 2021 11:53:05 -0400 Received: from verein.lst.de ([213.95.11.211]:59487 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352442AbhDNPvd (ORCPT ); Wed, 14 Apr 2021 11:51:33 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 65D2768C7B; Wed, 14 Apr 2021 17:51:08 +0200 (CEST) Date: Wed, 14 Apr 2021 17:51:08 +0200 From: Christoph Hellwig To: Tianyu Lan Cc: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, arnd@arndb.de, akpm@linux-foundation.org, gregkh@linuxfoundation.org, konrad.wilk@oracle.com, hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com, joro@8bytes.org, will@kernel.org, davem@davemloft.net, kuba@kernel.org, jejb@linux.ibm.com, martin.petersen@oracle.com, Tianyu Lan , iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-scsi@vger.kernel.org, netdev@vger.kernel.org, vkuznets@redhat.com, thomas.lendacky@amd.com, brijesh.singh@amd.com, sunilmut@microsoft.com Subject: Re: [Resend RFC PATCH V2 12/12] HV/Storvsc: Add Isolation VM support for storvsc driver Message-ID: <20210414155108.GF32045@lst.de> References: <20210414144945.3460554-1-ltykernel@gmail.com> <20210414144945.3460554-13-ltykernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210414144945.3460554-13-ltykernel@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Same comments as for the net driver. In addition to all the poking into kernel internals the fact that this is duplicated in the two main drivers should have been a huge red flag.